MIME-Version: 1.0
References: <202603182215.rvi6x75ekyba@alvherre.pgsql>
 <1074366.1773873680@sss.pgh.pa.us>
In-Reply-To: <1074366.1773873680@sss.pgh.pa.us>
From: Robert Haas <robertmhaas@gmail.com>
Date: Wed, 18 Mar 2026 19:15:29 -0400
Message-ID: 
 <CA+TgmobL-dx2na5pV+5vb82txf-tQQLMkaEYyE50CgKymEUk6w@mail.gmail.com>
Subject: Re: remove bits* types
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>,
	Nathan Bossart <nathandbossart@gmail.com>,
 Andres Freund <andres@anarazel.de>,
	Pg Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2BTgmobL-dx2na5pV%2B5vb82txf-tQQLMkaEYyE50CgKymEUk6w%40mail.gmail.com>
Precedence: bulk

On Wed, Mar 18, 2026 at 6:41=E2=80=AFPM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> In short: maybe we don't want to go in the direction Nathan suggests,
> but if we keep these types we should make an effort to use them
> more consistently, so there's work to be done in that direction too.

I'm definitely -1 on trying to use them more consistently. This is a
261 line patch. The reverse patch to use these types everywhere that
we use integers as a collection of bits is probably 100 times that
size. If you took that idea to its logical conclusion, every flags
variable in the backend would end up getting converted.

I'm not entirely sure that this is worth standardizing at all; if
someone thinks that using bits8 or whatever makes the code more rather
than less clear in a certain context, who am I to argue? If someone
else prefers uint8 in another context, also fine.

But if we are going to standardize, I think the only sensible choice
is what Nathan's done here. The reverse would be an insane amount of
code churn.

--=20
Robert Haas
EDB: http://www.enterprisedb.com