MIME-Version: 1.0
References: <aMoqFTfa-Or-rMFt@paquier.xyz>
 <4792B7EE-F449-47AD-9078-C827D43F1EEE@greg.burd.me>
In-Reply-To: <4792B7EE-F449-47AD-9078-C827D43F1EEE@greg.burd.me>
From: Robert Haas <robertmhaas@gmail.com>
Date: Wed, 17 Sep 2025 09:55:12 -0400
Message-ID: 
 <CA+TgmobSF4J_JWKdX=MWbG134Bn3OZ8LJyBP-_RQCykB=geaJw@mail.gmail.com>
Subject: Re: [PATCH] Add tests for Bitmapset
To: Greg Burd <greg@burd.me>
Cc: Michael Paquier <michael@paquier.xyz>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	Nathan Bossart <nathandbossart@gmail.com>,
 Masahiko Sawada <sawada.mshk@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2BTgmobSF4J_JWKdX%3DMWbG134Bn3OZ8LJyBP-_RQCykB%3DgeaJw%40mail.gmail.com>
Precedence: bulk

On Wed, Sep 17, 2025 at 9:18=E2=80=AFAM Greg Burd <greg@burd.me> wrote:
> > +static void
> > +elog_bitmapset(int elevel, const char *label, const Bitmapset *bms)
> >
>
> I added a function bms_values() that prints out the values contained in
> a bitmapset and changed a few tests to use it.  I removed the
> elog_bitmapset() as it isn't being used and now that it's easy to output
> the set in SQL why keep it for debugging?

How about using outBitmapset() which already exists?

--=20
Robert Haas
EDB: http://www.enterprisedb.com