MIME-Version: 1.0
References: 
 <CA+Tgmobvqqj-DW9F7uUzT-cQqs6wcVb-Xhs=w=hzJnXSE-kRGw@mail.gmail.com>
 <CA+TgmoYAwqmj+xyFc1R5XsB62iR2zDiYckr8Hf2f8biJ7k1sEw@mail.gmail.com>
 <CA+Tgmoan+BC0-XrLKUPs_XizNvk-kfZ01mVbF6BOM0m-Oxbdnw@mail.gmail.com>
 <DM4PR84MB17347D9466419413698105D8EE6F2@DM4PR84MB1734.NAMPRD84.PROD.OUTLOOK.COM>
 <CA+TgmoYH4-SkEy4H0huGCQKUDJ7uK2USvVaRju7+1oMiiBS0tg@mail.gmail.com>
 <212b0987-83e5-e2ae-c5e8-b8170fdaf3a0@gmail.com>
 <CA+Tgmob4wzU4QE6jz_-Bk4R7dYzKJ0SVS5oi3UpfqjnNopAGvQ@mail.gmail.com>
 <CAEze2Who3iG9QXbV9gbWp3WvuwSh5D65Dzv9ktZEyxpRb_QvkQ@mail.gmail.com>
 <CA+TgmoZd=pYk0owL4W2f4to9qFjwq_NmGJzXg44pEcMxuYriCA@mail.gmail.com>
 <CAEze2WizrxyWg+xeVMuyVqfZc-8U1myy1V4H3zwV-7xXztVf2w@mail.gmail.com>
 <CA+TgmoadPUdt8ZJ_Zem-T2_qZ5OTXVdxH6wGtnaV-TunN+LOHQ@mail.gmail.com>
 <CAEze2Wjbf==0=v+Ck8B2vcCeqD_3_SfDV3HtpEQiP-r3e2fsSA@mail.gmail.com>
In-Reply-To: 
 <CAEze2Wjbf==0=v+Ck8B2vcCeqD_3_SfDV3HtpEQiP-r3e2fsSA@mail.gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
Date: Wed, 17 Jan 2024 15:10:13 -0500
Message-ID: 
 <CA+TgmobTfzrnBesboXutZmrABdP79mO2HhXupY5YOdZ9VLWFog@mail.gmail.com>
Subject: Re: cleanup patches for incremental backup
To: Matthias van de Meent <boekewurm+postgres@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2BTgmobTfzrnBesboXutZmrABdP79mO2HhXupY5YOdZ9VLWFog%40mail.gmail.com>
Precedence: bulk

On Wed, Jan 17, 2024 at 1:42=E2=80=AFPM Matthias van de Meent
<boekewurm+postgres@gmail.com> wrote:
> Sure, added in attached.

I think this mostly looks good now but I just realized that I think
this needs rephrasing:

+     To restore incremental backups the tool <xref
linkend=3D"app-pgcombinebackup"/>
+     is used, which combines incremental backups with a base backup and
+     <glossterm linkend=3D"glossary-wal">WAL</glossterm> to restore a
+     <glossterm linkend=3D"glossary-db-cluster">database cluster</glosster=
m> to
+     a consistent state.

The way this is worded, at least to me, it makes it sound like
pg_combinebackup is going to do the WAL recovery for you, which it
isn't. Maybe:

To restore incremental backups the tool <xref
linkend=3D"app-pgcombinebackup"/> is used, which combines incremental
backups with a base backup. Afterwards, recovery can use <glossterm
linkend=3D"glossary-wal">WAL</glossterm> to bring the <glossterm
linkend=3D"glossary-db-cluster">database cluster</glossterm> to a
consistent state.

--=20
Robert Haas
EDB: http://www.enterprisedb.com