public inbox for [email protected]help / color / mirror / Atom feed
[PATCH 06/10] Default to LZ4.. 3+ messages / 3 participants [nested] [flat]
* [PATCH 06/10] Default to LZ4.. @ 2021-03-12 21:35 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 3+ messages in thread From: Justin Pryzby @ 2021-03-12 21:35 UTC (permalink / raw) this is meant to exercise in the CIs, and not meant to be merged --- configure | 6 ++++-- configure.ac | 4 ++-- src/backend/access/transam/xlog.c | 2 +- src/backend/utils/misc/guc.c | 2 +- 4 files changed, 8 insertions(+), 6 deletions(-) diff --git a/configure b/configure index fed440adcf..8d76be00c1 100755 --- a/configure +++ b/configure @@ -1575,7 +1575,7 @@ Optional Packages: --with-system-tzdata=DIR use system time zone data in DIR --without-zlib do not use Zlib - --with-lz4 build with LZ4 support + --without-lz4 build without LZ4 support --with-gnu-ld assume the C compiler uses GNU ld [default=no] --with-ssl=LIB use LIB for SSL/TLS support (openssl) --with-openssl obsolete spelling of --with-ssl=openssl @@ -8598,7 +8598,9 @@ $as_echo "#define USE_LZ4 1" >>confdefs.h esac else - with_lz4=no + with_lz4=yes + +$as_echo "#define USE_LZ4 1" >>confdefs.h fi diff --git a/configure.ac b/configure.ac index 8c454128bb..bfcdc88be0 100644 --- a/configure.ac +++ b/configure.ac @@ -990,8 +990,8 @@ AC_SUBST(with_zlib) # LZ4 # AC_MSG_CHECKING([whether to build with LZ4 support]) -PGAC_ARG_BOOL(with, lz4, no, [build with LZ4 support], - [AC_DEFINE([USE_LZ4], 1, [Define to 1 to build with LZ4 support. (--with-lz4)])]) +PGAC_ARG_BOOL(with, lz4, yes, [build without LZ4 support], + [AC_DEFINE([USE_LZ4], 1, [Define to 1 to build without LZ4 support. (--without-lz4)])]) AC_MSG_RESULT([$with_lz4]) AC_SUBST(with_lz4) diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c index 984ce39cc7..3657f74de9 100644 --- a/src/backend/access/transam/xlog.c +++ b/src/backend/access/transam/xlog.c @@ -99,7 +99,7 @@ bool EnableHotStandby = false; bool fullPageWrites = true; bool wal_log_hints = false; bool wal_compression = false; -int wal_compression_method = WAL_COMPRESSION_ZLIB; +int wal_compression_method = WAL_COMPRESSION_LZ4; char *wal_consistency_checking_string = NULL; bool *wal_consistency_checking = NULL; bool wal_init_zero = true; diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c index c37a8313d3..52f9cd0242 100644 --- a/src/backend/utils/misc/guc.c +++ b/src/backend/utils/misc/guc.c @@ -4728,7 +4728,7 @@ static struct config_enum ConfigureNamesEnum[] = NULL }, &wal_compression_method, - WAL_COMPRESSION_ZLIB, wal_compression_options, + WAL_COMPRESSION_LZ4, wal_compression_options, NULL, NULL, NULL }, -- 2.17.0 --jozmn01XJZjDjM3N Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0007-add-wal_compression_method-zstd.patch" ^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: A wrong comment about search_indexed_tlist_for_var @ 2024-05-14 17:07 Robert Haas <[email protected]> 2024-05-16 09:58 ` Re: A wrong comment about search_indexed_tlist_for_var Richard Guo <[email protected]> 0 siblings, 1 reply; 3+ messages in thread From: Robert Haas @ 2024-05-14 17:07 UTC (permalink / raw) To: Richard Guo <[email protected]>; +Cc: Tom Lane <[email protected]>; Alvaro Herrera <[email protected]>; pgsql-hackers On Mon, Dec 4, 2023 at 3:42 AM Richard Guo <[email protected]> wrote: > Then here is a trivial patch to adjust the comment, which should get > reverted along with 867be9c07. Richard, since you're a committer now, maybe you'd like to commit this. I don't really understand the portion of your commit message inside the parentheses and would suggest that you just delete that, but the rest seems fine. If you do commit it, also update the status at https://commitfest.postgresql.org/48/4683/ -- Robert Haas EDB: http://www.enterprisedb.com ^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: A wrong comment about search_indexed_tlist_for_var 2024-05-14 17:07 Re: A wrong comment about search_indexed_tlist_for_var Robert Haas <[email protected]> @ 2024-05-16 09:58 ` Richard Guo <[email protected]> 0 siblings, 0 replies; 3+ messages in thread From: Richard Guo @ 2024-05-16 09:58 UTC (permalink / raw) To: Robert Haas <[email protected]>; +Cc: Tom Lane <[email protected]>; Alvaro Herrera <[email protected]>; pgsql-hackers On Wed, May 15, 2024 at 1:07 AM Robert Haas <[email protected]> wrote: > On Mon, Dec 4, 2023 at 3:42 AM Richard Guo <[email protected]> wrote: > > Then here is a trivial patch to adjust the comment, which should get > > reverted along with 867be9c07. > > Richard, since you're a committer now, maybe you'd like to commit > this. I don't really understand the portion of your commit message > inside the parentheses and would suggest that you just delete that, > but the rest seems fine. > > If you do commit it, also update the status at > https://commitfest.postgresql.org/48/4683/ Thank you for the suggestion. Yeah, this is a good candidate for my first commit. :-) I will aim to do it during the next commitfest. Thanks Richard ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2024-05-16 09:58 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-03-12 21:35 [PATCH 06/10] Default to LZ4.. Justin Pryzby <[email protected]> 2024-05-14 17:07 Re: A wrong comment about search_indexed_tlist_for_var Robert Haas <[email protected]> 2024-05-16 09:58 ` Re: A wrong comment about search_indexed_tlist_for_var Richard Guo <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox