MIME-Version: 1.0
References: 
 <CA+TgmoZ-Jh1T6QyWoCODMVQdhTUPYkaZjWztzP1En4=ZHoKPzw@mail.gmail.com>
 <CA+TgmoZUN8FT1Ah=m6Uis5bHa4FUa+_hMDWtcABG17toEfpiUg@mail.gmail.com>
 <CA+TgmoYh2-kM+tscOz=jVYq9Tf4SRPVqzPojs3KLZcW6E9m1BQ@mail.gmail.com>
 <CA+TgmoaK=4w7-qknUo3QhUJ53pXZq=c=KgZmRyD+k7ytqfmgSg@mail.gmail.com>
 <CAP53Pkz3DSFaaowYvbO5LULf3NhydD_UhHkighfWf6_pwxiqUw@mail.gmail.com>
 <CA+TgmoZ45n5jaNKKgbbj4-kYV8WsPvUn=Z8HnoZ7tUb_p9WKXg@mail.gmail.com>
 <CA+TgmoYuWmN-00Ec5pY7zAcpSFQUQLbgAdVWGR9kOR-HM-fHrA@mail.gmail.com>
 <CAP53Pkzn_wZ-R-cPdD9XSQ9+myPUUsPMMqVBPNG3XWXhgfm1-Q@mail.gmail.com>
 <CA+Tgmobxbju8PrY_NULtPr7b7UShp4+Jqibm2Bou8TVS69gObQ@mail.gmail.com>
 <3683430.1775173413@sss.pgh.pa.us>
 <CA+TgmoadkuOMJjvYe2h6aznHFeePprGEQ8CgUpRK=47sB6DMAg@mail.gmail.com>
 <3817825.1775240432@sss.pgh.pa.us>
 <CA+TgmoY+g1u-fN=3igXG-8u0Ho3V4u-ooWXCj-FQ9DA=uGek9g@mail.gmail.com>
 <3877210.1775272486@sss.pgh.pa.us>
 <386d8c06-0f96-40bb-b1b1-107db209c676@gmail.com>
In-Reply-To: <386d8c06-0f96-40bb-b1b1-107db209c676@gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
Date: Sat, 4 Apr 2026 14:42:19 -0400
Message-ID: 
 <CA+Tgmoben3_8rZbQ2X2+gOBOFpOgkc9hx3-z9e_Q_kHCfuW25g@mail.gmail.com>
Subject: Re: pg_plan_advice
To: Andrei Lepikhov <lepihov@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Alexander Lakhin <exclusion@gmail.com>,
	Lukas Fittl <lukas@fittl.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2BTgmoben3_8rZbQ2X2%2BgOBOFpOgkc9hx3-z9e_Q_kHCfuW25g%40mail.gmail.com>
Precedence: bulk

On Sat, Apr 4, 2026 at 5:34=E2=80=AFAM Andrei Lepikhov <lepihov@gmail.com> =
wrote:
> As you work on the code, please keep the pg_plan_advice issue [1] in
> mind. I came across it while designing the optimisation in [2]. Even if
> [2] is not added to the Postgres core, this still looks like a valid
> query plan and may be proposed by an extension. So, the hinting module
> should avoid conflicts with other extensions, just as pg_hint_plan does.
>
> [1] pg_plan_advice fails when NestLoop outer side is Sort over FunctionSc=
an
> https://www.postgresql.org/message-id/78dd9572-7569-4025-984d-e07d7f381b6=
e@gmail.com
> [2] Try a presorted outer path when referenced by an ORDER BY prefix
> https://www.postgresql.org/message-id/19a9265c-c441-4a43-bc0d-dac533438da=
0%40gmail.com

I'll take a look at that issue when I have a free moment. We certainly
cannot promise in general that pg_plan_advice will be able to make
sense of plans that PostgreSQL's own planner does not produce; that
would require magical code. But there might be something that can be
done to ameliorate this particular instance.

By the way, I'm really glad you hit that error. That particular error
check is there precisely to find plans that pg_plan_advice isn't able
to understand, and it sounds like it is doing its job as intended.
Having problems isn't great, but knowing that you have problems is a
lot better than still having them but not knowing about it.

--=20
Robert Haas
EDB: http://www.enterprisedb.com