MIME-Version: 1.0
From: Imran Zaheer <imran.zhir@gmail.com>
Date: Thu, 2 Apr 2026 14:49:51 +0500
Message-ID: 
 <CA+UBfa=H9RQdZ8Tof+SF7gMC-FTrsJ_w=Vnxs4OiBAaB_go+tQ@mail.gmail.com>
Subject: Silence -Wmaybe-uninitialized warnings
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000e40188064e771fbc"
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2BUBfa%3DH9RQdZ8Tof%2BSF7gMC-FTrsJ_w%3DVnxs4OiBAaB_go%2BtQ%40mail.gmail.com>
Precedence: bulk

--000000000000e40188064e771fbc
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi

When building postgresql with CFLAGS=3D"-Og" gcc emits
'-Wmaybe-uninitialized' warnings at few places. The variables are
initialized on all execution paths but the compiler was not able to
prove it with the additional optimization flag enabled. The patch
initializes the variables with NULL to silence the warnings. No
functional change intended.

```
[646/2085] Compiling C object
src/backend/postgres_lib.a.p/commands_copyfromparse.c.o
../src/backend/commands/copyfromparse.c: In function =E2=80=98CopyFromTextO=
neRow=E2=80=99:
../src/backend/commands/copyfromparse.c:995:39: warning:
=E2=80=98field_strings=E2=80=99 may be used uninitialized in this function
[-Wmaybe-uninitialized]
  995 |                 string =3D field_strings[fieldno++];
      |                                       ^
../src/backend/commands/copyfromparse.c:961:21: note: =E2=80=98field_string=
s=E2=80=99
was declared here
  961 |         char      **field_strings;
      |                     ^~~~~~~~~~~~~
../src/backend/commands/copyfromparse.c: In function =E2=80=98CopyFromCSVOn=
eRow=E2=80=99:
../src/backend/commands/copyfromparse.c:995:39: warning:
=E2=80=98field_strings=E2=80=99 may be used uninitialized in this function
[-Wmaybe-uninitialized]
  995 |                 string =3D field_strings[fieldno++];
      |                                       ^
../src/backend/commands/copyfromparse.c:961:21: note: =E2=80=98field_string=
s=E2=80=99
was declared here
  961 |         char      **field_strings;
      |                     ^~~~~~~~~~~~~
[889/2085] Compiling C object
src/backend/postgres_lib.a.p/partitioning_partbounds.c.o
../src/backend/partitioning/partbounds.c: In function
=E2=80=98check_partition_bounds_for_split_range=E2=80=99:
../src/backend/partitioning/partbounds.c:5452:57: warning: =E2=80=98datum=
=E2=80=99 may
be used uninitialized in this function [-Wmaybe-uninitialized]
 5452 |
parser_errposition(pstate, exprLocation((Node *) datum)));
      |
```
gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0


Regards
Imran Zaheer

--000000000000e40188064e771fbc
Content-Type: text/x-patch; charset="US-ASCII";
	name="v1-0001-Silence-Wmaybe-uninitialized-warnings.patch"
Content-Disposition: attachment;
	filename="v1-0001-Silence-Wmaybe-uninitialized-warnings.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mnh9fi7y0>
X-Attachment-Id: f_mnh9fi7y0

RnJvbSA1OGVjMzIyZGUyZjIxMDM1NWU2ZWMxYTE2ZGY0OTg4YmU2M2U1YWNiIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBJbXJhbiBaYWhlZXIgPGltcmFuLnpoaXJAZ21haWwuY29tPgpE
YXRlOiBUaHUsIDIgQXByIDIwMjYgMTQ6MDI6NDcgKzA1MDAKU3ViamVjdDogW1BBVENIIHYxXSBT
aWxlbmNlIC1XbWF5YmUtdW5pbml0aWFsaXplZCB3YXJuaW5ncwoKV2hlbiBidWlsZGluZyB3aXRo
IENGTEFHUz0iLU9nIiwgR0NDIHdhcyBlbWl0dGluZwotV21heWJlLXVuaW5pdGlhbGl6ZWQgd2Fy
bmluZ3MgZm9yIHNvbWUgdmFyaWFibGVzLgoKSW5pdGlhbGl6ZSB2YXJpYWJsZXMgdG8gTlVMTCB0
byBzaWxlbmNlIHRoZSB3YXJuaW5ncy4KLS0tCiBzcmMvYmFja2VuZC9jb21tYW5kcy9jb3B5ZnJv
bXBhcnNlLmMgIHwgMiArLQogc3JjL2JhY2tlbmQvcGFydGl0aW9uaW5nL3BhcnRib3VuZHMuYyB8
IDIgKy0KIDIgZmlsZXMgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoK
ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL2NvbW1hbmRzL2NvcHlmcm9tcGFyc2UuYyBiL3NyYy9i
YWNrZW5kL2NvbW1hbmRzL2NvcHlmcm9tcGFyc2UuYwppbmRleCA2NWZkNWEwYWI0Zi4uY2IyYWFj
NTRhMzQgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL2NvbW1hbmRzL2NvcHlmcm9tcGFyc2UuYwor
KysgYi9zcmMvYmFja2VuZC9jb21tYW5kcy9jb3B5ZnJvbXBhcnNlLmMKQEAgLTk1OCw3ICs5NTgs
NyBAQCBDb3B5RnJvbVRleHRMaWtlT25lUm93KENvcHlGcm9tU3RhdGUgY3N0YXRlLCBFeHByQ29u
dGV4dCAqZWNvbnRleHQsCiAJRm1nckluZm8gICAqaW5fZnVuY3Rpb25zID0gY3N0YXRlLT5pbl9m
dW5jdGlvbnM7CiAJT2lkCQkgICAqdHlwaW9wYXJhbXMgPSBjc3RhdGUtPnR5cGlvcGFyYW1zOwog
CUV4cHJTdGF0ZSAqKmRlZmV4cHJzID0gY3N0YXRlLT5kZWZleHByczsKLQljaGFyCSAgKipmaWVs
ZF9zdHJpbmdzOworCWNoYXIJICAqKmZpZWxkX3N0cmluZ3MgPSBOVUxMOwogCUxpc3RDZWxsICAg
KmN1cjsKIAlpbnQJCQlmbGRjdDsKIAlpbnQJCQlmaWVsZG5vOwpkaWZmIC0tZ2l0IGEvc3JjL2Jh
Y2tlbmQvcGFydGl0aW9uaW5nL3BhcnRib3VuZHMuYyBiL3NyYy9iYWNrZW5kL3BhcnRpdGlvbmlu
Zy9wYXJ0Ym91bmRzLmMKaW5kZXggZjg2N2QxYjc1YTUuLjNlNjA4ZDZmMjE3IDEwMDY0NAotLS0g
YS9zcmMvYmFja2VuZC9wYXJ0aXRpb25pbmcvcGFydGJvdW5kcy5jCisrKyBiL3NyYy9iYWNrZW5k
L3BhcnRpdGlvbmluZy9wYXJ0Ym91bmRzLmMKQEAgLTUzNzUsNyArNTM3NSw3IEBAIGNoZWNrX3Bh
cnRpdGlvbl9ib3VuZHNfZm9yX3NwbGl0X3JhbmdlKFJlbGF0aW9uIHBhcmVudCwKIAlpZiAoZmly
c3QgfHwgbGFzdCkKIAl7CiAJCVBhcnRpdGlvbkJvdW5kU3BlYyAqc3BsaXRfc3BlYyA9IGdldF9w
YXJ0aXRpb25fYm91bmRfc3BlYyhzcGxpdFBhcnRPaWQpOwotCQlQYXJ0aXRpb25SYW5nZURhdHVt
ICpkYXR1bTsKKwkJUGFydGl0aW9uUmFuZ2VEYXR1bSAqZGF0dW0gPSBOVUxMOwogCiAJCWlmIChm
aXJzdCkKIAkJewotLSAKMi4zNC4xCgo=
--000000000000e40188064e771fbc--