MIME-Version: 1.0
From: Imran Zaheer <imran.zhir@gmail.com>
Date: Fri, 3 Apr 2026 18:56:01 +0500
Message-ID: 
 <CA+UBfa=qqnpx-B_dTy4KCYEyXCmST_Zv9X1DL3Yw0mccmzOaaQ@mail.gmail.com>
Subject: Remove commented-out code in 026_overwrite_contrecord.pl
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="00000000000010c539064e8eae8a"
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2BUBfa%3Dqqnpx-B_dTy4KCYEyXCmST_Zv9X1DL3Yw0mccmzOaaQ%40mail.gmail.com>
Precedence: bulk

--00000000000010c539064e8eae8a
Content-Type: multipart/alternative; boundary="00000000000010c538064e8eae88"

--00000000000010c538064e8eae88
Content-Type: text/plain; charset="UTF-8"

Hi

There is some unused commented line of code in the tap test file `
026_overwrite_contrecord.pl` [1]. Looks like a left over from earlier test
development.

Remove it for clarity.

Thanks,
Imran Zaheer

[1]:
https://github.com/postgres/postgres/blob/b7b27eb41a5cc0b45a1a9ce5c1cde5883d7bc358/src/test/recovery/t/026_overwrite_contrecord.pl#L61

--00000000000010c538064e8eae88
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi<br><br>There is some unused commented line of code in t=
he tap test file `<a href=3D"http://026_overwrite_contrecord.pl">026_overwr=
ite_contrecord.pl</a><span class=3D"">` [1]. Looks like a left over from ea=
rlier test development.=C2=A0<br><br>Remove it for clarity.<br><br>Thanks,<=
br>Imran Zaheer<br><br>[1]:=C2=A0</span><a href=3D"https://github.com/postg=
res/postgres/blob/b7b27eb41a5cc0b45a1a9ce5c1cde5883d7bc358/src/test/recover=
y/t/026_overwrite_contrecord.pl#L61">https://github.com/postgres/postgres/b=
lob/b7b27eb41a5cc0b45a1a9ce5c1cde5883d7bc358/src/test/recovery/t/026_overwr=
ite_contrecord.pl#L61</a></div>

--00000000000010c538064e8eae88--

--00000000000010c539064e8eae8a
Content-Type: text/x-patch; charset="US-ASCII";
	name="v1-0001-Remove-commented-code-in-026_overwrite_contrecord.patch"
Content-Disposition: attachment;
	filename="v1-0001-Remove-commented-code-in-026_overwrite_contrecord.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mniy68ap0>
X-Attachment-Id: f_mniy68ap0

RnJvbSA1ZWVkYWY3ZmQzYzY5NTE2MDkxYTUzZWUyODEwNTYzMjBkM2Y1YjIxIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBJbXJhbiBaYWhlZXIgPGltcmFuLnphaGVlckBjeWJlcnRlYy5h
dD4KRGF0ZTogRnJpLCAzIEFwciAyMDI2IDE4OjMxOjAzICswNTAwClN1YmplY3Q6IFtQQVRDSCB2
MV0gUmVtb3ZlIGNvbW1lbnRlZCBjb2RlIGluIDAyNl9vdmVyd3JpdGVfY29udHJlY29yZAoKVGhp
cyBjb21tZW50ZWQtb3V0IENSRUFURSBUQUJMRSBzdGF0ZW1lbnQgYXBwZWFycyB0byBiZSBhIGxl
ZnRvdmVyIGZyb20KZWFybGllciB0ZXN0IGRldmVsb3BtZW50IGFuZCBpcyBub3QgdXNlZCBpbiB0
aGUgdGVzdC4gUmVtb3ZlIGl0IGZvciBjbGFyaXR5LgotLS0KIHNyYy90ZXN0L3JlY292ZXJ5L3Qv
MDI2X292ZXJ3cml0ZV9jb250cmVjb3JkLnBsIHwgMiArLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5z
ZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL3Rlc3QvcmVjb3Zlcnkv
dC8wMjZfb3ZlcndyaXRlX2NvbnRyZWNvcmQucGwgYi9zcmMvdGVzdC9yZWNvdmVyeS90LzAyNl9v
dmVyd3JpdGVfY29udHJlY29yZC5wbAppbmRleCA0ZjUwMTE2OWY0Mi4uODI1NjdjYTZiZmMgMTAw
NjQ0Ci0tLSBhL3NyYy90ZXN0L3JlY292ZXJ5L3QvMDI2X292ZXJ3cml0ZV9jb250cmVjb3JkLnBs
CisrKyBiL3NyYy90ZXN0L3JlY292ZXJ5L3QvMDI2X292ZXJ3cml0ZV9jb250cmVjb3JkLnBsCkBA
IC01OCw3ICs1OCw3IEBAIG15ICRpbml0ZmlsZSA9ICRub2RlLT5zYWZlX3BzcWwoJ3Bvc3RncmVz
JywKICRub2RlLT5zYWZlX3BzcWwoJ3Bvc3RncmVzJywKIAlxcXtTRUxFQ1QgcGdfbG9naWNhbF9l
bWl0X21lc3NhZ2UodHJ1ZSwgJ3Rlc3QgMDI2JywgcmVwZWF0KCd4eXp4eicsIDEyMzQ1NikpfQog
KTsKLSMkbm9kZS0+c2FmZV9wc3FsKCdwb3N0Z3JlcycsIHFxe2NyZWF0ZSB0YWJsZSBmb28gKCl9
KTsKKwogbXkgJGVuZGZpbGUgPSAkbm9kZS0+c2FmZV9wc3FsKCdwb3N0Z3JlcycsCiAJJ1NFTEVD
VCBwZ193YWxmaWxlX25hbWUocGdfY3VycmVudF93YWxfaW5zZXJ0X2xzbigpKScpOwogb2soJGlu
aXRmaWxlIG5lICRlbmRmaWxlLCAiJGluaXRmaWxlIGRpZmZlcnMgZnJvbSAkZW5kZmlsZSIpOwot
LSAKMi4zNC4xCgo=
--00000000000010c539064e8eae8a--