MIME-Version: 1.0
References: 
 <CA+vA85_5GTu+HHniSbvvP+8k3=xZO=WE84NPwiKyxztqvpfZ3Q@mail.gmail.com>
 <CA+vA8587=RpZuL+EJ=XKM-8-xdPxz2mFexbAjaimN+OkXysXqw@mail.gmail.com>
 <CA+Yyo5RihTRUdUdanuNYhjQeXQY6412FWjzaxJAQR5MGX83=EQ@mail.gmail.com>
In-Reply-To: 
 <CA+Yyo5RihTRUdUdanuNYhjQeXQY6412FWjzaxJAQR5MGX83=EQ@mail.gmail.com>
From: Stepan Neretin <slpmcf@gmail.com>
Date: Sat, 10 May 2025 18:01:54 +0700
Message-ID: 
 <CA+Yyo5Qw=v2bcPSeyGgX3WuHeDXm7vxPcET1n+yUreUmO0rk_A@mail.gmail.com>
Subject: Re: Proposal for enabling auto-vectorization for checksum
 calculations
To: Matthew Sterrett <matthewsterrett2@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org,
	"Devulapalli, Raghuveer" <raghuveer.devulapalli@intel.com>,
	"Shankaran, Akash" <akash.shankaran@intel.com>
Content-Type: multipart/mixed; boundary="0000000000006a9d5c0634c60302"
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2BYyo5Qw%3Dv2bcPSeyGgX3WuHeDXm7vxPcET1n%2ByUreUmO0rk_A%40mail.gmail.com>
Precedence: bulk

--0000000000006a9d5c0634c60302
Content-Type: multipart/alternative; boundary="0000000000006a9d5b0634c60300"

--0000000000006a9d5b0634c60300
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sat, May 10, 2025 at 6:01=E2=80=AFPM Stepan Neretin <slpmcf@gmail.com> w=
rote:

>
>
> On Thu, May 8, 2025 at 6:57=E2=80=AFAM Matthew Sterrett <
> matthewsterrett2@gmail.com> wrote:
>
>> Hello! I'm still trying to figure out those CI failures, I just wanted
>> to update things.
>>
>> From my testing, with this patch repeatedly disabling/enabling
>> checksums is about 12.4% on an approximately 15 GB database.
>>
>> By the way, I'd love it if anyone could help me figure out how to
>> replicate a CI failure in the Cirrus CI.
>> I haven't been able to figure out how to test CI runs locally, does
>> anyone know a good method to do that?
>>
>>
>>
> Hi Matthew,
>
> Thanks for the patch!
>
> I ran some timing tests:
>
> (without avx2)
>
> Time: 4034.351 ms
> SELECT drive_pg_checksum(512);
>
> (with avx2)
>
>
> Time: 3559.076 ms
> SELECT drive_pg_checksum(512);
>
> Also attached two patches that should fix the CI issues.
>
> Best,
>
> Stepan Neretin
>
>
>
Oops, forgot to attach patches :)

Best,

Stepan Neretin

--0000000000006a9d5b0634c60300
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote g=
mail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Sat, May 10,=
 2025 at 6:01=E2=80=AFPM Stepan Neretin &lt;<a href=3D"mailto:slpmcf@gmail.=
com">slpmcf@gmail.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_qu=
ote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,20=
4);padding-left:1ex"><div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div c=
lass=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Thu, May 8, 2=
025 at 6:57=E2=80=AFAM Matthew Sterrett &lt;<a href=3D"mailto:matthewsterre=
tt2@gmail.com" target=3D"_blank">matthewsterrett2@gmail.com</a>&gt; wrote:<=
br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8e=
x;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hello! I&#39;m s=
till trying to figure out those CI failures, I just wanted<br>
to update things.<br>
<br>