MIME-Version: 1.0
References: 
 <CA+vA85_5GTu+HHniSbvvP+8k3=xZO=WE84NPwiKyxztqvpfZ3Q@mail.gmail.com>
 <CA+vA8587=RpZuL+EJ=XKM-8-xdPxz2mFexbAjaimN+OkXysXqw@mail.gmail.com>
In-Reply-To: 
 <CA+vA8587=RpZuL+EJ=XKM-8-xdPxz2mFexbAjaimN+OkXysXqw@mail.gmail.com>
From: Stepan Neretin <slpmcf@gmail.com>
Date: Sat, 10 May 2025 18:01:06 +0700
Message-ID: 
 <CA+Yyo5RihTRUdUdanuNYhjQeXQY6412FWjzaxJAQR5MGX83=EQ@mail.gmail.com>
Subject: Re: Proposal for enabling auto-vectorization for checksum
 calculations
To: Matthew Sterrett <matthewsterrett2@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org,
	"Devulapalli, Raghuveer" <raghuveer.devulapalli@intel.com>,
	"Shankaran, Akash" <akash.shankaran@intel.com>
Content-Type: multipart/alternative; boundary="00000000000083f63c0634c600d1"
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2BYyo5RihTRUdUdanuNYhjQeXQY6412FWjzaxJAQR5MGX83%3DEQ%40mail.gmail.com>
Precedence: bulk

--00000000000083f63c0634c600d1
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, May 8, 2025 at 6:57=E2=80=AFAM Matthew Sterrett <matthewsterrett2@g=
mail.com>
wrote:

> Hello! I'm still trying to figure out those CI failures, I just wanted
> to update things.
>
> From my testing, with this patch repeatedly disabling/enabling
> checksums is about 12.4% on an approximately 15 GB database.
>
> By the way, I'd love it if anyone could help me figure out how to
> replicate a CI failure in the Cirrus CI.
> I haven't been able to figure out how to test CI runs locally, does
> anyone know a good method to do that?
>
>
>
Hi Matthew,

Thanks for the patch!

I ran some timing tests:

(without avx2)

Time: 4034.351 ms
SELECT drive_pg_checksum(512);

(with avx2)


Time: 3559.076 ms
SELECT drive_pg_checksum(512);

Also attached two patches that should fix the CI issues.

Best,

Stepan Neretin

--00000000000083f63c0634c600d1
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote g=
mail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Thu, May 8, =
2025 at 6:57=E2=80=AFAM Matthew Sterrett &lt;<a href=3D"mailto:matthewsterr=
ett2@gmail.com">matthewsterrett2@gmail.com</a>&gt; wrote:<br></div><blockqu=
ote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px=
 solid rgb(204,204,204);padding-left:1ex">Hello! I&#39;m still trying to fi=
gure out those CI failures, I just wanted<br>
to update things.<br>
<br>