MIME-Version: 1.0
From: Baji Shaik <baji.pgdev@gmail.com>
Date: Sun, 24 May 2026 21:38:53 -0500
Message-ID: 
 <CA+fm-RMrKbyky_+vi5SDdAVnFVjWh7zW3GoDAVnrp5OpDnW6tw@mail.gmail.com>
Subject: [PATCH] Two small errhint cleanups in PG19 code
To: pgsql-hackers@lists.postgresql.org
Content-Type: multipart/mixed; boundary="00000000000037c54b06529b4817"
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2Bfm-RMrKbyky_%2Bvi5SDdAVnFVjWh7zW3GoDAVnrp5OpDnW6tw%40mail.gmail.com>
Precedence: bulk

--00000000000037c54b06529b4817
Content-Type: multipart/alternative; boundary="00000000000037c54a06529b4815"

--00000000000037c54a06529b4815
Content-Type: text/plain; charset="UTF-8"

Hi,

While exploring new features in PG19, I came across two unrelated
small errhint issues. Sending them as separate patches in one thread since
they touch
unrelated subsystems and can be reviewed/committed independently.

Patch 0001 -- Remove stray word in pg_restore_extended_stats() errhint
The errhint in import_pg_statistic() reads:

      Value of element "%s" must be type a null or a string.

  The word "type" is a stray word that doesn't belong; the intent is
  "must be a null or a string".

Patch 0002 -- Add missing period to online data checksums errhint
  The errhint emitted when StartupXLOG() detects an interrupted
  "enabling data checksums" run is missing a trailing period:

      Data checksum processing must be manually restarted for
      checksums to be enabled

Thanks,
Baji Shaik

--00000000000037c54a06529b4815
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi,<br><br>While exploring new features in PG19, I came ac=
ross two unrelated<br>small errhint issues. Sending them as separate patche=
s in one thread since they touch<br>unrelated subsystems and can be reviewe=
d/committed independently.<br><br>Patch 0001 -- Remove stray word in pg_res=
tore_extended_stats() errhint<br>The errhint in import_pg_statistic() reads=
:<br><br>=C2=A0 =C2=A0 =C2=A0 Value of element &quot;%s&quot; must be type =
a null or a string.<br><br>=C2=A0 The word &quot;type&quot; is a stray word=
 that doesn&#39;t belong; the intent is<br>=C2=A0 &quot;must be a null or a=
 string&quot;.<br><br>Patch 0002 -- Add missing period to online data check=
sums errhint<br>=C2=A0 The errhint emitted when StartupXLOG() detects an in=
terrupted<br>=C2=A0 &quot;enabling data checksums&quot; run is missing a tr=
ailing period:<br><br>=C2=A0 =C2=A0 =C2=A0 Data checksum processing must be=
 manually restarted for<br>=C2=A0 =C2=A0 =C2=A0 checksums to be enabled<br>=
<br>Thanks,<br>Baji Shaik</div>

--00000000000037c54a06529b4815--

--00000000000037c54b06529b4817
Content-Type: application/octet-stream;
	name="0002-Add-missing-period-to-online-data-checksums-errhint.patch"
Content-Disposition: attachment;
	filename="0002-Add-missing-period-to-online-data-checksums-errhint.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mpklio9f0>
X-Attachment-Id: f_mpklio9f0

RnJvbSA4NDRlYzFmZWFmY2Q1ZDBiZTFlYjNmMmI2YmM4YzlkNDNmN2YzNzUxIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBCYWppIFNoYWlrIDxiYWppLnBnZGV2QGdtYWlsLmNvbT4KRGF0
ZTogRnJpLCAyMiBNYXkgMjAyNiAxMTo0Nzo0NSAtMDUwMApTdWJqZWN0OiBbUEFUQ0ggMi8yXSBB
ZGQgbWlzc2luZyBwZXJpb2QgdG8gb25saW5lIGRhdGEgY2hlY2tzdW1zIGVycmhpbnQKClRoZSBl
cnJoaW50IGVtaXR0ZWQgd2hlbiBTdGFydHVwWExPRygpIGRldGVjdHMgYW4gaW50ZXJydXB0ZWQK
ImVuYWJsaW5nIGRhdGEgY2hlY2tzdW1zIiBydW4gaXMgbWlzc2luZyBhIHRyYWlsaW5nIHBlcmlv
ZDoKCiAgICBEYXRhIGNoZWNrc3VtIHByb2Nlc3NpbmcgbXVzdCBiZSBtYW51YWxseSByZXN0YXJ0
ZWQgZm9yIGNoZWNrc3VtcwogICAgdG8gYmUgZW5hYmxlZAoKQWRkIHRoZSBtaXNzaW5nIHBlcmlv
ZC4KLS0tCiBzcmMvYmFja2VuZC9hY2Nlc3MvdHJhbnNhbS94bG9nLmMgfCAyICstCiAxIGZpbGUg
Y2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9zcmMv
YmFja2VuZC9hY2Nlc3MvdHJhbnNhbS94bG9nLmMgYi9zcmMvYmFja2VuZC9hY2Nlc3MvdHJhbnNh
bS94bG9nLmMKaW5kZXggYmVkZGNiNTUyZDYuLmZlY2RmMGQ0YjA1IDEwMDY0NAotLS0gYS9zcmMv
YmFja2VuZC9hY2Nlc3MvdHJhbnNhbS94bG9nLmMKKysrIGIvc3JjL2JhY2tlbmQvYWNjZXNzL3Ry
YW5zYW0veGxvZy5jCkBAIC02NjEyLDcgKzY2MTIsNyBAQCBTdGFydHVwWExPRyh2b2lkKQogCiAJ
CWVyZXBvcnQoV0FSTklORywKIAkJCQllcnJtc2coImVuYWJsaW5nIGRhdGEgY2hlY2tzdW1zIHdh
cyBpbnRlcnJ1cHRlZCIpLAotCQkJCWVycmhpbnQoIkRhdGEgY2hlY2tzdW0gcHJvY2Vzc2luZyBt
dXN0IGJlIG1hbnVhbGx5IHJlc3RhcnRlZCBmb3IgY2hlY2tzdW1zIHRvIGJlIGVuYWJsZWQiKSk7
CisJCQkJZXJyaGludCgiRGF0YSBjaGVja3N1bSBwcm9jZXNzaW5nIG11c3QgYmUgbWFudWFsbHkg
cmVzdGFydGVkIGZvciBjaGVja3N1bXMgdG8gYmUgZW5hYmxlZC4iKSk7CiAJfQogCiAJLyoKLS0g
CjIuNTAuMSAoQXBwbGUgR2l0LTE1NSkKCg==
--00000000000037c54b06529b4817
Content-Type: application/octet-stream;
	name="0001-Remove-stray-word-in-pg_restore_extended_stats-errhi.patch"
Content-Disposition: attachment;
	filename="0001-Remove-stray-word-in-pg_restore_extended_stats-errhi.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mpklio9n1>
X-Attachment-Id: f_mpklio9n1

RnJvbSA3YjY3MmFlYjczZGE0NzdjZjY2YWFkNzJhNWYxZGQzZWNjNTJmMzU1IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBCYWppIFNoYWlrIDxiYWppLnBnZGV2QGdtYWlsLmNvbT4KRGF0
ZTogRnJpLCAyMiBNYXkgMjAyNiAxMTo0NzozMyAtMDUwMApTdWJqZWN0OiBbUEFUQ0ggMS8yXSBS
ZW1vdmUgc3RyYXkgd29yZCBpbiBwZ19yZXN0b3JlX2V4dGVuZGVkX3N0YXRzKCkgZXJyaGludAoK
VGhlIGVycmhpbnQgbWVzc2FnZSBpbiBpbXBvcnRfcGdfc3RhdGlzdGljKCkgcmVhZHM6CgogICAg
VmFsdWUgb2YgZWxlbWVudCAiJXMiIG11c3QgYmUgdHlwZSBhIG51bGwgb3IgYSBzdHJpbmcuCgpU
aGUgd29yZCAidHlwZSIgaXMgYSBzdHJheSB3b3JkIHRoYXQgZG9lc24ndCBiZWxvbmc7IHRoZSBp
bnRlbnQgaXMKIm11c3QgYmUgYSBudWxsIG9yIGEgc3RyaW5nIi4gIFJld29yZCB0bzoKCiAgICBW
YWx1ZSBvZiBlbGVtZW50ICIlcyIgbXVzdCBiZSBhIG51bGwgb3IgYSBzdHJpbmcuCi0tLQogc3Jj
L2JhY2tlbmQvc3RhdGlzdGljcy9leHRlbmRlZF9zdGF0c19mdW5jcy5jIHwgMiArLQogMSBmaWxl
IGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvc3Jj
L2JhY2tlbmQvc3RhdGlzdGljcy9leHRlbmRlZF9zdGF0c19mdW5jcy5jIGIvc3JjL2JhY2tlbmQv
c3RhdGlzdGljcy9leHRlbmRlZF9zdGF0c19mdW5jcy5jCmluZGV4IGFiNzQ4MDY4MjI1Li40YTY1
YTQ2ZGY0MSAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvc3RhdGlzdGljcy9leHRlbmRlZF9zdGF0
c19mdW5jcy5jCisrKyBiL3NyYy9iYWNrZW5kL3N0YXRpc3RpY3MvZXh0ZW5kZWRfc3RhdHNfZnVu
Y3MuYwpAQCAtMTE2MCw3ICsxMTYwLDcgQEAgaW1wb3J0X3BnX3N0YXRpc3RpYyhSZWxhdGlvbiBw
Z3NkLCBKc29uYkNvbnRhaW5lciAqY29udCwKIAkJCQllcmVwb3J0KFdBUk5JTkcsCiAJCQkJCQll
cnJjb2RlKEVSUkNPREVfSU5WQUxJRF9QQVJBTUVURVJfVkFMVUUpLAogCQkJCQkJZXJybXNnKCJj
b3VsZCBub3QgcGFyc2UgXCIlc1wiOiBpbnZhbGlkIGVsZW1lbnQgaW4gZXhwcmVzc2lvbiAlZCIs
IGFyZ25hbWUsIGV4cHJudW0pLAotCQkJCQkJZXJyaGludCgiVmFsdWUgb2YgZWxlbWVudCBcIiVz
XCIgbXVzdCBiZSB0eXBlIGEgbnVsbCBvciBhIHN0cmluZy4iLCBzKSk7CisJCQkJCQllcnJoaW50
KCJWYWx1ZSBvZiBlbGVtZW50IFwiJXNcIiBtdXN0IGJlIGEgbnVsbCBvciBhIHN0cmluZy4iLCBz
KSk7CiAJCQkJZ290byBwZ19zdGF0aXN0aWNfZXJyb3I7CiAJCX0KIAl9Ci0tIAoyLjUwLjEgKEFw
cGxlIEdpdC0xNTUpCgo=
--00000000000037c54b06529b4817--