public inbox for [email protected]  

help / color / mirror / Atom feed

From: Stéphane Tachoires <[email protected]>
To: Cary Huang <[email protected]>
Cc: [email protected]
Cc: Gilles Darold <[email protected]>
Subject: Re: [Proposal] Allow pg_dump to include all child tables with the root table
Date: Sat, 25 Feb 2023 17:40:17 +0100
Message-ID: <CA+gpmf+ciusFs1Ui8cB13HHfuxvhn5Vg+gV3kzHmka_jvQP96Q@mail.gmail.com> (raw)
In-Reply-To: <167727895770.12579.12160318039902297475.pgcf@coridan.postgresql.org>
References: <[email protected]>
	<167727895770.12579.12160318039902297475.pgcf@coridan.postgresql.org>

Hi,

I'm not sure about the "child" -> "partition" change as it also selects
childs that are not partitions.
I'm more dubious about the --with-childs option, I'd rather have
--table-with-childs=<PATTERN> and --exclude-table-with-childs=<PATTERN>.
That will be clearer about what is what.

I'm working on that, but have a hard time with test pg_dump/002_pg_dump
(It's brand new to me)

Stéphane

Le ven. 24 févr. 2023 à 23:50, Cary Huang <[email protected]> a écrit :

> The following review has been posted through the commitfest application:
> make installcheck-world:  tested, passed
> Implements feature:       tested, passed
> Spec compliant:           not tested
> Documentation:            not tested
>
> Hi
>
> the patch applies fine on current master branch and it works as described.
> However, I would suggest changing the new option name from "--with-childs"
> to "--with-partitions" for several reasons.
>
> "childs" is grammatically incorrect and in the PG community, the term
> "partitioned table" is normally used to denote a parent table, and the term
> "partition" is used to denote the child table under the parent table. We
> should use these terms to stay consistent with the community.
>
> Also, I would rephrase the documentation as:
>
> Used in conjunction with <option>-t</option>/<option>--table</option> or
> <option>-T</option>/<option>--exclude-table</option> options to include or
> exclude partitions of the specified tables if any.
>
> thank you
>
> Cary Huang
> ================
> HighGo Software Canada
> www.highgo.ca



-- 
"Où se posaient les hirondelles avant l'invention du téléphone ?"
  -- Grégoire Lacroix

view thread (6+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [Proposal] Allow pg_dump to include all child tables with the root table
  In-Reply-To: <CA+gpmf+ciusFs1Ui8cB13HHfuxvhn5Vg+gV3kzHmka_jvQP96Q@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox