public inbox for [email protected]
help / color / mirror / Atom feedFrom: Stéphane Tachoires <[email protected]>
To: Alexander Korotkov <[email protected]>
Cc: Dmitry Koval <[email protected]>
Cc: [email protected]
Subject: Re: Add SPLIT PARTITION/MERGE PARTITIONS commands
Date: Wed, 10 Dec 2025 21:04:11 +0100
Message-ID: <CA+gpmfLSELzEKEzSFXeLkRRMGkRfm2+7ewXHyW-8ZWPbWOywyg@mail.gmail.com> (raw)
In-Reply-To: <CAPpHfdtBH5YhAiKhXPcLAE4CCRMaGKqupzx8u2RKEm2aQ_e3Xw@mail.gmail.com>
References: <171085360143.2046436.7217841141682511557.pgcf@coridan.postgresql.org>
<CAPpHfdsh_jPZ6-2JtWoFeZravVQYY4cYCcnKXQW6KxEx+F5vxg@mail.gmail.com>
<[email protected]>
<CACJufxF1Hfx1PST7pCLrKkGcjHEn2A51znXmYwVccnt5GDORcw@mail.gmail.com>
<[email protected]>
<[email protected]>
<[email protected]>
<CACJufxET9Qe-=zJtjGrKPr7-1QbVcP9y-vJU9CMEDfPGt_dbyg@mail.gmail.com>
<[email protected]>
<CACJufxEBvrtcOWyX2NMwOCvb2ZvaRGaGeiMQpUD=yxL6ncBFOg@mail.gmail.com>
<[email protected]>
<CAPpHfdvSBR+sbsRCAybN949tOGArQvMH2QeDXf2L=7NDMNbJfw@mail.gmail.com>
<[email protected]>
<CAPpHfduQwwa4ytK-dGjRGN0fTWfpWNNysYuUKrOetsyGioBMfA@mail.gmail.com>
<[email protected]>
<CAPpHfdvpzezTnuumpdJYge=x1TbhgAkjMGh2GHnScf5SFsf2ew@mail.gmail.com>
<[email protected]>
<CAPpHfdtBH5YhAiKhXPcLAE4CCRMaGKqupzx8u2RKEm2aQ_e3Xw@mail.gmail.com>
Hi,
Patches don't apply anymore.
Could you rebase it please ?
Thank you so much to all of you for your persistence.
Stéphane.
Back.
Le mer. 10 déc. 2025 à 00:54, Alexander Korotkov
<[email protected]> a écrit :
>
> On Wed, Dec 10, 2025 at 1:22 AM Dmitry Koval <[email protected]> wrote:
> > Thank you for your corrections!
> > Two questions:
> > ----
> >
> > 1) "v65-0001-Implement-ALTER-TABLE-.-MERGE-PARTITIONS-.-comma.patch"
> > patch, "src/backend/partitioning/partbounds.c" file,
> > "check_two_partitions_bounds_range" function.
> >
> > Old comment (v64)
> >
> > + /*
> > + * lower1=false (the second to last argument) for correct comparison of
> > + * lower and upper bounds.
> > + */
> >
> > was changed to (v65)
> >
> > + /*
> > + * cmpval == false for the correct comparison result of the lower and
> > + * upper bounds.
> > + */
> >
> > Maybe it's better to keep the old comment (or keep its meaning)?
> > ----
> >
> > 2) "v65-0002-Implement-ALTER-TABLE-.-SPLIT-PARTITION-.-comman.patch"
> > patch, "src/backend/parser/parse_utilcmd.c" file, "checkPartition" function.
> >
> > The third argument of function was changed from "is_merge" (v64) to
> > "isMerge" (v65). Maybe the function description should be changed in
> > the same way?
> >
> > + * is_merge: true indicates the operation is "ALTER TABLE ... MERGE
> > PARTITIONS";
>
> Thank you for catching this. Both accepted.
>
> ------
> Regards,
> Alexander Korotkov
> Supabase
view thread (165+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: Add SPLIT PARTITION/MERGE PARTITIONS commands
In-Reply-To: <CA+gpmfLSELzEKEzSFXeLkRRMGkRfm2+7ewXHyW-8ZWPbWOywyg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox