MIME-Version: 1.0
References: <t2vjrcb3bloxf5qqvxjst6r7lvrefqyecxgt2koy5ho5b5glr2@yuupmm6whgob> <e8e646f5-8ffc-4639-b897-a9ecdccd34c3@eisentraut.org>
In-Reply-To: <e8e646f5-8ffc-4639-b897-a9ecdccd34c3@eisentraut.org>
From: Thomas Munro <thomas.munro@gmail.com>
Date: Thu, 28 Nov 2024 18:09:46 +1300
Message-ID: <CA+hUKG+EpYkmANS3BeWacMD39k9MjGEo73qJvZfpSA7ggrADgw@mail.gmail.com>
Subject: Re: CI CompilerWarnings test fails on 15 in mingw_cross_warning
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Andres Freund <andres@anarazel.de>, pgsql-hackers@postgresql.org
Content-Type: multipart/mixed; boundary="0000000000007d0c480627f219fb"
Archived-At: <https://www.postgresql.org/message-id/CA%2BhUKG%2BEpYkmANS3BeWacMD39k9MjGEo73qJvZfpSA7ggrADgw%40mail.gmail.com>
Precedence: bulk

--0000000000007d0c480627f219fb
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Nov 19, 2024 at 12:09=E2=80=AFAM Peter Eisentraut <peter@eisentraut=
.org> wrote:
> The more interesting patch is 495ed0ef2d7, which did
>
> -       collversion =3D psprintf("%d.%d,%d.%d",
> +       collversion =3D psprintf("%ld.%ld,%ld.%ld",

This platform has sizeof(int) =3D=3D sizeof(long), so it doesn't matter.

> whereas my patch just did
>
> -       collversion =3D psprintf("%ld.%ld,%ld.%ld",
> +       collversion =3D psprintf("%lu.%lu,%lu.%lu",

I was worried the numbers might have been negative, but those
expressions don't appear to allow that.  Strings observed in real life
are like "1539.5,1539.5" (which bears a passing resemblance to an ICU
version, it has a few fairly low-valued human-originated numbers like
a Unicode version swizzled around in a fairly small number of bits,
but it doesn't matter too match how it works, it's enough to see that
we shift down and mask).

So I think it's OK to back-patch that change.  See attached.

As for why now, I think both fairywren and CI started warning/failing
about 2 months ago[1][2], and that's when fairywren got a uname -r
upgrade, so I guess msys was upgraded; as for CI I guess you'd have to
check for the relevant ming-cross packages moving in Debian.
Unfortunately there were a lot of random CI failures around that time
and I didn't notice this particular circus at the time.

[1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dfairywren&dt=
=3D2024-10-02%2003%3A57%3A44
[2] https://github.com/postgres/postgres/runs/30890390821

--0000000000007d0c480627f219fb
Content-Type: text/x-patch; charset="US-ASCII"; 
	name="0001-Fix-MinGW-d-vs-lu-warnings-in-back-branches.patch"
Content-Disposition: attachment; 
	filename="0001-Fix-MinGW-d-vs-lu-warnings-in-back-branches.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_m40ut81y0>
X-Attachment-Id: f_m40ut81y0

RnJvbSBkY2UxMDlmY2QwZGEzYzEzNzljZDY0Mzg5ZDAzZmRlZjE4YjUyYjU0IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBUaG9tYXMgTXVucm8gPHRob21hcy5tdW5yb0BnbWFpbC5jb20+
CkRhdGU6IFRodSwgMjggTm92IDIwMjQgMTY6Mzg6MDMgKzEzMDAKU3ViamVjdDogW1BBVENIXSBG
aXggTWluR1cgJWQgdnMgJWx1IHdhcm5pbmdzIGluIGJhY2sgYnJhbmNoZXMuCgpDb21taXQgMzUy
ZjZmMmQgdXNlZCAlZCB0byBmb3JtYXQgRFdPUkQgdmFsdWVzICh1bnNpZ25lZCBsb25nKSB3aXRo
CnBzcHJpbnRmKCkuICBJdCBoYXMgZm9ybWF0LXN0cmluZyBjaGVja2luZyB1bmRlciBnY2MsIGFu
ZCBnY2MgZG9lc24ndApsaWtlIGl0LiAgSXQgc2VlbXMgdGhhdCBNaW5HVyBoYXMgc3RhcnRlZCBj
b21waWxpbmcgdGhpcyBjb2RlIGluIHJlY2VudAp2ZXJzaW9ucywgcGVyaGFwcyBkdWUgdG8gYSBf
V0lOTlQgdmFsdWUgY2hhbmdlLCBzbyBub3cgd2Ugc2VlIHRoZQp3YXJuaW5ncy4KCkNvbW1pdHMg
NDk1ZWQwZWYgYW5kIGE5YmMwNGIyIGFscmVhZHkgY2hhbmdlZCBpdCB0byAlbHUgaW4gMTYrLiAg
SW4KMTMtMTUsIGJ1aWxkIGZhcm0gYW5pbWFsIGZhaXJ5d3JlbiBiZWdhbiB3YXJuaW5nIGEgY291
cGxlIG9mIG1vbnRocyBhZ28sCmFuZCBpbiAxNSAodGhlIGZpcnN0IGJyYW5jaCB3aXRoIENJKSB0
aGUgQ29tcGlsZXJXYXJuaW5ncwptaW5nd19jcm9zc193YXJuaW5nIHN0ZXAgYmVnYW4gZmFpbGlu
ZyBhcm91bmQgdGhlIHNhbWUgdGltZS4KClRoaXMgZml4ZXMgdGhlIHdhcm5pbmcgd2l0aG91dCBh
bnkgY2hhbmdlIGluIGJlaGF2aW9yLCBiZWNhdXNlCnNpemVvZihpbnQpID09IHNpemVvZihsb25n
KSBvbiB0aGlzIHBsYXRmb3JtIGFuZCB0aGUgdmFsdWVzIGFyZSBjb21wdXRlZAp3aXRoIERXT1JE
IGV4cHJlc3Npb25zIHRoYXQgY2Fubm90IGV4Y2VlZCBJTlRfTUFYIG9yIExPTkdfTUFYLgoKQmFj
ay1wYXRjaCB0aGUgZm9ybWF0dGluZyBjaGFuZ2UgZnJvbSB0aG9zZSBjb21taXRzIGludG8gMTMt
MTUuCgpSZXBvcnRlZC1ieTogQW5kcmVzIEZyZXVuZCA8YW5kcmVzQGFuYXJhemVsLmRlPgpSZXZp
ZXdlZC1ieToKRGlzY3Vzc2lvbjogaHR0cHM6Ly9wb3N0Z3IuZXMvbS90MnZqcmNiM2Jsb3hmNXFx
dnhqc3Q2cjdsdnJlZnF5ZWN4Z3Qya295NWhvNWI1Z2xyMiU0MHl1dXBtbTZ3aGdvYgotLS0KIHNy
Yy9iYWNrZW5kL3V0aWxzL2FkdC9wZ19sb2NhbGUuYyB8IDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAx
IGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3V0
aWxzL2FkdC9wZ19sb2NhbGUuYyBiL3NyYy9iYWNrZW5kL3V0aWxzL2FkdC9wZ19sb2NhbGUuYwpp
bmRleCA4Zjg0MWMxZDE5Mi4uMzY0NmM5Nzk0OTggMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL3V0
aWxzL2FkdC9wZ19sb2NhbGUuYworKysgYi9zcmMvYmFja2VuZC91dGlscy9hZHQvcGdfbG9jYWxl
LmMKQEAgLTE3NjAsNyArMTc2MCw3IEBAIGdldF9jb2xsYXRpb25fYWN0dWFsX3ZlcnNpb24oY2hh
ciBjb2xscHJvdmlkZXIsIGNvbnN0IGNoYXIgKmNvbGxjb2xsYXRlKQogCQkJCQkJCWNvbGxjb2xs
YXRlLAogCQkJCQkJCUdldExhc3RFcnJvcigpKSkpOwogCQl9Ci0JCWNvbGx2ZXJzaW9uID0gcHNw
cmludGYoIiVkLiVkLCVkLiVkIiwKKwkJY29sbHZlcnNpb24gPSBwc3ByaW50ZigiJWx1LiVsdSwl
bHUuJWx1IiwKIAkJCQkJCQkgICAodmVyc2lvbi5kd05MU1ZlcnNpb24gPj4gOCkgJiAweEZGRkYs
CiAJCQkJCQkJICAgdmVyc2lvbi5kd05MU1ZlcnNpb24gJiAweEZGLAogCQkJCQkJCSAgICh2ZXJz
aW9uLmR3RGVmaW5lZFZlcnNpb24gPj4gOCkgJiAweEZGRkYsCi0tIAoyLjQ3LjAKCg==
--0000000000007d0c480627f219fb--