Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1p4tyE-0001Js-CA
	for pgsql-hackers@arkaria.postgresql.org; Tue, 13 Dec 2022 01:20:34 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1p4txE-0006Di-Ti
	for pgsql-hackers@arkaria.postgresql.org; Tue, 13 Dec 2022 01:19:32 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <thomas.munro@gmail.com>)
	id 1p4txE-0006DY-Ic
	for pgsql-hackers@lists.postgresql.org; Tue, 13 Dec 2022 01:19:32 +0000
Received: from mail-ua1-x92d.google.com ([2607:f8b0:4864:20::92d])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128)
	(Exim 4.92)
	(envelope-from <thomas.munro@gmail.com>)
	id 1p4tx7-0002tH-Tk
	for pgsql-hackers@postgresql.org; Tue, 13 Dec 2022 01:19:31 +0000
Received: by mail-ua1-x92d.google.com with SMTP id v21so3685232uam.1
        for <pgsql-hackers@postgresql.org>;
 Mon, 12 Dec 2022 17:19:25 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=VtkEf83zaOz1TYmCuWrCdTfXFQ02erdurTpIndu1dP4=;
        b=mSqYJtYBWHO9A7432YCUSexYE9xiNM+NkRtguIpX/HKWqz38PlXNMnLK9pX2uwQ9cA
         FGlyZEH9yAAQ1ftEXyLjSYOlJwLg/SCDEwOA7rz4p1labHeZwphjjSy2C3950OiGlqhL
         7eXRUf7Fod1PXNdSBPIkcswSOYY4N+ojkX8NYqtcu2zlaD2s5SoYucoXKexDSvoU5cb9
         WzSluXCEXsVs61EcuRfwFeGoTosXJTc0E2oFbWCrpA2kgHZyvgtjfjNCi36qHXm9dMuX
         8mOXXi47YWkB4ptfgV1Q5WCGRF+MjfOEvXjFngZrCv6wONVVWekI3qi7HuR9zkaVXADc
         9BRQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=VtkEf83zaOz1TYmCuWrCdTfXFQ02erdurTpIndu1dP4=;
        b=apStMXdSZJqHROBzKfXjqI8lcSvzKaa/lywkMNoqfokC2MFgcaCBZUb/6Kl1D87aT9
         kVjGG6R6wmD7O4vE7/w3XALfmbmLGC1eR0yfjy8G2sKE7pQFX7WBGhzYdrSBz5uBF0z3
         qdOOHVW9i/7gZMJSqpYqdSgGae+bRlkGCg7eC39DnerBu7SHItEdhjPv0nIozBXTlrGF
         jxwxkb3kwa/1FKZNgvdvzrRB924Jfjf8Y6We+a+1UXAazr/mQzDGbAgyeR2gtrOAC1Yk
         YYyfnfaD0X8Gmu0/SXUVRiiO9mGHh5pICuBlGnNYNkMn2OueFPmpNdQGGtHO/vpF8hMt
         uq5g==
X-Gm-Message-State: ANoB5pkJubfzdL3DqVVl/dcvRaS0AQf71L7rga0WzEUnOqVlXWVSGMFM
	lNCVrjuh7hIzs7/msap8otAPkbzki0VR3fk8hPAFuV2vZYc=
X-Google-Smtp-Source: 
 AA0mqf5+uOdygowXS19a23IQk6R8GXr3ZXTmJVOZiNtiXgKmfkMOvOatARrQhpn8N3i7M0NSTY0MRmFitre9Z7xe944=
X-Received: by 2002:ab0:6cb1:0:b0:419:2452:150b with SMTP id
 j17-20020ab06cb1000000b004192452150bmr30526758uaa.20.1670894364853; Mon, 12
 Dec 2022 17:19:24 -0800 (PST)
MIME-Version: 1.0
References: 
 <CA+hUKGKpHPDTv67Y+s6yiC8KH5OXeDg6a-twWo_xznKTcG0kSA@mail.gmail.com>
 <1725174.1651449765@sss.pgh.pa.us> <3953550.1663376882@sss.pgh.pa.us>
 <208054.1663534665@sss.pgh.pa.us>
 <CA+hUKGK=xCw9_V7tCMvpT5D83AH8ArotTw3W4s70Vhqr7VgZkg@mail.gmail.com>
 <CA+hUKG+FVo16ReJa5qWU84h4wpN7w32FG1PUWDcsgQviL-2QEA@mail.gmail.com>
 <334554.1663596005@sss.pgh.pa.us> <508012.1663611012@sss.pgh.pa.us>
 <722832.1663690513@sss.pgh.pa.us>
 <CA+hUKGJvX+L3aMN84ksT-cGy08VHErRNip3nV-WmTx7f6Pqhyw@mail.gmail.com>
 <1914802.1670814425@sss.pgh.pa.us>
 <CA+hUKGKtrz0S1NjAf=e76ZyvPi+JNvtJptgEdFFdtK7r4b2jnA@mail.gmail.com>
In-Reply-To: 
 <CA+hUKGKtrz0S1NjAf=e76ZyvPi+JNvtJptgEdFFdtK7r4b2jnA@mail.gmail.com>
From: Thomas Munro <thomas.munro@gmail.com>
Date: Tue, 13 Dec 2022 14:18:48 +1300
Message-ID: 
 <CA+hUKG+F_5qqne+z+dirf5N3hinFsf=7=EygwEynpwq09OcEzQ@mail.gmail.com>
Subject: Re: Tree-walker callbacks vs -Wdeprecated-non-prototype
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2BhUKG%2BF_5qqne%2Bz%2Bdirf5N3hinFsf%3D7%3DEygwEynpwq09OcEzQ%40mail.gmail.com>
Precedence: bulk

On Mon, Dec 12, 2022 at 4:43 PM Thomas Munro <thomas.munro@gmail.com> wrote:
> On Mon, Dec 12, 2022 at 4:07 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > I'm for "turn the warning off".  Per previous discussion, adhering
> > strictly to that rule would make our code worse (less legible AND
> > less safe), not better.
>
> Alright, this seems to do the trick here.

That did fix that problem.  But... seawasp also just recompiled its
compiler and picked up new opaque pointer API changes.  So no green
today.  I have more work to do to fix that, which might take some time
to get back to.