public inbox for [email protected]
help / color / mirror / Atom feedFrom: Thomas Munro <[email protected]>
To: Tom Lane <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: Noah Misch <[email protected]>
Cc: Jeff Davis <[email protected]>
Cc: Postgres hackers <[email protected]>
Subject: Re: pgsql: Add contrib/pg_walinspect.
Date: Wed, 27 Apr 2022 14:10:49 +1200
Message-ID: <CA+hUKGJAULJ_NtszwEdnSgrpRiQiRjsf62DG9_1B9x0Vzoex5g@mail.gmail.com> (raw)
In-Reply-To: <CA+hUKG+By4isKdbDkCaLkPq4V4ECWW=d+RhcLjQXTQ3KAJLobg@mail.gmail.com>
References: <[email protected]>
<Ymd/[email protected]>
<[email protected]>
<YmeExX6ACB/[email protected]>
<CA+hUKGLtswFk9ZO3WMOqnDkGs6dK5kCdQK9gxJm0N8gip5cpiA@mail.gmail.com>
<[email protected]>
<CA+hUKG+H_VEBdtK4CVb7uRLaAKbufNOMy-djUsptcqhLxONMmA@mail.gmail.com>
<[email protected]>
<CA+hUKG+By4isKdbDkCaLkPq4V4ECWW=d+RhcLjQXTQ3KAJLobg@mail.gmail.com>
On Wed, Apr 27, 2022 at 1:54 PM Thomas Munro <[email protected]> wrote:
> On Wed, Apr 27, 2022 at 1:47 PM Tom Lane <[email protected]> wrote:
> > Thomas Munro <[email protected]> writes:
> > > Hrmph... Are you sure you rebuilt the contrib module? Assuming so,
> > > maybe it's failing in a different way for you and me. For me, it
> > > always fails after this break is reached in xlogutil.c:
> >
> > > /* If asked, let's not wait for future WAL. */
> > > if (!wait_for_wal)
> > > break;
> >
> > Hmm. For me, that statement is not reached at all in successful
> > (make installcheck) runs. In a failing run, it's reached with
> > wait_for_wal = false, after which we get the "could not read WAL"
> > failure. Usually that happens twice, as per attached.
>
> Ok, that's the same for me. Next question: why does the patch I
> posted not help? For me, the error "could not read WAL at %X/%X",
> seen on the BF log, is raised by ReadNextXLogRecord() in
> pg_walinspect.c. The patch removes that ereport() entirely (and
> handles NULL in a couple of places).
BTW If you had your local change from debug.patch (upthread), that'd
defeat the patch. I mean this:
+ if(!*errormsg)
+ *errormsg = "decode_queue_head is null";
view thread (3+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: pgsql: Add contrib/pg_walinspect.
In-Reply-To: <CA+hUKGJAULJ_NtszwEdnSgrpRiQiRjsf62DG9_1B9x0Vzoex5g@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox