Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p4Ypz-000417-EW for pgsql-hackers@arkaria.postgresql.org; Mon, 12 Dec 2022 02:46:39 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1p4Ypx-0000xV-I8 for pgsql-hackers@arkaria.postgresql.org; Mon, 12 Dec 2022 02:46:37 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p4Ypx-0000xK-7W for pgsql-hackers@lists.postgresql.org; Mon, 12 Dec 2022 02:46:37 +0000 Received: from mail-vs1-xe2b.google.com ([2607:f8b0:4864:20::e2b]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1p4Ypp-00013w-N1 for pgsql-hackers@postgresql.org; Mon, 12 Dec 2022 02:46:36 +0000 Received: by mail-vs1-xe2b.google.com with SMTP id 3so9911562vsq.7 for ; Sun, 11 Dec 2022 18:46:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=UhXA8bXAf9pdhoayabOVJDulXIPNP7pS4iE3txpTB8g=; b=VRsSa3AWkv1/0WNLsaB76HC6pDhd7l1rbGUBgPEB0viiFbtsseI6hdLNL4Re6e240h TLQQReCPULt30webHQdm5WDpXWQwwvEfB5PzA+ixKOO/kUWNF265u2tryhAD6FzicXuy R2KptWsV3hx8fxUKqHfbFmVVEB4zHYBBclu/ZYbZZopT5oXeppRIupSXHsRw6wsg7yUf ete6Hd/+ieUyiXVDWXMlWm3t0w6qPfbrB8doE4Mygev5dQioD8fjOpiqMYRRcGWY1SMQ WL/36M6+CSR3Q2VZlKQSmTzWrK5pVFQfhUYk8EvQecut1lpf74F/HVcx2+DQcY7rplaW 06pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UhXA8bXAf9pdhoayabOVJDulXIPNP7pS4iE3txpTB8g=; b=A0V9DTR0U+XH/GUM1GmUMwwQ1X476paOoWR/LutLMEnLdQtGB8tSmQa723fOYVhE1k 8tlNTWREe7a6fxWEbZv8opNPqOtQoR8lx/WyPAlNKRsNCbfiwQhbbhJEGQVVLwZSyRmN rjAnskmLHAM1H8aUbpi89Dx+Mk80BdOLCGfymyLPIoi9YqhnhQ7HII7QGanLjr6ac6yv suAwGa5YjcpHe34oRqWzShRD0lj81xZ9Jy3hqBEBfTkb03ZNy+uftsjXsp04eqvEbyCy 0eyecnqpyjur+/IKqVUudW/Hw1bcNKn4y2gxM28T45ENODiTrXOayKhR0p+Aa8Oqyiwe j+3A== X-Gm-Message-State: ANoB5plnRxXE1fuxhcn8CPOc3t/lpUqFCgWbOVctesMRRX+tsL4YMBXe jxnb1wwcCNFws2N8JlEP7GV2oqufqMT4WSKnxmI= X-Google-Smtp-Source: AA0mqf4k+3jQAH93qNAbjZzk4xpMDg44PMr3vtrG4FkgXTVutfU9FwsnUIQEMh0x5XSO7s/DNra1JWXPd4CMiDGJCP4= X-Received: by 2002:a05:6102:2141:b0:3b0:f1d3:e49e with SMTP id h1-20020a056102214100b003b0f1d3e49emr17329734vsg.6.1670813188084; Sun, 11 Dec 2022 18:46:28 -0800 (PST) MIME-Version: 1.0 References: <1725174.1651449765@sss.pgh.pa.us> <3953550.1663376882@sss.pgh.pa.us> <208054.1663534665@sss.pgh.pa.us> <334554.1663596005@sss.pgh.pa.us> <508012.1663611012@sss.pgh.pa.us> <722832.1663690513@sss.pgh.pa.us> In-Reply-To: <722832.1663690513@sss.pgh.pa.us> From: Thomas Munro Date: Mon, 12 Dec 2022 15:45:51 +1300 Message-ID: Subject: Re: Tree-walker callbacks vs -Wdeprecated-non-prototype To: Tom Lane Cc: pgsql-hackers Content-Type: text/plain; charset="UTF-8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk As visible on seawasp and locally (16/main branch nightly packages), they decided to start warning about these casts with a new strict variant of the warning. Their discussion: https://reviews.llvm.org/D134831 There are also a few other cases unrelated to this thread's original problem, for example casts involving pg_funcptr_t, HashCompareFunc. I guess our options would be to turn that warning off, or reconsider and try shoving the cast of "generic" arguments pointers down into the functions?