Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pPeXm-0005NO-CJ for pgsql-hackers@arkaria.postgresql.org; Wed, 08 Feb 2023 07:07:02 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pPeXk-0000Y8-Ng for pgsql-hackers@arkaria.postgresql.org; Wed, 08 Feb 2023 07:07:00 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pPeXk-0000Xq-EZ for pgsql-hackers@lists.postgresql.org; Wed, 08 Feb 2023 07:07:00 +0000 Received: from mail-ej1-x632.google.com ([2a00:1450:4864:20::632]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pPeXh-0002ol-8W for pgsql-hackers@lists.postgresql.org; Wed, 08 Feb 2023 07:06:59 +0000 Received: by mail-ej1-x632.google.com with SMTP id gr7so48846594ejb.5 for ; Tue, 07 Feb 2023 23:06:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=fZaq70SBvSLykOUYRRWLcFJqVOZTh1UVyQh6sbilsJI=; b=JjpEXKSclwd50vnHwNiYWQgPZexAJOfXxdyG/0AS/SkIbi3udPzmKa8EWmsBoN1D/Z yrPFtkFGybWvrdLjx+pmqRS+Do8JX+0R9bv/0OP4a9p6xqmkAo+oW7DaDp7jilnwnLiZ p9Nvub1G6vcj7SSKxOPtZFppi+uXzZ34hTSXUzC6UhebjR1e6F1TEjhg2MpJRsibmD2z uy0ivwHpRg0PeX198tmZvmwhBCMgw8Odx5z0VtM38TIKe/MkDffqZ/85qPtQ8N4/2qno FaOCm6xvbmUKgeEtV9hRrmv+X/ZMrpkuXqgW2xnM34m7FrwCBHYNWO86hk6BBPNQM6z0 9rXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fZaq70SBvSLykOUYRRWLcFJqVOZTh1UVyQh6sbilsJI=; b=zc2ubtjDMFrPrCFNg8BYIcXwdM9FvujagFnsnhmCnD5rug8dFsZJqSDq9nIhnhviWF nwkPzNge/1WSUOey9aD5O5x4MkbjdRQRTC4JVaHUw+rUdxbDSo8cbmtnglsnGlvQTRXg VR3ivdOudcbiu7BVGRr8N354eI9/vTJPiS9hom24swUvLhstXyVTV35Ck40jBn/X3u/v lKhIk85T2Jik/wVQdosDpNpn6vd2nrNktfD9pdzyRheM15aeOGAZ6R4otsEyTEsx5Gy8 NUxRTT0kGrT3PstFEp74cwFlk5CC+JpNfqJB7E5J6JQHtSgfxdbOcD9QhzU8wm3oVcYu BHrg== X-Gm-Message-State: AO0yUKXFHwuByaHwvXdjVw9XHz7kOCrEjVxO1A+vKh3sDufwcyIgzXjE FUHFM4VFh7kOiy5G/zNLuZjzXfsDR2CB2NosYQA= X-Google-Smtp-Source: AK7set+GmRMShU9chEMTeqQX/xOowZ2G8K5vhmtov1rjhRJerCFI34J0bDIDP2bzZ6BExnDf0mUWQfOKlUy8YPBiEt0= X-Received: by 2002:a17:906:7f8c:b0:88d:3f80:d57d with SMTP id f12-20020a1709067f8c00b0088d3f80d57dmr1137794ejr.302.1675840015729; Tue, 07 Feb 2023 23:06:55 -0800 (PST) MIME-Version: 1.0 References: <20221021034040.GT16921@telsasoft.com> <20221109010437.GK3775@telsasoft.com> <20230103142537.GM1153@telsasoft.com> <20230112043949.GQ9837@telsasoft.com> <20230113024354.3q4aigbf4fyh2igg@awork3.anarazel.de> <20230113041755.GV9837@telsasoft.com> In-Reply-To: <20230113041755.GV9837@telsasoft.com> From: Thomas Munro Date: Wed, 8 Feb 2023 20:06:17 +1300 Message-ID: Subject: Re: Cygwin cleanup To: Justin Pryzby Cc: Andres Freund , vignesh C , pgsql-hackers@lists.postgresql.org, Andrew Dunstan , Tom Lane Content-Type: text/plain; charset="UTF-8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Fri, Jan 13, 2023 at 5:17 PM Justin Pryzby wrote: > My patch used fsync_fname_ext() which would cause an ERROR rather than a > PANIC when failing to fsync the logical decoding pathname. FTR While analysing a lot of CI logs trying to debug something else I came across a plain Windows/MSVC (not Cygwin) build that panicked like this: https://cirrus-ci.com/task/6689224833892352 https://api.cirrus-ci.com/v1/artifact/task/6689224833892352/testrun/build/testrun/subscription/013_partition/log/013_partition_publisher.log https://api.cirrus-ci.com/v1/artifact/task/6689224833892352/crashlog/crashlog-postgres.exe_0af4_2023-02-05_21-53-20-018.txt