MIME-Version: 1.0
From: Thomas Munro <thomas.munro@gmail.com>
Date: Thu, 9 Apr 2026 15:34:30 +1200
Message-ID: 
 <CA+hUKGK2zuRevnNzCpVzLA7ieHnJoYPnDvgtWRcB4pVnOzchhQ@mail.gmail.com>
Subject: [[deprecated("don't call this, call that")]]
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000f785bb064efeb3b3"
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2BhUKGK2zuRevnNzCpVzLA7ieHnJoYPnDvgtWRcB4pVnOzchhQ%40mail.gmail.com>
Precedence: bulk

--000000000000f785bb064efeb3b3
Content-Type: text/plain; charset="UTF-8"

Hi,

While working on 1e7fe06c, I wished I could make functions generate
compiler warnings:

pg_attribute_deprecated("use pg_mblen_{cstr,range,with_len,unbounded} instead")
extern int     pg_mblen(const char *mbstr);

That'd avoid accidental reintroduction, and also get extension
maintainers' attention. $SUBJECT is C23/C++14's syntax, but you've
long been able to do that with in __attribute__ or __declspec for the
usual suspects so I looked into which compiler versions introduced
that and came up with the attached.

The idea would be to back-patch the deprecation warnings, and delete
the functions in, I guess now, v20.  Then the deprecation notice
facility would always be there for next time we need it.

--000000000000f785bb064efeb3b3
Content-Type: text/x-patch; charset="US-ASCII";
	name="0001-Provide-pg_attribute_deprecated-message-macro.patch"
Content-Disposition: attachment;
	filename="0001-Provide-pg_attribute_deprecated-message-macro.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mnqwov4g0>
X-Attachment-Id: f_mnqwov4g0

RnJvbSBiNzgwYmE0NWJiYjM2NjQwNmNkMmZmNDJkYjNjNjkwNzBjYTJiMjJlIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBUaG9tYXMgTXVucm8gPHRob21hcy5tdW5yb0BnbWFpbC5jb20+
CkRhdGU6IFdlZCwgMSBBcHIgMjAyNiAyMjoyMDo1NSArMTMwMApTdWJqZWN0OiBbUEFUQ0ggMS8z
XSBQcm92aWRlIHBnX2F0dHJpYnV0ZV9kZXByZWNhdGVkKCJtZXNzYWdlIikgbWFjcm8uCgpUaGlz
IGV4cGFuZHMgdG8gQzIzL0MrKzE0IFtbZGVwcmVjYXRlZCgibWVzc2FnZSIpXV0sIG9yIGVxdWl2
YWxlbnQKYXR0cmlidXRlcyBhdmFpbGFibGUgc2luY2UgR0NDIDQuOSwgQ2xhbmcgMi45IGFuZCBN
U1ZDIDIwMDggKGFuZCBmdXJ0aGVyCmJhY2sgd2l0aG91dCBhIG1lc3NhZ2UpLiAgSXQgY2FuIGJl
IHBsYWNlZCBiZWZvcmUgYSB0eXBlIG9yIGZ1bmN0aW9uCmRlY2xhcmF0aW9uIHRvIHRyaWdnZXIg
Y29tcGlsZXIgd2FybmluZ3Mgd2hlbiB1c2VkLgoKQmFja3BhdGNoLXRocm91Z2g6IDE0Ci0tLQog
c3JjL2luY2x1ZGUvYy5oIHwgMTUgKysrKysrKysrKysrKysrCiAxIGZpbGUgY2hhbmdlZCwgMTUg
aW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL3NyYy9pbmNsdWRlL2MuaCBiL3NyYy9pbmNsdWRl
L2MuaAppbmRleCA4OGQxM2VjOTk5My4uNjdhNzU5YjFiZjMgMTAwNjQ0Ci0tLSBhL3NyYy9pbmNs
dWRlL2MuaAorKysgYi9zcmMvaW5jbHVkZS9jLmgKQEAgLTIzOCw2ICsyMzgsMjEgQEAgZXh0ZXJu
ICJDKysiCiAjZGVmaW5lIHBnX2F0dHJpYnV0ZV90YXJnZXQoLi4uKQogI2VuZGlmCiAKKy8qCisg
KiBTdXBwb3J0IGZvciBtYXJraW5nIGZ1bmN0aW9ucyBhbmQgdHlwZXMgYXMgZGVwcmVjYXRlZCwg
d2l0aCBhIGNvbXBpbGVyCisgKiB3YXJuaW5nIGlmIHRoZSBmdW5jdGlvbiBpcyB1c2VkLiAgUHJl
Y2VkZXMgYSBkZWNsYXJhdGlvbi4KKyAqLworI2lmIChkZWZpbmVkKF9fU1REQ19WRVJTSU9OX18p
ICYmIF9fU1REQ19WRVJTSU9OX18gPj0gMjAyMzExTCkgfHwgXAorCShkZWZpbmVkKF9fY3BsdXNw
bHVzKSAmJiBfX2NwbHVzcGx1cyA+PSAyMDE0MDJMKQorI2RlZmluZSBwZ19hdHRyaWJ1dGVfZGVw
cmVjYXRlZChtZXNzYWdlKSBbW2RlcHJlY2F0ZWQobWVzc2FnZSldXQorI2VsaWYgZGVmaW5lZChf
X2NsYW5nX18pIHx8IChkZWZpbmVkKF9fR05VQ19fKSAmJiBfX0dOVUNfXyA+PSA1KQorI2RlZmlu
ZSBwZ19hdHRyaWJ1dGVfZGVwcmVjYXRlZChtZXNzYWdlKSBfX2F0dHJpYnV0ZV9fKChkZXByZWNh
dGVkKG1lc3NhZ2UpKSkKKyNlbGlmIGRlZmluZWQoX01TQ19WRVIpCisjZGVmaW5lIHBnX2F0dHJp
YnV0ZV9kZXByZWNhdGVkKG1lc3NhZ2UpIF9fZGVjbHNwZWMoZGVwcmVjYXRlZChtZXNzYWdlKSkK
KyNlbHNlCisjZGVmaW5lIHBnX2F0dHJpYnV0ZV9kZXByZWNhdGVkKG1lc3NhZ2UpCisjZW5kaWYK
KwogLyoKICAqIEFwcGVuZCBQR19VU0VEX0ZPUl9BU1NFUlRTX09OTFkgdG8gZGVmaW5pdGlvbnMg
b2YgdmFyaWFibGVzIHRoYXQgYXJlIG9ubHkKICAqIHVzZWQgaW4gYXNzZXJ0LWVuYWJsZWQgYnVp
bGRzLCB0byBhdm9pZCBjb21waWxlciB3YXJuaW5ncyBhYm91dCB1bnVzZWQKLS0gCjIuNTMuMAoK
--000000000000f785bb064efeb3b3
Content-Type: text/x-patch; charset="US-ASCII";
	name="0002-Mark-pg_mblen-and-t_is-as-deprecated.patch"
Content-Disposition: attachment;
	filename="0002-Mark-pg_mblen-and-t_is-as-deprecated.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mnqwoxjv1>
X-Attachment-Id: f_mnqwoxjv1

RnJvbSA1N2JhZGIyYzliMzM2M2FjMmYxMGRkNGRmMjIyYjJiYjZjNDA1ZTgyIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBUaG9tYXMgTXVucm8gPHRob21hcy5tdW5yb0BnbWFpbC5jb20+
CkRhdGU6IFdlZCwgMSBBcHIgMjAyNiAyMjoyODoyNSArMTMwMApTdWJqZWN0OiBbUEFUQ0ggMi8z
XSBNYXJrIHBnX21ibGVuKCkgYW5kIHRfaXMqKCkgYXMgZGVwcmVjYXRlZC4KClRoZXNlIGZ1bmN0
aW9ucyB3ZXJlIGRlcHJlY2F0ZWQgYnkgY29tbWl0IDFlN2ZlMDZjIGFuZCBzaG91bGRuJ3QgYmUg
dXNlZAppbiBuZXcgY29kZS4gIEFkZGluZyBhIGRlcHJlY2F0ZWQgYXR0cmlidXRlIHdpbGwgY2F1
c2Ugd2FybmluZ3MgaW4KZXh0ZW5zaW9uIGNvZGUgdGhhdCBpcyB1c2luZyB0aGVtLgoKQmFja3Bh
dGNoLXRocm91Z2g6IDE0ClJldmlld2VkLWJ5OgpEaXNjdXNzaW9uOgotLS0KIHNyYy9pbmNsdWRl
L21iL3BnX3djaGFyLmggICAgICAgfCAyICstCiBzcmMvaW5jbHVkZS90c2VhcmNoL3RzX2xvY2Fs
ZS5oIHwgMiArLQogMiBmaWxlcyBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25z
KC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2luY2x1ZGUvbWIvcGdfd2NoYXIuaCBiL3NyYy9pbmNsdWRl
L21iL3BnX3djaGFyLmgKaW5kZXggZTE2NTVmZTYxZDYuLmEzMzI2ZTM2NWE3IDEwMDY0NAotLS0g
YS9zcmMvaW5jbHVkZS9tYi9wZ193Y2hhci5oCisrKyBiL3NyYy9pbmNsdWRlL21iL3BnX3djaGFy
LmgKQEAgLTcwMCw3ICs3MDAsNyBAQCBleHRlcm4gaW50CXBnX21ibGVuX3JhbmdlKGNvbnN0IGNo
YXIgKm1ic3RyLCBjb25zdCBjaGFyICplbmQpOwogZXh0ZXJuIGludAlwZ19tYmxlbl93aXRoX2xl
bihjb25zdCBjaGFyICptYnN0ciwgaW50IGxpbWl0KTsKIGV4dGVybiBpbnQJcGdfbWJsZW5fdW5i
b3VuZGVkKGNvbnN0IGNoYXIgKm1ic3RyKTsKIAotLyogZGVwcmVjYXRlZCAqLworcGdfYXR0cmli
dXRlX2RlcHJlY2F0ZWQoInVzZSBwZ19tYmxlbl97Y3N0cixyYW5nZSx3aXRoX2xlbix1bmJvdW5k
ZWR9IGluc3RlYWQiKQogZXh0ZXJuIGludAlwZ19tYmxlbihjb25zdCBjaGFyICptYnN0cik7CiAK
IGV4dGVybiBpbnQJcGdfZHNwbGVuKGNvbnN0IGNoYXIgKm1ic3RyKTsKZGlmZiAtLWdpdCBhL3Ny
Yy9pbmNsdWRlL3RzZWFyY2gvdHNfbG9jYWxlLmggYi9zcmMvaW5jbHVkZS90c2VhcmNoL3RzX2xv
Y2FsZS5oCmluZGV4IDZlMmQ2N2VlNGE1Li45MGU1MzNlZWEzMSAxMDA2NDQKLS0tIGEvc3JjL2lu
Y2x1ZGUvdHNlYXJjaC90c19sb2NhbGUuaAorKysgYi9zcmMvaW5jbHVkZS90c2VhcmNoL3RzX2xv
Y2FsZS5oCkBAIC02MCw3ICs2MCw3IEBAIGV4dGVybiBpbnQJdF9pcyMjY2hhcmFjdGVyX2NsYXNz
IyNfd2l0aF9sZW4oY29uc3QgY2hhciAqcHRyLCBpbnQgbGVuKTsgXAogZXh0ZXJuIGludAl0X2lz
IyNjaGFyYWN0ZXJfY2xhc3MjI19jc3RyKGNvbnN0IGNoYXIgKnB0cik7IFwKIGV4dGVybiBpbnQJ
dF9pcyMjY2hhcmFjdGVyX2NsYXNzIyNfdW5ib3VuZGVkKGNvbnN0IGNoYXIgKnB0cik7IFwKIFwK
LS8qIGRlcHJlY2F0ZWQgKi8gXAorcGdfYXR0cmlidXRlX2RlcHJlY2F0ZWQoInVzZSB0X2lzWFhY
X3tjc3RyLHdpdGhfbGVuLHVuYm91bmRlZH0gaW5zdGVhZCIpIFwKIGV4dGVybiBpbnQJdF9pcyMj
Y2hhcmFjdGVyX2NsYXNzKGNvbnN0IGNoYXIgKnB0cik7CiAKIEdFTkVSQVRFX1RfSVNDTEFTU19E
RUNMKGFsbnVtKTsKLS0gCjIuNTMuMAoK
--000000000000f785bb064efeb3b3
Content-Type: text/x-patch; charset="US-ASCII";
	name="0003-Remove-pg_mblen-and-related-functions.patch"
Content-Disposition: attachment;
	filename="0003-Remove-pg_mblen-and-related-functions.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mnqwp00c2>
X-Attachment-Id: f_mnqwp00c2

RnJvbSA0NzdjZjhlYzFhZTllZjMzMzk4OGMwZGNkNDhhMjBkMDBlYWNkOTNiIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBUaG9tYXMgTXVucm8gPHRob21hcy5tdW5yb0BnbWFpbC5jb20+
CkRhdGU6IFdlZCwgMSBBcHIgMjAyNiAyMzoyNDozMyArMTMwMApTdWJqZWN0OiBbUEFUQ0ggMy8z
XSBSZW1vdmUgcGdfbWJsZW4oKSBhbmQgcmVsYXRlZCBmdW5jdGlvbnMuCgpwZ19tYmxlbigpIHdh
cyB1bnNhZmUgYW5kIGRlY2xhcmVkIGRlcHJlY2F0ZWQgaW4gYWxsIHJlbGVhc2UgYnJhbmNoZXMs
CmFuZCBjYW4gbm93IHJlbW92ZWQgaW4gbWFzdGVyLiAgVGhlIHRfaXMqKCkgZnVuY3Rpb25zIHdl
cmUgbGVzcyB1bnNhZmUsCmJ1dCBuZWVkZWQgdG8ga25vdyB3aGljaCBwZ19tYmxlbl9YWFgoKSBy
ZXBsYWNlbWVudCB0byBjYWxsIHNvIHRoZXkgYWxzbwpnYWluZWQgcGFyYWxsZWwgcmVwbGFjZW1l
bnRzLgoKUmV2aWV3ZWQtYnk6CkRpc2N1c3Npb246Ci0tLQogc3JjL2JhY2tlbmQvdHNlYXJjaC90
c19sb2NhbGUuYyB8IDEyIC0tLS0tLS0tLS0tLQogc3JjL2JhY2tlbmQvdXRpbHMvbWIvbWJ1dGls
cy5jICB8IDEwIC0tLS0tLS0tLS0KIHNyYy9pbmNsdWRlL21iL3BnX3djaGFyLmggICAgICAgfCAg
MyAtLS0KIHNyYy9pbmNsdWRlL3RzZWFyY2gvdHNfbG9jYWxlLmggfCAgOSArLS0tLS0tLS0KIDQg
ZmlsZXMgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDMzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp
dCBhL3NyYy9iYWNrZW5kL3RzZWFyY2gvdHNfbG9jYWxlLmMgYi9zcmMvYmFja2VuZC90c2VhcmNo
L3RzX2xvY2FsZS5jCmluZGV4IGRmMDJmZmIxMmZkLi4xMmVmM2QxMWIzMiAxMDA2NDQKLS0tIGEv
c3JjL2JhY2tlbmQvdHNlYXJjaC90c19sb2NhbGUuYworKysgYi9zcmMvYmFja2VuZC90c2VhcmNo
L3RzX2xvY2FsZS5jCkBAIC00MSwxOCArNDEsNiBAQCBpbnQgXAogdF9pcyMjY2hhcmFjdGVyX2Ns
YXNzIyNfY3N0cihjb25zdCBjaGFyICpwdHIpIFwKIHsgXAogCXJldHVybiB0X2lzIyNjaGFyYWN0
ZXJfY2xhc3MjI193aXRoX2xlbihwdHIsIHBnX21ibGVuX2NzdHIocHRyKSk7IFwKLX0gXAotLyog
cHRyIHNoYWxsIHBvaW50IHRvIGEgc3RyaW5nIHdpdGggcHJlLXZhbGlkYXRlZCBlbmNvZGluZyAq
LyBcCi1pbnQgXAotdF9pcyMjY2hhcmFjdGVyX2NsYXNzIyNfdW5ib3VuZGVkKGNvbnN0IGNoYXIg
KnB0cikgXAoteyBcCi0JcmV0dXJuIHRfaXMjI2NoYXJhY3Rlcl9jbGFzcyMjX3dpdGhfbGVuKHB0
ciwgcGdfbWJsZW5fdW5ib3VuZGVkKHB0cikpOyBcCi19IFwKLS8qIGhpc3RvcmljYWwgbmFtZSBm
b3IgX3VuYm91bmRlZCAqLyBcCi1pbnQgXAotdF9pcyMjY2hhcmFjdGVyX2NsYXNzKGNvbnN0IGNo
YXIgKnB0cikgXAoteyBcCi0JcmV0dXJuIHRfaXMjI2NoYXJhY3Rlcl9jbGFzcyMjX3VuYm91bmRl
ZChwdHIpOyBcCiB9CiAKIEdFTkVSQVRFX1RfSVNDTEFTU19ERUYoYWxudW0pCmRpZmYgLS1naXQg
YS9zcmMvYmFja2VuZC91dGlscy9tYi9tYnV0aWxzLmMgYi9zcmMvYmFja2VuZC91dGlscy9tYi9t
YnV0aWxzLmMKaW5kZXggNzhmNGQ1ZTIwMmMuLjA4ZDgwZjJjMzZmIDEwMDY0NAotLS0gYS9zcmMv
YmFja2VuZC91dGlscy9tYi9tYnV0aWxzLmMKKysrIGIvc3JjL2JhY2tlbmQvdXRpbHMvbWIvbWJ1
dGlscy5jCkBAIC0xMTQzLDE2ICsxMTQzLDYgQEAgcGdfbWJsZW5fdW5ib3VuZGVkKGNvbnN0IGNo
YXIgKm1ic3RyKQogCXJldHVybiBsZW5ndGg7CiB9CiAKLS8qCi0gKiBIaXN0b3JpY2FsIG5hbWUg
Zm9yIHBnX21ibGVuX3VuYm91bmRlZCgpLiAgU2hvdWxkIG5vdCBiZSB1c2VkIGFuZCB3aWxsIGJl
Ci0gKiByZW1vdmVkIGluIGEgbGF0ZXIgdmVyc2lvbi4KLSAqLwotaW50Ci1wZ19tYmxlbihjb25z
dCBjaGFyICptYnN0cikKLXsKLQlyZXR1cm4gcGdfbWJsZW5fdW5ib3VuZGVkKG1ic3RyKTsKLX0K
LQogLyogcmV0dXJucyB0aGUgZGlzcGxheSBsZW5ndGggb2YgYSBtdWx0aWJ5dGUgY2hhcmFjdGVy
ICovCiBpbnQKIHBnX2RzcGxlbihjb25zdCBjaGFyICptYnN0cikKZGlmZiAtLWdpdCBhL3NyYy9p
bmNsdWRlL21iL3BnX3djaGFyLmggYi9zcmMvaW5jbHVkZS9tYi9wZ193Y2hhci5oCmluZGV4IGEz
MzI2ZTM2NWE3Li5lNDJjZjU2MjYzNSAxMDA2NDQKLS0tIGEvc3JjL2luY2x1ZGUvbWIvcGdfd2No
YXIuaAorKysgYi9zcmMvaW5jbHVkZS9tYi9wZ193Y2hhci5oCkBAIC03MDAsOSArNzAwLDYgQEAg
ZXh0ZXJuIGludAlwZ19tYmxlbl9yYW5nZShjb25zdCBjaGFyICptYnN0ciwgY29uc3QgY2hhciAq
ZW5kKTsKIGV4dGVybiBpbnQJcGdfbWJsZW5fd2l0aF9sZW4oY29uc3QgY2hhciAqbWJzdHIsIGlu
dCBsaW1pdCk7CiBleHRlcm4gaW50CXBnX21ibGVuX3VuYm91bmRlZChjb25zdCBjaGFyICptYnN0
cik7CiAKLXBnX2F0dHJpYnV0ZV9kZXByZWNhdGVkKCJ1c2UgcGdfbWJsZW5fe2NzdHIscmFuZ2Us
d2l0aF9sZW4sdW5ib3VuZGVkfSBpbnN0ZWFkIikKLWV4dGVybiBpbnQJcGdfbWJsZW4oY29uc3Qg
Y2hhciAqbWJzdHIpOwotCiBleHRlcm4gaW50CXBnX2RzcGxlbihjb25zdCBjaGFyICptYnN0cik7
CiBleHRlcm4gaW50CXBnX21ic3RybGVuKGNvbnN0IGNoYXIgKm1ic3RyKTsKIGV4dGVybiBpbnQJ
cGdfbWJzdHJsZW5fd2l0aF9sZW4oY29uc3QgY2hhciAqbWJzdHIsIGludCBsaW1pdCk7CmRpZmYg
LS1naXQgYS9zcmMvaW5jbHVkZS90c2VhcmNoL3RzX2xvY2FsZS5oIGIvc3JjL2luY2x1ZGUvdHNl
YXJjaC90c19sb2NhbGUuaAppbmRleCA5MGU1MzNlZWEzMS4uYjZhMmQyOWVlM2YgMTAwNjQ0Ci0t
LSBhL3NyYy9pbmNsdWRlL3RzZWFyY2gvdHNfbG9jYWxlLmgKKysrIGIvc3JjL2luY2x1ZGUvdHNl
YXJjaC90c19sb2NhbGUuaApAQCAtNTIsMTYgKzUyLDkgQEAgdHNfY29weWNoYXJfY3N0cih2b2lk
ICpkZXN0LCBjb25zdCB2b2lkICpzcmMpCiAJcmV0dXJuIHRzX2NvcHljaGFyX3dpdGhfbGVuKGRl
c3QsIHNyYywgcGdfbWJsZW5fY3N0cigoY29uc3QgY2hhciAqKSBzcmMpKTsKIH0KIAotLyogSGlz
dG9yaWNhbCBtYWNybyBmb3IgdGhlIGFib3ZlLiAqLwotI2RlZmluZSBDT1BZQ0hBUiB0c19jb3B5
Y2hhcl9jc3RyCi0KICNkZWZpbmUgR0VORVJBVEVfVF9JU0NMQVNTX0RFQ0woY2hhcmFjdGVyX2Ns
YXNzKSBcCiBleHRlcm4gaW50CXRfaXMjI2NoYXJhY3Rlcl9jbGFzcyMjX3dpdGhfbGVuKGNvbnN0
IGNoYXIgKnB0ciwgaW50IGxlbik7IFwKLWV4dGVybiBpbnQJdF9pcyMjY2hhcmFjdGVyX2NsYXNz
IyNfY3N0cihjb25zdCBjaGFyICpwdHIpOyBcCi1leHRlcm4gaW50CXRfaXMjI2NoYXJhY3Rlcl9j
bGFzcyMjX3VuYm91bmRlZChjb25zdCBjaGFyICpwdHIpOyBcCi1cCi1wZ19hdHRyaWJ1dGVfZGVw
cmVjYXRlZCgidXNlIHRfaXNYWFhfe2NzdHIsd2l0aF9sZW4sdW5ib3VuZGVkfSBpbnN0ZWFkIikg
XAotZXh0ZXJuIGludAl0X2lzIyNjaGFyYWN0ZXJfY2xhc3MoY29uc3QgY2hhciAqcHRyKTsKK2V4
dGVybiBpbnQJdF9pcyMjY2hhcmFjdGVyX2NsYXNzIyNfY3N0cihjb25zdCBjaGFyICpwdHIpOwog
CiBHRU5FUkFURV9UX0lTQ0xBU1NfREVDTChhbG51bSk7CiBHRU5FUkFURV9UX0lTQ0xBU1NfREVD
TChhbHBoYSk7Ci0tIAoyLjUzLjAKCg==
--000000000000f785bb064efeb3b3--