MIME-Version: 1.0
References: <3095349b-44d4-bf11-1b33-7eefb585d578@2ndquadrant.com>
In-Reply-To: <3095349b-44d4-bf11-1b33-7eefb585d578@2ndquadrant.com>
From: Thomas Munro <thomas.munro@gmail.com>
Date: Mon, 8 Jul 2019 22:28:18 +1200
Message-ID: 
 <CA+hUKGKJjfQYmMj0EL4ZvcSmFjS__odFuru04DJM66a3HuB=sg@mail.gmail.com>
Subject: Re: Synchronizing slots from primary to standby
To: Petr Jelinek <petr.jelinek@2ndquadrant.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Dec 31, 2018 at 10:23 AM Petr Jelinek
<petr.jelinek@2ndquadrant.com> wrote:
> As Andres has mentioned over at minimal decoding on standby thread [1],
> that functionality can be used to add simple worker which periodically
> synchronizes the slot state from the primary to a standby.
>
> Attached patch is rough implementation of such worker. It's nowhere near
> committable in the current state, it servers primarily two purposes - to
> have something over what we can agree on the approach (and if we do,
> serve as base for that) and to demonstrate that the patch in [1] can
> indeed be used for this functionality. All this means that this patch
> depends on the [1] to work.

Hi Petr,

Do I understand correctly that this depends on the "logical decoding
on standby" patch, but that isn't in the Commitfest?  Seems like an
oversight, since that thread has a recently posted v11 patch that
applies OK, and there was recent review.  You patches no longer apply
on top though.  Would it make sense to post a patch set here including
logical-decoding-on-standby_v11.patch + your two patches (rebased),
since this is currently marked as "Needs review"?

-- 
Thomas Munro
https://enterprisedb.com