Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w6fTa-004WwA-1I for pgsql-hackers@arkaria.postgresql.org; Sun, 29 Mar 2026 02:02:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1w6fTY-00FbXu-36 for pgsql-hackers@arkaria.postgresql.org; Sun, 29 Mar 2026 02:02:05 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w6fTY-00FbXm-2B for pgsql-hackers@lists.postgresql.org; Sun, 29 Mar 2026 02:02:05 +0000 Received: from mail-dy1-x1333.google.com ([2607:f8b0:4864:20::1333]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1w6fTX-00000001Zvk-1V1O for pgsql-hackers@lists.postgresql.org; Sun, 29 Mar 2026 02:02:04 +0000 Received: by mail-dy1-x1333.google.com with SMTP id 5a478bee46e88-2c16dc38120so237602eec.3 for ; Sat, 28 Mar 2026 19:02:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1774749722; cv=none; d=google.com; s=arc-20240605; b=aY6pn9B4qEZRFVEzKzfVWJyCGs6b26W/tzCnNMEjAcbcFF8a2Q1nyytFDzaBdwWL51 Rvjyur9uWXckohl6YvaYetWwruRCQAFhihW6GaqtKgW+bVEF3YLLsAeJvngWNXH/Rwsf oO2WtEUfINQcWW4UVdeFE+X7hmtLS6eEr28DEpQNontOz9e2ll35kJYroNCmC5S2TUxM VxZdpxnbVP+VLhxFzd4SOimQkF8iW6/njVfrWFFwoK9n0MCIySEo4qZumPFsx0jToz83 85olPZhd7bJ65MPEUZG06wwr18T+hsKiDv4HS+kRjNwrdiu3qMXoakTwfduoSwAfH+pc WtWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=S77koDYsrFD4BfSLR0mOASjCT3oMV+ckdq9cHdvm5J4=; fh=bG6JoboGo1FVmo7K/r4nfHZ+qrCq/wKAZ2UGP5doSAQ=; b=BA8pwNXA1cYLaQeEWwrRqappiWpYM8ck0x7XnHAgH+b9+X3bsectxwB8oDfEYRKxiX UNsGyQQjH74zrHlYCJl1aERVJmpR7Y9wbohY6dKBrHm/W0+6Z0JB5vpV4edWr6d29RH+ +7K6QA39cvTyYMkxPZv+yszC1gN2ipiywv5hTN5cVaet1UgB3Mc8gmvLDyZ8xRbPSgf/ EgP7l9eZNCg072kCyNUr+CidK564XxM0yIoC1YRBJdL/gTzwqUIcR0LD6IuW++hbS0X9 WpWeooW/l7zLUZuXXuDo7Pve1kT9qPkC1kT5RamuVvuKYt1TBOtKARh4fzbp9MHaMb0a bFfQ==; darn=lists.postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774749722; x=1775354522; darn=lists.postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=S77koDYsrFD4BfSLR0mOASjCT3oMV+ckdq9cHdvm5J4=; b=Fa+kT3q4vCltE1flCKK/o0jWttD3fpSP1dL8ibW12JfG0cPEWeH3oQCtG+HOzDg00U NQ1UPF1x5V6sceGk9gHg7z8jR858M3RwOXf2Qpg9IvL4OnAuUzN5nT8WpxdSnqaarUaA NZx2bwq+GPRbN7IYbNA1irMGLLQt4XqN/eqc78frJQJXbDeypJOaVEf2rKefua27+bMX n6j1Eo8KuGcTGuZLmb1zARsfGyzEL/dGPwfPtzzsVlbGHR95kh6uybjwRzfZUl5tkmC/ RWOa8nurUhlLzD+t6+pp2YX6LoyjNizvUtsGh03zEnlypyOJFFu+qs3JQlAlK//EfYk2 KcbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774749722; x=1775354522; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=S77koDYsrFD4BfSLR0mOASjCT3oMV+ckdq9cHdvm5J4=; b=DcIlqF6FxC2s+7/+MVxM9OQgf5c9KgdEyArvXR7EmXT1kkfzG7t0p7uqW3kkxXDUTx dRNV+obIwdTALEQslwRwZr/LrKLZmHY9enP2IlT47yu7SFR8PZ5lizHDNVoj4HkGRONn DTmEGbOqqAVdtQlzf76ZMfbGdFHBw4/4OSCeNWR+/LVtLwD0LwPnRKysgsz6n3qJOI96 i6FIELpSKBAAujxrH2Klu9EI2WRiDrxeQ0g18U99mLv59Pa3w40jUkeObSxOZW3l6Z7V FiNPfkoTa8to6yPiA7IYmu7fXqsrHR9tiKJq2VJqBvz8XbfncxDoQjfXA4We8OwhPwOp uN1Q== X-Forwarded-Encrypted: i=1; AJvYcCVu7aGGzCWnoMLlTZt+sp7e5gaMSK2ZMpjeOkjbTvjx6/vfpVb9Z3nUck7TqxrB05HoeLfadcEB/pblx62v@lists.postgresql.org X-Gm-Message-State: AOJu0YwMrqjF3sysUESJlV/my7NbKsAIFzDeP5+sJxuPswkYsltmSeO9 AzvK6dvTDUKEfIXCzIJHhPMwqEmOEgYPSmedLiz88SdAcCaOw0PfE6rvRCRUMTariLL2Z4OsOXR SHg8V2z34goFf/tcGbBPPDz+0OSnooQ8= X-Gm-Gg: ATEYQzw/23XbcE/60vZSiqPGyAMcwF41lNj2i/TVwe+Szyyi52BWAIFEtlJYpAm+S7v bxL0xbz0t7sKUHCL4OcY1cgDiwG66IMpJv/+YoJ/aZRyDMxOvQgxIrEpB+9T39MZ9+tj7pfEenw YcMZP+qJpJ5aS3JRMzqEAFQqWA/j6IBDvV+uQA/R55rrmh90pq+0Bpvmyzpit02R1QZ3pPzfyGK P9Lri7D7KxHkeVVdA0nhqxL6fhVobIWXnZfiNfjqVJM+dr3wSqUKHgmxQ2xZsudSWyCE+kZniZs n9FkXLgLMUnR7xQvjkK+sATTWI/U/JCa8NhDlwLCdVV5rW7P2kJ9NmTBX5j0q8sN X-Received: by 2002:a05:7300:ca7:b0:2c0:c961:4b98 with SMTP id 5a478bee46e88-2c185fd1e4bmr1829957eec.7.1774749722230; Sat, 28 Mar 2026 19:02:02 -0700 (PDT) MIME-Version: 1.0 References: <1633233.1774740875@sss.pgh.pa.us> In-Reply-To: From: Thomas Munro Date: Sun, 29 Mar 2026 15:01:24 +1300 X-Gm-Features: AQROBzBVckYy52Wm8KmW5EkdTXsqF1vOFU85uplln2q-j5SwwRVmUKcJqUjbQNw Message-ID: Subject: Re: pg_waldump: support decoding of WAL inside tarfile To: Andrew Dunstan Cc: Tom Lane , Tomas Vondra , Andres Freund , Michael Paquier , Amul Sul , Zsolt Parragi , Robert Haas , Chao Li , Anthonin Bonnefoy , Masao Fujii , Jakub Wartak , PostgreSQL Hackers Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Sun, Mar 29, 2026 at 2:59=E2=80=AFPM Andrew Dunstan wrote: > Looks basically ok to me, although I wouldn=E2=80=99t make the variable n= ame all caps. Will fix and push. Thanks!