MIME-Version: 1.0
References: <Yo8ByDo5TgnrrJkd@paquier.xyz>
 <CAC+AXB0QpmRnDDjBUYsbc+zhDxd7Fo4JxwSzvZgEK1_G3+19qQ@mail.gmail.com>
 <YpBLJ/7Cn2k0E0PG@paquier.xyz>
 <CA+hUKG+YConztrBpDWiMGQ_ZcNeJtj72qDvCS0jZHN703k0wcA@mail.gmail.com>
 <E54B0785-CE88-466E-88B7-46AEBABE9844@yesql.se>
 <YpRraObyTiK3C1Gx@paquier.xyz>
 <YqFvNnkbYUeP8v2c@paquier.xyz>
 <CA+hUKGKoT-77HwufN6h55NpOdTHU6ukDXWiA0B3NqCn+cmQR7w@mail.gmail.com>
 <YqGJeEYLSMxVfRd4@paquier.xyz> <YqrKOPvi/JtS5gzR@paquier.xyz>
 <YsU5fb0ceDADr2Ti@paquier.xyz>
In-Reply-To: <YsU5fb0ceDADr2Ti@paquier.xyz>
From: Thomas Munro <thomas.munro@gmail.com>
Date: Thu, 7 Jul 2022 08:46:26 +1200
Message-ID: 
 <CA+hUKGL1p7BHdZc_GEBYkLarPzFEAYKd_HXA_NJ_ct4dJCD-iw@mail.gmail.com>
Subject: Re: Bump MIN_WINNT to 0x0600 (Vista) as minimal runtime in 16~
To: Michael Paquier <michael@paquier.xyz>
Cc: Daniel Gustafsson <daniel@yesql.se>,
	=?UTF-8?Q?Juan_Jos=C3=A9_Santamar=C3=ADa_Flecha?=
 <juanjo.santamaria@gmail.com>,
	Postgres hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2BhUKGL1p7BHdZc_GEBYkLarPzFEAYKd_HXA_NJ_ct4dJCD-iw%40mail.gmail.com>
Precedence: bulk

On Wed, Jul 6, 2022 at 7:28 PM Michael Paquier <michael@paquier.xyz> wrote:
> On Thu, Jun 16, 2022 at 03:14:16PM +0900, Michael Paquier wrote:
> > Actually, this can go with the bump of MIN_WINNT as it uses one of the
> > IsWindows*OrGreater() macros as a runtime check.  And there are two
> > more places in pg_ctl.c that can be similarly cleaned up.
> >
> > It is possible that I have missed some spots, of course.
>
> It does not seem to be the case on a second look.  The buildfarm
> animals running Windows are made of:
> - hamerkop, Windows server 2016 (based on Win10 AFAIK)
> - drongo, Windows server 2019
> - bowerbird, Windows 10 pro
> - jacana, Windows 10
> - fairywren, Msys server 2019
> - bichir, Ubuntu/Windows 10 mix
>
> Now that v16 is open for business, any objections to move on with this
> patch and bump MIN_WINNT to 0x0A00 on HEAD?  There are follow-up items
> for large pages and more.

+1 for proceeding.  This will hopefully unblock a few things, and it's
good to update our claims to match the reality of what we are actually
testing and able to debug.

The build farm also has frogmouth and currawong, 32 bit systems
running Windows XP, but they are only testing REL_10_STABLE so I
assume Andrew will decommission them in November.