MIME-Version: 1.0
References: <CWZBBRR6YA8D.8EHMDRGLCKCD@neon.tech> <CA+hUKGKu7H7iPNQsZ5FcPkZVbgXc5iTBgUjdpM2EHP4q=Tz42Q@mail.gmail.com>
 <12842.1700083028@sss.pgh.pa.us> <CA+hUKGJ4s6uDK_KYK-2q=2aWztgvTHYqGeSzugaTCEs6_3XqAg@mail.gmail.com>
 <98824.1700089582@sss.pgh.pa.us> <CA+hUKGLLb1MiqAUwtSb6gQsqm8wgAh+7UEE-6P1tQxjhHCFmrw@mail.gmail.com>
 <664255.1700245108@sss.pgh.pa.us> <810814.1700261928@sss.pgh.pa.us>
 <CA+hUKGLy2AeE0a6MHq_KQhJXbOQJ6UHsrUoCwb5OGj+WijAWqw@mail.gmail.com>
 <1155474.1700433384@sss.pgh.pa.us> <CA+hUKG+YxfUyUOY7OHUFCgenAgq9znksd=Z+vyb20KHG=2iAnw@mail.gmail.com>
 <1330178.1700498443@sss.pgh.pa.us> <CA+hUKG+Yv+ps=nS2T8SS1UDU=iySHSr4sGHYiYGkPTpZx6Ooww@mail.gmail.com>
 <CA+hUKGLs9ccA7pUfphZOuf_fcVq2FAai7Cm0pmbQk0Qcs4VoVQ@mail.gmail.com>
 <CA+hUKGKOuA4vTkFk01RSLqyM0pzNjYm-3h2zAtW48Ffc7FjjNg@mail.gmail.com>
 <CA+hUKG+ue0KC5KSqMuL5zi7uCSuXCLP_B+sZSq5=yS84606ZsA@mail.gmail.com>
 <423491f5-2eaa-454e-8dc9-037d69c1a8f9@eisentraut.org> <CA+hUKG+fApBC7Ziq2HP6K-6ymD=AafyvYQq9HGfyRCoBw-PGtQ@mail.gmail.com>
 <d9e7731c-ca1b-477c-9298-fa51e135574a@eisentraut.org> <CA+hUKGLbEhVb029AQJDCZ4+QgcqVmERJGZefxS=+b+SBBSGW8A@mail.gmail.com>
In-Reply-To: <CA+hUKGLbEhVb029AQJDCZ4+QgcqVmERJGZefxS=+b+SBBSGW8A@mail.gmail.com>
From: Thomas Munro <thomas.munro@gmail.com>
Date: Thu, 21 Nov 2024 12:30:05 +1300
Message-ID: <CA+hUKGL3FD0OoA2go2qijcAMDBOBnQrLMX-+9bhmxr7Qi_c3_A@mail.gmail.com>
Subject: Re: On non-Windows, hard depend on uselocale(3)
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Tristan Partin <tristan@neon.tech>, Tom Lane <tgl@sss.pgh.pa.us>, 
	pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CA%2BhUKGL3FD0OoA2go2qijcAMDBOBnQrLMX-%2B9bhmxr7Qi_c3_A%40mail.gmail.com>
Precedence: bulk

On Wed, Nov 20, 2024 at 10:00=E2=80=AFPM Thomas Munro <thomas.munro@gmail.c=
om> wrote:
> OK, do you think these three patches tell the _configthreadlocale()
> story properly?  (Then after that we can get back to getting rid of
> it...)

Just by the way, here's another interesting thing I have learned about
the msvcrt->ucrt evolution: ucrt introduced UTF-8 support (ie locales
can use UTF-8 encoding, and all the standard library char functions
work with it just fine like on Unix), but PostgreSQL still believes
that Windows can't do that and has a lot of special code paths to work
with wchar_t and perform extra conversions.  I started nibbling at
that[1], but at the time I was still a bit fuzzy on whether we could
really rip all that old stuff out yet and harmonise with Unix, as I
didn't understand the MinGW/runtime/history situation.  It seems the
coast is now clear, and that would be a satisfying cleanup.  (There's
still non-trivial work to do for that though: we allowed weird
mismatched encoding scenarios just on that OS, and would need to stop
that, which might create some upgrade path problems, needs some
thought, see that thread.)

[1] https://www.postgresql.org/message-id/CA%2BhUKGJ%3Dca39Cg%3Dy%3DS89EaCY=
vvCF8NrZRO%3Duog-cnz0VzC6Kfg%40mail.gmail.com