MIME-Version: 1.0
References: <20220925232237.p6uskba2dw6fnwj2@awork3.anarazel.de>
 <20221209020815.wsoixct72c6hst5l@awork3.anarazel.de> <20221229172330.jpuoljhtvivci3cd@awork3.anarazel.de>
 <CA+hUKGKumpwy+_Zx9_dshccF2HYKqwMCbeeSoOFXy+9ntsh54Q@mail.gmail.com>
 <20221229215437.s4q5lu6ijb67jugx@awork3.anarazel.de> <CA+hUKG+pZkPAag-KqSCDKcuUv03yBtKk0p-i662VbHi_Jzuyhw@mail.gmail.com>
 <20230103200520.di5hjebqvi72coql@awork3.anarazel.de> <20230110020501.bujiesmhe2fuka42@awork3.anarazel.de>
In-Reply-To: <20230110020501.bujiesmhe2fuka42@awork3.anarazel.de>
From: Thomas Munro <thomas.munro@gmail.com>
Date: Sat, 14 Jan 2023 14:45:06 +1300
Message-ID: <CA+hUKGLTngoe7NAWAOUut2p9uiWCKhvLfbaFJJi4p+QXeEZQ7A@mail.gmail.com>
Subject: Re: postgres_fdw uninterruptible during connection establishment / ProcSignalBarrier
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org, Robert Haas <robertmhaas@gmail.com>, 
	Peter Geoghegan <pg@bowt.ie>, Tom Lane <tgl@sss.pgh.pa.us>, Fujii Masao <fujii@postgresql.org>, 
	Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://www.postgresql.org/message-id/CA%2BhUKGLTngoe7NAWAOUut2p9uiWCKhvLfbaFJJi4p%2BQXeEZQ7A%40mail.gmail.com>
Precedence: bulk

On Tue, Jan 10, 2023 at 3:05 PM Andres Freund <andres@anarazel.de> wrote:
> On 2023-01-03 12:05:20 -0800, Andres Freund wrote:
> > The attached patch adds libpq-be-fe-helpers.h and uses it in libpqwalreceiver,
> > dblink, postgres_fdw.
>
> > As I made libpq-be-fe-helpers.h handle reserving external fds,
> > libpqwalreceiver now does so. I briefly looked through its users without
> > seeing cases of leaking in case of errors - which would already have been bad,
> > since we'd already have leaked a libpq connection/socket.
> >
> >
> > Given the lack of field complaints and the size of the required changes, I
> > don't think we should backpatch this, even though it's pretty clearly buggy
> > as-is.
>
> Any comments on this? Otherwise I think I'll go with this approach.

+1.  Not totally convinced about the location but we are free to
re-organise it any time, and the random CI failures are bad.