MIME-Version: 1.0
References: <CA+hUKGKNX_=f+1C4r06WETKTq0G4Z_7q4L4Fxn5WWpMycDj9Fw@mail.gmail.com>
 <5716086.DvuYhMxLoT@aivenlaptop> <CA+hUKGLxVtLCo3xD1OEnMSQbq04MKx1G_vQ5SZQNMBSFPR_TpA@mail.gmail.com>
 <2700884.mvXUDI8C0e@aivenlaptop> <CA+hUKGKnLnJnWrkr=4mSGhE5FuTK55FY15uULR7=zzc=wX4Nqw@mail.gmail.com>
 <CA+hUKGKtUB=-BQZd=u4BFZ-UJWi47fekwiYMSDXDZMyV+z1G-g@mail.gmail.com>
 <CA+hUKG+hopeRBGVwS4JE3uy1UO3TRnhF08HMiSpMrPODgtiw9Q@mail.gmail.com>
 <CA+hUKGKReczOCzaL8J2aGv2YBOLDGJaLpF1wVmhtpFp6QmQagg@mail.gmail.com> <20231020221213.zlgwsh7wtwyz33ag@awork3.anarazel.de>
In-Reply-To: <20231020221213.zlgwsh7wtwyz33ag@awork3.anarazel.de>
From: Thomas Munro <thomas.munro@gmail.com>
Date: Sat, 21 Oct 2023 12:02:51 +1300
Message-ID: <CA+hUKGLZKP8yvnutdbofyAs4sjSaBNzQCN8vf-CM3S3da08XcQ@mail.gmail.com>
Subject: Re: LLVM 16 (opaque pointers)
To: Andres Freund <andres@anarazel.de>
Cc: Ronan Dunklau <ronan.dunklau@aiven.io>, =?UTF-8?B?RGV2cmltIEfDvG5kw7x6?= <devrim@gunduz.org>, 
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Fabien COELHO <coelho@cri.ensmp.fr>, 
	Dmitry Dolgov <9erthalion6@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CA%2BhUKGLZKP8yvnutdbofyAs4sjSaBNzQCN8vf-CM3S3da08XcQ%40mail.gmail.com>
Precedence: bulk

On Sat, Oct 21, 2023 at 11:12=E2=80=AFAM Andres Freund <andres@anarazel.de>=
 wrote:
> On 2023-10-21 10:48:47 +1300, Thomas Munro wrote:
> > On Thu, Oct 19, 2023 at 6:20=E2=80=AFAM Thomas Munro <thomas.munro@gmai=
l.com> wrote:
> > I see that Mark has also just enabled --with-llvm on some POWER Linux
> > animals, and they have failed in various ways.  The failures are
> > strangely lacking in detail.  It seems we didn't have coverage before,
> > and I recall that there were definitely versions of LLVM that *didn't*
> > work for our usage in the past, which I'll need to dredge out of the
> > archives.  I will try to get onto a cfarm POWER machine and see if I
> > can reproduce that, before and after these commits, and whose bug is
> > it etc.
>
> I'm quite sure that jiting did pass on ppc64 at some point.

Yeah, I remember debugging it on EDB's POWER machine.  First off, we
know that LLVM < 7 doesn't work for us on POWER, because:

https://www.postgresql.org/message-id/CAEepm%3D39F_B3Ou8S3OrUw%2BhJEUP3p%3D=
wCu0ug-TTW67qKN53g3w%40mail.gmail.com

That was fixed:

https://github.com/llvm/llvm-project/commit/a95b0df5eddbe7fa1e9f8fe0b1ff624=
27e1c0318

So I think that means that we'd first have to go through those animals
and figure out which ones have older LLVM, and ignore those results --
they just can't use --with-llvm.  Unfortunately there doesn't seem to
be any clue on the version from the paths used by OpenSUSE.  Mark, do
you know?

> > I doubt I can get anywhere near an s390x though, and we definitely had
> > pre-existing problems on that arch.
>
> IMO an LLVM bug, rather than a postgres bug, but I guess it's all a matte=
r of
> perspective.
> https://github.com/llvm/llvm-project/issues/53009#issuecomment-1042748553

Ah, good to know about that.  But there are also reports of crashes in
released versions that manage to get passed that ABI-wobble business:

https://www.postgresql.org/message-id/flat/CAF1DzPXjpPxnsgySz2Zjm8d2dx7%3DJ=
070C%2BMQBFh%2B9NBNcBKCAg%40mail.gmail.com