MIME-Version: 1.0
References: <E1qjozv-005NY4-Rr@gemulon.postgresql.org> <ZU5yKecW5yMKKhtp@msg.df7cb.de>
 <ZU6jwsm4XvmAUUTN@msg.df7cb.de>
In-Reply-To: <ZU6jwsm4XvmAUUTN@msg.df7cb.de>
From: Thomas Munro <thomas.munro@gmail.com>
Date: Sat, 11 Nov 2023 11:05:48 +1300
Message-ID: <CA+hUKGLm3+2NZX1pEv+2Ky+MmD+nLeBxsNxKYtowepHUnbg8FQ@mail.gmail.com>
Subject: Re: pgsql: Don't trust unvalidated xl_tot_len.
To: Christoph Berg <myon@debian.org>
Cc: Thomas Munro <tmunro@postgresql.org>, pgsql-hackers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CA%2BhUKGLm3%2B2NZX1pEv%2B2Ky%2BMmD%2BnLeBxsNxKYtowepHUnbg8FQ%40mail.gmail.com>
Precedence: bulk

On Sat, Nov 11, 2023 at 10:42=E2=80=AFAM Christoph Berg <myon@debian.org> w=
rote:
> > I haven't investigated the details yet, and it's not affecting the
> > builds on apt.postgresql.org, but the Debian amd64 and i386 regression
> > tests just failed this test on PG13 (11 and 15 are ok):
>
> 12 and 14 are also failing, now on Debian unstable. (Again, only in
> the salsa.debian.org tests, not on apt.postgresql.org's buildds.)
>
> 12 amd64: https://salsa.debian.org/postgresql/postgresql/-/jobs/4898857
> 12 i386:  https://salsa.debian.org/postgresql/postgresql/-/jobs/4898858
>
> The tests there are running in Docker containers.

Hmm.  regress_log_039_end_of_wal says:

No such file or directory at
/builds/postgresql/postgresql/debian/output/source_dir/build/../src/test/pe=
rl/TestLib.pm
line 655.

In the 13 branch we see that's in the new scan_server_header()
subroutine where it tries to open the header, after asking pg_config
--includedir-server where it lives.  Hmm...