MIME-Version: 1.0
References: <CA+hUKGKNX_=f+1C4r06WETKTq0G4Z_7q4L4Fxn5WWpMycDj9Fw@mail.gmail.com>
 <CA+hUKGLdgmOGFUEefFGCaofPCsPj4WoCFJ-NpFTMjOFQnaog_w@mail.gmail.com>
 <CA+hUKGJnG8jJJkyULpg1xTxzNtL2FreS4C16TFcRLwu8RR1yUQ@mail.gmail.com> <5716086.DvuYhMxLoT@aivenlaptop>
In-Reply-To: <5716086.DvuYhMxLoT@aivenlaptop>
From: Thomas Munro <thomas.munro@gmail.com>
Date: Sat, 14 Oct 2023 09:32:13 +1300
Message-ID: <CA+hUKGLxVtLCo3xD1OEnMSQbq04MKx1G_vQ5SZQNMBSFPR_TpA@mail.gmail.com>
Subject: Re: LLVM 16 (opaque pointers)
To: Ronan Dunklau <ronan.dunklau@aiven.io>
Cc: =?UTF-8?B?RGV2cmltIEfDvG5kw7x6?= <devrim@gunduz.org>, 
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Fabien COELHO <coelho@cri.ensmp.fr>, 
	Andres Freund <andres@anarazel.de>, Dmitry Dolgov <9erthalion6@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CA%2BhUKGLxVtLCo3xD1OEnMSQbq04MKx1G_vQ5SZQNMBSFPR_TpA%40mail.gmail.com>
Precedence: bulk

On Wed, Oct 11, 2023 at 10:31=E2=80=AFPM Ronan Dunklau <ronan.dunklau@aiven=
.io> wrote:
> Le mercredi 11 octobre 2023, 10:59:50 CEST Thomas Munro a =C3=A9crit :
> > The back-patch to 12 was a little trickier than anticipated, but after
> > taking a break and trying again I now have PG 12...17 patches that
> > I've tested against LLVM 10...18 (that's 54 combinations), in every
> > case only with the clang corresponding to LLVM.
>
> Thank you Thomas for those patches, and the extensive testing, I will run=
 my
> own and let you know.

Thanks!  No news is good news, I hope?  I'm hoping to commit this today.

> > I've attached only the patches for master, but the 12-16 versions are
> > available at https://github.com/macdice/postgres/tree/llvm16-$N in
> > case anyone has comments on those.
>
> For PG13 and PG12, it looks like the ExecEvalBoolSubroutineTemplate is no=
t
> used anywhere, as ExecEvalBoolSubroutine was introduced in PG14 if I'm no=
t
> mistaken.

Right, looks like I can remove that in those branches.