MIME-Version: 1.0
References: <CAOYmi+kThkM9Z87u=R_Wi7fCor2i+UZKAyq0UCyprzCwTQvqgA@mail.gmail.com>
 <20240610200411.byj6sv2vpgol6wcf@awork3.anarazel.de> <CAOYmi+niQdwFdX7srOiD8zdme_rxEp2m4JGdqzK=+dS6dpV2Og@mail.gmail.com>
 <20240612155040.u6cvatdb5tiwcxci@awork3.anarazel.de> <FAC2FCFE-8C70-4996-9598-34DD7596BB41@yesql.se>
In-Reply-To: <FAC2FCFE-8C70-4996-9598-34DD7596BB41@yesql.se>
From: Daniele Varrazzo <daniele.varrazzo@gmail.com>
Date: Wed, 12 Jun 2024 19:38:54 +0200
Message-ID: <CA+mi_8Y=yKbPXDASxq0aYVMRcxp2hZ6ryAGhb26ewEDjw-0m+w@mail.gmail.com>
Subject: Re: RFC: adding pytest as a supported test framework
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Andres Freund <andres@anarazel.de>, Jacob Champion <jacob.champion@enterprisedb.com>, 
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://www.postgresql.org/message-id/CA%2Bmi_8Y%3DyKbPXDASxq0aYVMRcxp2hZ6ryAGhb26ewEDjw-0m%2Bw%40mail.gmail.com>
Precedence: bulk

On Wed, 12 Jun 2024 at 19:30, Daniel Gustafsson <daniel@yesql.se> wrote:

> I might be missing something obvious, but if we use a third-party libpq driver
> in the testsuite doesn't that imply that a patch adding net new functionality
> to libpq also need to add it to the driver in order to write the tests?  I'm
> thinking about the SCRAM situation a few years back when drivers weren't up to
> date.

As Jelte pointed out, new libpq functions can be tested via CFFI. I
posted a practical example in a link upthread (pure Python Psycopg is
entirely implemented on FFI).

-- Daniele