public inbox for [email protected]
help / color / mirror / Atom feedFrom: Paul A Jungwirth <[email protected]>
To: jian he <[email protected]>
Cc: SATYANARAYANA NARLAPURAM <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: Chao Li <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: SQL:2011 Application Time Update & Delete
Date: Wed, 22 Apr 2026 12:50:27 -0700
Message-ID: <CA+renyVUL52kYNTuO1e=wp8D8Ey9=xazfpSTrGJ0R48Ps=A-Jg@mail.gmail.com> (raw)
In-Reply-To: <CACJufxGtDyUNUnz7BnCWGdS4s1BErhbmD04wuAUKC-U-XSF36A@mail.gmail.com>
References: <[email protected]>
<[email protected]>
<CA+renyUazgR-hB_6RY60n23L0y-n_h9G1AappZmPENO0k5pL1g@mail.gmail.com>
<[email protected]>
<CA+renyVXg5pV84wQnGQuK8-=qoKw3BiBgQzesxM_LkcxxWmYjA@mail.gmail.com>
<[email protected]>
<CA+renyWKOj5=rMmQmJcbybu-Vdomxdp=eJ93kp76AgmQKYdfiQ@mail.gmail.com>
<[email protected]>
<CA+renyUhuXB2nTVCMREXew9E4DZOnFxQNjME5bcw91+k72Bosg@mail.gmail.com>
<CA+renyWUCSyTMn3s03kviEN-oaVrJP-QkDQCLNfaY=MHV5QEiQ@mail.gmail.com>
<CA+renyV4tWU2d=n9_v=XNPHbZfNqqLokzd-Xt78M-zLd+46ubA@mail.gmail.com>
<[email protected]>
<CA+renyUSgqXpjj+vV7w+wirPB49VQFrmPjVT_s04JmZSOPNNsQ@mail.gmail.com>
<[email protected]>
<CA+renyX-eV+2hFUaZg3BSREqLE7dh+LoWm7ZqhFAiGsirjjtRQ@mail.gmail.com>
<[email protected]>
<CAHg+QDckLFqthQyox2NDetYRs9sRrjmAiSA-gYRowyg8w_4vgw@mail.gmail.com>
<CAHg+QDd74fnd4obCRMqVS0AVWf=cSFH=Cv7trTJWgm+_bhTK6w@mail.gmail.com>
<CAHg+QDcVL2d4ih5zs2Mzh63ts41N+jtnMQTdZ2_0be6aF4aqYQ@mail.gmail.com>
<CACJufxEaD_DtByjv4CZg3yKg0n6hMPThfOmTr-D6JKY+v1BJDQ@mail.gmail.com>
<CA+renyW9o=-DBK6YO7a31xbr6xw7RFN_tSxTiUi2tSOQ2w5_zQ@mail.gmail.com>
<CACJufxGtDyUNUnz7BnCWGdS4s1BErhbmD04wuAUKC-U-XSF36A@mail.gmail.com>
On Mon, Apr 20, 2026 at 11:25 PM jian he <[email protected]> wrote:
>
> On Thu, Apr 16, 2026 at 7:26 AM Paul A Jungwirth
> <[email protected]> wrote:
> >
> > I think using INSTEAD OF triggers to replace an UPDATE/DELETE FOR
> > PORTION OF is a valid use-case, but it doesn't make sense to insert
> > temporal leftovers. As you say, we can't access the underlying
> > storage. But also we don't know what changes the trigger actually
> > made. The trigger should be responsible for leftovers, and we
> > shouldn't try to add more. So I think the fix is just to skip
> > inserting leftovers. I've attached a patch to do that.
> >
> hi.
>
> CREATE TABLE fpo_instead_base (id int, valid_at daterange, val int);
> INSERT INTO fpo_instead_base VALUES (1, '[2024-01-01,2024-12-31)', 100);
> CREATE VIEW fpo_instead_view AS SELECT * FROM fpo_instead_base;
> CREATE FUNCTION fpo_instead_trig_fn() RETURNS trigger LANGUAGE plpgsql AS $$
> BEGIN
> RETURN NEW;
> END;
> $$;
> CREATE TRIGGER fpo_instead_trig INSTEAD OF UPDATE ON fpo_instead_view
> FOR EACH ROW EXECUTE FUNCTION fpo_instead_trig_fn();
>
> UPDATE fpo_instead_view FOR PORTION OF valid_at FROM '2024-04-01' TO
> '2024-08-01'
> SET val = 999 WHERE id = 1
> RETURNING *;
>
> id | valid_at | val
> ----+-------------------------+-----
> 1 | [2024-01-01,2024-12-31) | 999
> (1 row)
>
> Should I expect the column `valid_at` value as [2024-04-01,2024-08-01) ?
Yes, because we ran an INSTEAD OF trigger and skipped the UPDATE
(including setting the start/end dates).
> We should also document this on doc/src/sgml/ref/update.sgml
> Attached is a minor regession test enhancement for
> "v2-0001-Fix-INSTEAD-OF-triggers-with-DELETE-UPDATE-FOR-PO.patch".
Thanks! I squashed those patches and did some minor cleanup. I posted
v4 to this dedicated thread:
https://www.postgresql.org/message-id/CA%2BrenyVenLk%2Bu%3DyGvDAyeFEuvkmeQx448-KnnGczqQHB10_fbg%40ma...
I also made a commitfest entry pointing there. Let's continue on that
thread so that future messages & patches get tracked correctly (and
not as part of the original feature's CF entry).
Hmm I forgot to add the documentation first. So I'll do that and post
a v5 shortly.
Yours,
--
Paul ~{:-)
[email protected]
view thread (54+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: SQL:2011 Application Time Update & Delete
In-Reply-To: <CA+renyVUL52kYNTuO1e=wp8D8Ey9=xazfpSTrGJ0R48Ps=A-Jg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox