MIME-Version: 1.0
References: <ec498c3d-5f2b-48ec-b989-5561c8aa2024@illuminatedcomputing.com>
 <85ac7f0e-d95f-4377-ade0-8941fd328012@eisentraut.org>
 <CA+renyUazgR-hB_6RY60n23L0y-n_h9G1AappZmPENO0k5pL1g@mail.gmail.com>
 <7d63ddfa-c735-4dfe-8c7a-4f1e2a621058@eisentraut.org>
 <CA+renyVXg5pV84wQnGQuK8-=qoKw3BiBgQzesxM_LkcxxWmYjA@mail.gmail.com>
 <e59d218a-ae49-490f-ae6f-86c12f35d3c3@eisentraut.org>
 <CA+renyWKOj5=rMmQmJcbybu-Vdomxdp=eJ93kp76AgmQKYdfiQ@mail.gmail.com>
 <4606deaa-7d65-4f22-8a78-356c3180be9d@eisentraut.org>
 <CA+renyUhuXB2nTVCMREXew9E4DZOnFxQNjME5bcw91+k72Bosg@mail.gmail.com>
 <CA+renyWUCSyTMn3s03kviEN-oaVrJP-QkDQCLNfaY=MHV5QEiQ@mail.gmail.com>
 <CA+renyV4tWU2d=n9_v=XNPHbZfNqqLokzd-Xt78M-zLd+46ubA@mail.gmail.com>
 <53f1c094-3c29-4ef6-a9bd-dc2e7894ceb0@eisentraut.org>
 <CA+renyUSgqXpjj+vV7w+wirPB49VQFrmPjVT_s04JmZSOPNNsQ@mail.gmail.com>
 <b2ecbf9f-797f-433d-953f-3c848cde5a1c@eisentraut.org>
 <CA+renyX-eV+2hFUaZg3BSREqLE7dh+LoWm7ZqhFAiGsirjjtRQ@mail.gmail.com>
 <e2fc32a4-319b-4176-8bd8-1d974e31376f@eisentraut.org>
 <4126231.1776622202@sss.pgh.pa.us>
In-Reply-To: <4126231.1776622202@sss.pgh.pa.us>
From: Paul A Jungwirth <pj@illuminatedcomputing.com>
Date: Sun, 19 Apr 2026 11:51:23 -0700
Message-ID: 
 <CA+renyVdyBcLzh2sFWUJ44A+N+7qL=f7rAyDOqFsTHTDb5q=SA@mail.gmail.com>
Subject: Re: SQL:2011 Application Time Update & Delete
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter@eisentraut.org>, Chao Li <li.evan.chao@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000d7263b064fd4abf6"
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2BrenyVdyBcLzh2sFWUJ44A%2BN%2B7qL%3Df7rAyDOqFsTHTDb5q%3DSA%40mail.gmail.com>
Precedence: bulk

--000000000000d7263b064fd4abf6
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, Apr 19, 2026 at 11:10=E2=80=AFAM Tom Lane <tgl@sss.pgh.pa.us> wrote=
:
>
> Peter Eisentraut <peter@eisentraut.org> writes:
> > I have committed the patches 0001 through 0003.
>
> Coverity is complaining that rsi.isDone may be used uninitialized in
> ExecForPortionOfLeftovers.  It's correct: that function is not obeying
> the function call protocol, and it's only accidental that it's not
> failing.  In ValuePerCall mode the caller is supposed to initialize
> isDone (and isnull too) before each call.  The canonical reference
> for this is execSRF.c, and it does that.  So I think we need something
> like the attached.

Thanks for the patch! Your changes look good to me.

> I notice that execSRF.c also runs pgstat_init_function_usage and
> pgstat_end_function_usage around each call.  That's not too important
> right now, but I wonder whether we should add it while we're looking
> at this.  It would perhaps be important once we support user-defined
> withoutPortionProcs.

I agree we should do that. Here is a patch with that added to your changes.

I was curious why execSRF.c uses `rsinfo.isDone !=3D ExprMultipleResult`
for the finalize parameter, because I don't think a SRF should ever
return ExprSingleResult, right? So I guess it is just to be cautious.
Makes sense. I followed that approach.

Yours,

--=20
Paul              ~{:-)
pj@illuminatedcomputing.com

--000000000000d7263b064fd4abf6
Content-Type: text/x-patch; charset="US-ASCII";
	name="v2-0001-Make-FOR-PORTION-OF-obey-SRF-protocol.patch"
Content-Disposition: attachment;
	filename="v2-0001-Make-FOR-PORTION-OF-obey-SRF-protocol.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mo64g1hq0>
X-Attachment-Id: f_mo64g1hq0

RnJvbSBlYmI1OGMxYWYzZWIyODBhYmVjOTg4ZDI1OGMzNDljYzkzNzdhZTY3IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiAiUGF1bCBBLiBKdW5nd2lydGgiIDxwakBpbGx1bWluYXRlZGNv
bXB1dGluZy5jb20+CkRhdGU6IFN1biwgMTkgQXByIDIwMjYgMTE6MzA6MTcgLTA3MDAKU3ViamVj
dDogW1BBVENIIHYyXSBNYWtlIEZPUiBQT1JUSU9OIE9GIG9iZXkgU1JGIHByb3RvY29sCgpUaGlz
IGZpeGVzIGEgQ292ZXJpdHkgZXJyb3IgYWJvdXQgcnNpLmlzRG9uZSBub3QgYmVpbmcgaW5pdGlh
bGl6ZWQuIFRoZSBidWlsdC1pbgp7bXVsdGksfXJhbmdlX21pbnVzX211bHRpIGZ1bmN0aW9ucyBk
b24ndCByZXR1cm4gd2l0aG91dCBzZXR0aW5nIGl0LCBidXQgYQp1c2VyLXN1cHBsaWVkIGZ1bmN0
aW9uIG1pZ2h0IG5vdCBiZSBhcyBhY2NvbW1vZGF0aW5nLgoKV2UgYWxzbyBhZGQgc3RhdGlzdGlj
cyB0cmFja2luZyBhcm91bmQgdGhlIGZ1bmN0aW9uIGNhbGwuCi0tLQogc3JjL2JhY2tlbmQvZXhl
Y3V0b3Ivbm9kZU1vZGlmeVRhYmxlLmMgfCAyMCArKysrKysrKysrKysrKysrKystLQogMSBmaWxl
IGNoYW5nZWQsIDE4IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEv
c3JjL2JhY2tlbmQvZXhlY3V0b3Ivbm9kZU1vZGlmeVRhYmxlLmMgYi9zcmMvYmFja2VuZC9leGVj
dXRvci9ub2RlTW9kaWZ5VGFibGUuYwppbmRleCBlZjJhNmJjNmU5ZC4uMzUzYTA1Y2FkZmYgMTAw
NjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL2V4ZWN1dG9yL25vZGVNb2RpZnlUYWJsZS5jCisrKyBiL3Ny
Yy9iYWNrZW5kL2V4ZWN1dG9yL25vZGVNb2RpZnlUYWJsZS5jCkBAIC02NSw2ICs2NSw3IEBACiAj
aW5jbHVkZSAibWlzY2FkbWluLmgiCiAjaW5jbHVkZSAibm9kZXMvbm9kZUZ1bmNzLmgiCiAjaW5j
bHVkZSAib3B0aW1pemVyL29wdGltaXplci5oIgorI2luY2x1ZGUgInBnc3RhdC5oIgogI2luY2x1
ZGUgInJld3JpdGUvcmV3cml0ZUhhbmRsZXIuaCIKICNpbmNsdWRlICJyZXdyaXRlL3Jld3JpdGVN
YW5pcC5oIgogI2luY2x1ZGUgInN0b3JhZ2UvbG1nci5oIgpAQCAtMTQxOSw2ICsxNDIwLDcgQEAg
RXhlY0ZvclBvcnRpb25PZkxlZnRvdmVycyhNb2RpZnlUYWJsZUNvbnRleHQgKmNvbnRleHQsCiAJ
Q21kVHlwZQkJb2xkT3BlcmF0aW9uOwogCVRyYW5zaXRpb25DYXB0dXJlU3RhdGUgKm9sZFRjczsK
IAlGbWdySW5mbwlmbGluZm87CisJUGdTdGF0X0Z1bmN0aW9uQ2FsbFVzYWdlIGZjdXNhZ2U7CiAJ
UmV0dXJuU2V0SW5mbyByc2k7CiAJYm9vbAkJZGlkSW5pdCA9IGZhbHNlOwogCWJvb2wJCXNob3Vs
ZEZyZWUgPSBmYWxzZTsKQEAgLTE1MTQsNiArMTUxNiw3IEBAIEV4ZWNGb3JQb3J0aW9uT2ZMZWZ0
b3ZlcnMoTW9kaWZ5VGFibGVDb250ZXh0ICpjb250ZXh0LAogCXJzaS5leHBlY3RlZERlc2MgPSBO
VUxMOwogCXJzaS5hbGxvd2VkTW9kZXMgPSAoaW50KSAoU0ZSTV9WYWx1ZVBlckNhbGwpOwogCXJz
aS5yZXR1cm5Nb2RlID0gU0ZSTV9WYWx1ZVBlckNhbGw7CisJLyogaXNEb25lIGlzIGZpbGxlZCBi
ZWxvdyAqLwogCXJzaS5zZXRSZXN1bHQgPSBOVUxMOwogCXJzaS5zZXREZXNjID0gTlVMTDsKIApA
QCAtMTUzNywxNCArMTU0MCwyNyBAQCBFeGVjRm9yUG9ydGlvbk9mTGVmdG92ZXJzKE1vZGlmeVRh
YmxlQ29udGV4dCAqY29udGV4dCwKIAkgKi8KIAl3aGlsZSAodHJ1ZSkKIAl7Ci0JCURhdHVtCQls
ZWZ0b3ZlciA9IEZ1bmN0aW9uQ2FsbEludm9rZShmY2luZm8pOworCQlEYXR1bQkJbGVmdG92ZXI7
CisKKwkJcGdzdGF0X2luaXRfZnVuY3Rpb25fdXNhZ2UoZmNpbmZvLCAmZmN1c2FnZSk7CisKKwkJ
LyogQ2FsbCB0aGUgZnVuY3Rpb24gb25lIHRpbWUgKi8KKwkJZmNpbmZvLT5pc251bGwgPSBmYWxz
ZTsKKwkJcnNpLmlzRG9uZSA9IEV4cHJTaW5nbGVSZXN1bHQ7CisJCWxlZnRvdmVyID0gRnVuY3Rp
b25DYWxsSW52b2tlKGZjaW5mbyk7CisKKwkJcGdzdGF0X2VuZF9mdW5jdGlvbl91c2FnZSgmZmN1
c2FnZSwKKwkJCQkJCQkJICByc2kuaXNEb25lICE9IEV4cHJNdWx0aXBsZVJlc3VsdCk7CisKKwkJ
aWYgKHJzaS5yZXR1cm5Nb2RlICE9IFNGUk1fVmFsdWVQZXJDYWxsKQorCQkJZWxvZyhFUlJPUiwg
IndpdGhvdXRfcG9ydGlvbiBmdW5jdGlvbiB2aW9sYXRlZCBmdW5jdGlvbiBjYWxsIHByb3RvY29s
Iik7CiAKIAkJLyogQXJlIHdlIGRvbmU/ICovCiAJCWlmIChyc2kuaXNEb25lID09IEV4cHJFbmRS
ZXN1bHQpCiAJCQlicmVhazsKIAogCQlpZiAoZmNpbmZvLT5pc251bGwpCi0JCQllbG9nKEVSUk9S
LCAiR290IGEgbnVsbCBmcm9tIHdpdGhvdXRfcG9ydGlvbiBmdW5jdGlvbiIpOworCQkJZWxvZyhF
UlJPUiwgImdvdCBhIG51bGwgZnJvbSB3aXRob3V0X3BvcnRpb24gZnVuY3Rpb24iKTsKIAogCQkv
KgogCQkgKiBEb2VzIHRoZSBuZXcgRGF0dW0gdmlvbGF0ZSBkb21haW4gY2hlY2tzPyBSb3ctbGV2
ZWwgQ0hFQ0sKLS0gCjIuNDcuMwoK
--000000000000d7263b064fd4abf6--