MIME-Version: 1.0
References: 
 <CACJufxHs1Hs00EqsZ4NbuAjmYzMzjJyP1sAj12Ne=cBsEVmQOA@mail.gmail.com>
 <CALdSSPiRHCyC0fYy_E=gO+c7sbwU=7=Fz2CF-4aEa3mAe7yYAg@mail.gmail.com>
 <CACJufxGjgdWnhq5X5VL9orLXyKx-ZayT_Zj_-bAKr=kf0pZ_Nw@mail.gmail.com>
 <CA+renyXkcs=5P3dd=OoyM+A=UKA7iR_zS4TAQ42F9NTv+2RNiA@mail.gmail.com>
 <CACJufxFSTwzJxFYwD5mb5hSj9CvZxBh500Sza0CKoFCxB6iLsg@mail.gmail.com>
In-Reply-To: 
 <CACJufxFSTwzJxFYwD5mb5hSj9CvZxBh500Sza0CKoFCxB6iLsg@mail.gmail.com>
From: Paul A Jungwirth <pj@illuminatedcomputing.com>
Date: Sun, 19 Apr 2026 11:07:47 -0700
Message-ID: 
 <CA+renyVv5+_R=VViLfqN_E5HzwakDRiX=ZXH7AoDD3FB7+348w@mail.gmail.com>
Subject: Re: DELETE/UPDATE FOR PORTION OF with rule system is not working
To: jian he <jian.universality@gmail.com>
Cc: Kirill Reshke <reshkekirill@gmail.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>,
 Peter Eisentraut <peter@eisentraut.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2BrenyVv5%2B_R%3DVViLfqN_E5HzwakDRiX%3DZXH7AoDD3FB7%2B348w%40mail.gmail.com>
Precedence: bulk

On Thu, Apr 16, 2026 at 8:20=E2=80=AFPM jian he <jian.universality@gmail.co=
m> wrote:
>
> On Thu, Apr 16, 2026 at 6:40=E2=80=AFAM Paul A Jungwirth
> <pj@illuminatedcomputing.com> wrote:
> >
> > I only have two small suggestions:
> >
> > Please use '[1, 11)' syntax to match the other tests.
> >
> > Breaking these long lines would be nice. For example:
> >
> > +CREATE RULE fpo_rule1 AS ON INSERT TO fpo_rule
> > +  DO INSTEAD UPDATE fpo_rule FOR PORTION OF f2 FROM 1 TO 4 SET f1 =3D =
2;
> >
> Please check the attached v2.
>
> V1 only has DO INSTEAD rules, adding one DO ALSO rule would make the
> test coverage more robust.

Thanks for those changes. This looks great to me!

Yours,

--=20
Paul              ~{:-)
pj@illuminatedcomputing.com