MIME-Version: 1.0
References: 
 <CA+v5N40sJF39m0v7h=QN86zGp0CUf9F1WKasnZy9nNVj_VhCZQ@mail.gmail.com>
 <145894.1727298237@sss.pgh.pa.us>
 <CAPpHfdtGhn_5jfLoepOScyqT+FXYB9QtV-OEprychDcMJco7mw@mail.gmail.com>
 <CA+v5N42PVJH3HbwLE1yC75XR6E5zGnCCdtSUXfgFwtGyPP8XYg@mail.gmail.com>
 <CA+Tgmob03B6h1SMsi7vs9uOX+vrqg_tyhh--mKC3BaTJ08qKYA@mail.gmail.com>
 <7e9debe6-4e96-4b0d-a801-b531e962ef43@eisentraut.org>
 <01DC1C38-0692-461B-AA63-5394330356BE@gmail.com>
 <2568904.1748022721@sss.pgh.pa.us>
 <D57D3B5E-AF55-4F7F-9E55-FE06EE8ED811@justatheory.com>
 <40912112-7FFE-400F-A38F-368827C4BDF1@gmail.com>
 <D201EEF7-8681-458E-B287-7B8F058DC712@justatheory.com>
 <176C517D-2DEB-4CAB-9AE4-261079D313B9@justatheory.com>
 <8FD5F4CF-9059-40C1-9F0A-C3CBA8DFE17A@justatheory.com>
 <C54B0664-34F5-46E2-9094-5798E68A2A3F@justatheory.com>
 <696ECBBC-3CBF-4522-AE66-E48225688E93@gmail.com>
 <59C63857-406D-4704-A1EB-9BF3AA639C86@justatheory.com>
 <06FA8975-2E21-46A5-B510-028B3B967EB2@justatheory.com>
 <2F58E05D-D319-4CD3-8805-E1A8A2482A1A@justatheory.com>
 <4A96ACDB-78A1-4434-8C25-7C9716A7D421@justatheory.com>
 <A7D78196-E287-4716-8507-BE09C6DE3C82@justatheory.com>
 <4904EA5B-C6CA-42BD-BF08-C89325240C9D@gmail.com>
 <84727E10-62B7-4FE4-B487-E7044C7C0A1F@justatheory.com>
 <6CD16A54-BFEE-4CB5-84AC-F3B46289FA6D@justatheory.com>
 <D3137F93-B6CA-45D0-BF9A-43ED5DF7859B@justatheory.com>
 <7D19A273-1306-4F4C-9DFD-CE16F44790CB@justatheory.com>
In-Reply-To: <7D19A273-1306-4F4C-9DFD-CE16F44790CB@justatheory.com>
From: Florents Tselai <florents.tselai@gmail.com>
Date: Sat, 12 Jul 2025 07:07:08 +0300
Message-ID: 
 <CA+v5N40+gPfir3ShsA53SLWeQa5eMy7Bm3vnOKLa5YLNEwZO7w@mail.gmail.com>
Subject: Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim,
 replace, split_part
To: "David E. Wheeler" <david@justatheory.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Peter Eisentraut <peter@eisentraut.org>,
	Robert Haas <robertmhaas@gmail.com>,
 Alexander Korotkov <aekorotkov@gmail.com>,
	pgsql-hackers <pgsql-hackers@lists.postgresql.org>,
 Andrew Dunstan <andrew@dunslane.net>
Content-Type: multipart/alternative; boundary="000000000000af53540639b3911f"
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2Bv5N40%2BgPfir3ShsA53SLWeQa5eMy7Bm3vnOKLa5YLNEwZO7w%40mail.gmail.com>
Precedence: bulk

--000000000000af53540639b3911f
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Jul 11, 2025 at 9:48=E2=80=AFPM David E. Wheeler <david@justatheory=
.com>
wrote:

> On Jul 10, 2025, at 19:23, David E. Wheeler <david@justatheory.com> wrote=
:
>
> > Now with the `ISO C90 forbids mixed declarations and code` warning
> cleared up.
> >
> > Weird that there=E2=80=99s a failure on Bookworm with Meson [1] (pg_reg=
ress
> diffs [2]) but not Bookworm with Configure [3]. Collation issue, perhaps?
>
> David Johnson noticed that this build is 32-bit. I looked at the
> split_path function and after trying a couple of things, realized that it
> was passing an int8 when the SQL function in Marlena.c passes an int4. Th=
is
> change got the test passing in my clone (indentation reduced):


Occasionally I've noticed myself some inconsistencies wrt to compiler
warnings between meson & make .
But cirrus seems generally happy now
https://cirrus-ci.com/build/4964687915253760

To recap so far;

- I like your changes and renames on the parser/lexer; it indeed looks much
cleaner now and will help with future improvements.
- I also like the addition of executeStringInternalMethod ; it'll help us
add more stuff in the future (reminder that for the original patch I
implemented the methods I'd like more, but string operations are quite
more).

- AFAICT no test cases / results have changed with your versions; is this
correct ?

--000000000000af53540639b3911f
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><div><br></div></div><div class=3D"gmail_=
quote gmail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Fri, =
Jul 11, 2025 at 9:48=E2=80=AFPM David E. Wheeler &lt;<a href=3D"mailto:davi=
d@justatheory.com">david@justatheory.com</a>&gt; wrote:<br></div><blockquot=
e class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left-width=
:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-lef=
t:1ex">On Jul 10, 2025, at 19:23, David E. Wheeler &lt;<a href=3D"mailto:da=
vid@justatheory.com" target=3D"_blank">david@justatheory.com</a>&gt; wrote:=
<br>
<br>
&gt; Now with the `ISO C90 forbids mixed declarations and code` warning cle=
ared up.<br>
&gt; <br>
&gt; Weird that there=E2=80=99s a failure on Bookworm with Meson [1] (pg_re=
gress diffs [2]) but not Bookworm with Configure [3]. Collation issue, perh=
aps?<br>
<br>
David Johnson noticed that this build is 32-bit. I looked at the split_path=
 function and after trying a couple of things, realized that it was passing=
 an int8 when the SQL function in Marlena.c passes an int4. This change got=
 the test passing in my clone (indentation reduced):</blockquote><div><br><=
/div><div>Occasionally I&#39;ve noticed myself some inconsistencies wrt to =
compiler warnings between meson &amp; make .=C2=A0</div><div>But cirrus see=
ms generally happy now=C2=A0<a href=3D"https://cirrus-ci.com/build/49646879=
15253760">https://cirrus-ci.com/build/4964687915253760</a>=C2=A0</div><div>=
<br></div><div>To recap so far;=C2=A0</div><div><br></div><div>- I like you=
r changes and renames on the parser/lexer; it indeed looks much cleaner now=
 and will help with future improvements.</div><div>- I also like the additi=
on of=C2=A0executeStringInternalMethod ; it&#39;ll help us add more stuff i=
n the future (reminder that for the original patch I implemented the method=
s I&#39;d like more, but string operations are quite more).</div><div><br><=
/div><div>- AFAICT no test cases / results have changed with your versions;=
 is this correct ?</div><div><br></div></div></div>

--000000000000af53540639b3911f--