MIME-Version: 1.0
References: <202510210803.3b3vfvygxtjl@alvherre.pgsql>
 <3DC56A6A-9525-4C05-B45A-9A135A66BC34@justatheory.com>
 <CACJufxGAmcwq33nr_MmgnGdGo7E10c55kCA22DQ4n9FBUOZmTA@mail.gmail.com>
 <A654130B-16AF-4E37-9D73-B3CDC80C751C@justatheory.com>
 <CACJufxEphbmEWLKzYNfzsyEB5+bkbMAMUHJq2LxpDdcSZn98BA@mail.gmail.com>
 <CACJufxGdgxyRLd03wM=GtJzUskXnXxEBGGtwA2vsTvkV827SxA@mail.gmail.com>
 <CACJufxHxWKhNcTsmYz428yxUikeUVZz=o6mLNRXpB7F_1oDEng@mail.gmail.com>
 <CECA8C06-755C-4550-88C8-0E1E0CB03D64@justatheory.com>
 <DB26FD47-DF09-4A92-AA15-08F012ED0DE2@justatheory.com>
 <CA+v5N40aRmC3DYzWDxTbQKMKohkTdMZJ92Nuaj_NniKS7RHpEA@mail.gmail.com>
 <931F201B-FF38-486E-BDEE-DF9692A01E1D@justatheory.com>
 <D81098C5-CB6D-47BE-995B-A451BE396525@justatheory.com>
 <1eb15091-660d-477b-acda-b61d00bc9ffb@dunslane.net>
 <278cb771-6008-44e5-8eaa-9d4acdb56c79@dunslane.net>
 <9E9B3C10-7535-4704-A04A-DF5D32C43DBE@justatheory.com>
 <b3c965ea-89c1-4ef1-a2a9-29854345f96d@dunslane.net>
 <34758556-D3D0-42C3-9A1B-CBF64336ADBC@justatheory.com>
 <88a392fd-d732-45a7-bcfc-291258849fbe@dunslane.net>
In-Reply-To: <88a392fd-d732-45a7-bcfc-291258849fbe@dunslane.net>
From: Florents Tselai <florents.tselai@gmail.com>
Date: Thu, 2 Apr 2026 22:57:28 +0300
Message-ID: 
 <CA+v5N40v=o=ybDcnmYANY535zBa_5CV-yCoFaOShgjU-dq9=zg@mail.gmail.com>
Subject: Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim,
 replace, split_part
To: Andrew Dunstan <andrew@dunslane.net>
Cc: "David E. Wheeler" <david@justatheory.com>,
	pgsql-hackers <pgsql-hackers@lists.postgresql.org>,
 Chao Li <li.evan.chao@gmail.com>,
	=?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>,
	Tom Lane <tgl@sss.pgh.pa.us>, Peter Eisentraut <peter@eisentraut.org>,
	Robert Haas <robertmhaas@gmail.com>,
 Alexander Korotkov <aekorotkov@gmail.com>,
	jian he <jian.universality@gmail.com>
Content-Type: multipart/alternative; boundary="00000000000066f4a9064e7f9e0a"
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2Bv5N40v%3Do%3DybDcnmYANY535zBa_5CV-yCoFaOShgjU-dq9%3Dzg%40mail.gmail.com>
Precedence: bulk

--00000000000066f4a9064e7f9e0a
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Apr 2, 2026 at 10:21=E2=80=AFPM Andrew Dunstan <andrew@dunslane.net=
> wrote:

>
> On 2026-03-28 Sa 11:58 AM, David E. Wheeler wrote:
>
> On Mar 28, 2026, at 11:02, Andrew Dunstan <andrew@dunslane.net> <andrew@d=
unslane.net> wrote:
>
>
> The key_name production is what allows a keyword to also be used as an ob=
ject key in $.keyname syntax. The trim keywords (ltrim, rtrim, btrim) were =
added there, so $.ltrim as a key works. But $.lower,
> $.upper, $.initcap, $.replace, and $.split_part as keys would all break.
>
> Ooh, right. It has been so long since I looked at this stuff that I forgo=
t. Thanks for the reminder.
>
>
> There are tests added for it.
>
> And for this!
>
>
>
>
> Committed.
>
Boom! Thanks so much for this.

--00000000000066f4a9064e7f9e0a
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><div><br></div><div><div dir=3D"ltr" clas=
s=3D"gmail_signature"><div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr"><d=
iv dir=3D"ltr"><p style=3D"font-size:12.8px;line-height:1.38;margin-top:0pt=
;margin-bottom:0pt"></p></div></div></div></div></div></div><br></div><br><=
div class=3D"gmail_quote gmail_quote_container"><div dir=3D"ltr" class=3D"g=
mail_attr">On Thu, Apr 2, 2026 at 10:21=E2=80=AFPM Andrew Dunstan &lt;<a hr=
ef=3D"mailto:andrew@dunslane.net">andrew@dunslane.net</a>&gt; wrote:<br></d=
iv><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;bord=
er-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204=
);padding-left:1ex"><u></u>

 =20
   =20
 =20
  <div>
    <p><br>
    </p>
    <div>On 2026-03-28 Sa 11:58 AM, David E.
      Wheeler wrote:<br>
    </div>
    <blockquote type=3D"cite">
      <pre>On Mar 28, 2026, at 11:02, Andrew Dunstan <a href=3D"mailto:andr=
ew@dunslane.net" target=3D"_blank">&lt;andrew@dunslane.net&gt;</a> wrote:

</pre>
      <blockquote type=3D"cite">
        <pre>The key_name production is what allows a keyword to also be us=
ed as an object key in $.keyname syntax. The trim keywords (ltrim, rtrim, b=
trim) were added there, so $.ltrim as a key works. But $.lower,
$.upper, $.initcap, $.replace, and $.split_part as keys would all break.
</pre>
      </blockquote>
      <pre>Ooh, right. It has been so long since I looked at this stuff tha=
t I forgot. Thanks for the reminder.

</pre>
      <blockquote type=3D"cite">
        <pre>There are tests added for it.
</pre>
      </blockquote>
      <pre>And for this!

</pre>
    </blockquote>
    <p><br>
    </p>
    <p><br>
    </p>
    <p>Committed.</p></div></blockquote><div>Boom! Thanks so much for this.=
 =C2=A0<br></div></div></div>

--00000000000066f4a9064e7f9e0a--