Feedback-ID: i675e48f3:Fastmail
Date: Tue, 16 Sep 2025 08:55:59 -0400
From: Greg Burd <greg@burd.me>
To: Robert Haas <robertmhaas@gmail.com>, Michael Paquier
 <michael@paquier.xyz>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Nathan
 Bossart <nathandbossart@gmail.com>, Masahiko Sawada
 <sawada.mshk@gmail.com>
Message-ID: <CA0C373A-6857-4C4C-BF67-5C72AABA0E0D@greg.burd.me>
In-Reply-To: 
 <CA+TgmobduQcEntxF=SgsA3xZ-BPxL6BhgOSHY50SS34isPac1Q@mail.gmail.com>
References: 
 <CA+TgmobduQcEntxF=SgsA3xZ-BPxL6BhgOSHY50SS34isPac1Q@mail.gmail.com>
Subject: Re: [PATCH] Add tests for Bitmapset
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Archived-At: 
 <https://www.postgresql.org/message-id/CA0C373A-6857-4C4C-BF67-5C72AABA0E0D%40greg.burd.me>
Precedence: bulk


On Sep 16 2025, at 8:02 am, Robert Haas <robertmhaas=40gmail.com> wrote:

> On Tue, Sep 16, 2025 at 2:04=E2=80=AFAM Michael Paquier <michael=40paqu=
ier.xyz> wrote:
>> one SQL function mapping to each C function we are testing=3F
> =20
> Yes, I think we should do this, if possible.

Michael, Robert,

Thanks for your time reviewing the proposed code and for providing
feedback. This patch started life as simply copy of the test=5Fradixtree
module which uses a single test function triggered in SQL, hence my
approach.  I guess I should have copied the test=5Fslru module instead=21=
 :)

I see the value in the idea of splitting it up into separate functions
and I'll give that a try.

Michael, apologies for the white space issues.  I'll clean that up, and
thank you for the =60git diff --check=60 tip, I'll add that to my toolbox=
/routine.

> -- =20
> Robert Haas
> EDB: http://www.enterprisedb.com

best.

-greg