public inbox for [email protected]
help / color / mirror / Atom feedFrom: Thom Brown <[email protected]>
To: Alvaro Herrera <[email protected]>
Cc: Dilip Kumar <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: Amul Sul <[email protected]>
Cc: Matthias van de Meent <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: generalized conveyor belt storage
Date: Wed, 20 Apr 2022 13:32:01 +0100
Message-ID: <CAA-aLv4993dAV_B5qwQW8QNbpVXHNHH8S8pdSXnhkr_j0M-THA@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAFiTN-sQUddO9JPiH3tz+vbNqRqi_pgndecy8k2yXAnO3ymqZA@mail.gmail.com>
<[email protected]>
On Wed, 20 Apr 2022 at 13:02, Alvaro Herrera <[email protected]> wrote:
>
> What's with the free text in cbstorage.h? I would guess that this
> wouldn't even compile, and nobody has noticed because the file is not
> included by anything yet ...
I'm not able to compile:
cbfsmpage.c: In function ‘cb_fsmpage_initialize’:
cbfsmpage.c:34:11: warning: unused variable ‘fsm_block_spacing’
[-Wunused-variable]
unsigned fsm_block_spacing = cb_fsm_block_spacing(pages_per_segment);
^
cbfsmpage.c:33:14: warning: unused variable ‘first_fsm_block’
[-Wunused-variable]
BlockNumber first_fsm_block = cb_first_fsm_block(pages_per_segment);
...
cbxlog.c: In function ‘cb_xlog_allocate_payload_segment’:
cbxlog.c:70:24: error: void value not ignored as it ought to be
bool have_fsm_page = XLogRecGetBlockTag(record, 1, NULL, NULL, NULL);
^
cbxlog.c: In function ‘cb_xlog_allocate_index_segment’:
cbxlog.c:123:17: error: void value not ignored as it ought to be
have_prev_page = XLogRecGetBlockTag(record, 2, NULL, NULL, NULL);
^
cbxlog.c:124:16: error: void value not ignored as it ought to be
have_fsm_page = XLogRecGetBlockTag(record, 3, NULL, NULL, NULL);
^
cbxlog.c: In function ‘cb_xlog_recycle_payload_segment’:
cbxlog.c:311:16: error: void value not ignored as it ought to be
have_metapage = XLogRecGetBlockTag(record, 0, NULL, NULL, NULL);
^
cbxlog.c:312:18: error: void value not ignored as it ought to be
have_index_page = XLogRecGetBlockTag(record, 1, NULL, NULL, NULL);
^
cbxlog.c:313:16: error: void value not ignored as it ought to be
have_fsm_page = XLogRecGetBlockTag(record, 2, NULL, NULL, NULL);
^
make[4]: *** [cbxlog.o] Error 1
make[4]: Leaving directory
`/home/thom/Development/postgresql/src/backend/access/conveyor'
make[3]: *** [conveyor-recursive] Error 2
make[3]: Leaving directory
`/home/thom/Development/postgresql/src/backend/access'
make[2]: *** [access-recursive] Error 2
--
Thom
view thread (8+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: generalized conveyor belt storage
In-Reply-To: <CAA-aLv4993dAV_B5qwQW8QNbpVXHNHH8S8pdSXnhkr_j0M-THA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox