MIME-Version: 1.0
References: 
 <CAHGQGwELJkyH+JH6j=rxgNhs_EA8+49kj65YbH85x-QG79qWyg@mail.gmail.com>
 <agRwcVpUe_bJlHd7@alvherre.pgsql>
 <CAHGQGwGAY4kfDtC4i+hAOX-a3u0yOA6__6EDTQz-ytsDHgh-yQ@mail.gmail.com>
In-Reply-To: 
 <CAHGQGwGAY4kfDtC4i+hAOX-a3u0yOA6__6EDTQz-ytsDHgh-yQ@mail.gmail.com>
From: Thom Brown <thom@linux.com>
Date: Mon, 18 May 2026 12:04:18 +0100
Message-ID: 
 <CAA-aLv79Gs3daW-=+invvemr5nxBzHm9Kn=DAC21qj8YWvQ1pw@mail.gmail.com>
Subject: Re: [PATCH] Fix psql tab completion for REPACK boolean options
To: Fujii Masao <masao.fujii@gmail.com>
Cc: =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>,
	Baji Shaik <baji.pgdev@gmail.com>, pgsql-hackers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAA-aLv79Gs3daW-%3D%2Binvvemr5nxBzHm9Kn%3DDAC21qj8YWvQ1pw%40mail.gmail.com>
Precedence: bulk

On Fri, 15 May 2026 at 10:36, Fujii Masao <masao.fujii@gmail.com> wrote:
>
> On Wed, May 13, 2026 at 9:46=E2=80=AFPM =C3=81lvaro Herrera <alvherre@kur=
ilemu.de> wrote:
> > > Thanks for the patch! It looks good to me.
> > > Unless there are objections, I will commit it.
> >
> > Yeah, looks good to me, thanks.
>
> I've pushed the patch. Thanks!
>
> > Fine with me.  I wouldn't have a problem saying it's a backpatchable
> > bugfix, but it's certainly not very high priority or criticality.
>
> Agreed.
>
>
> BTW, while testing REPACK boolean options, I found two other issues
> in their parsing.
>
> First, REPACK (CONCURRENTLY OFF) failed with:
>
>     ERROR:  unrecognized REPACK option "concurrently"
>
> even though REPACK (CONCURRENTLY ON) works correctly. That is,
> CONCURRENTLY was treated as an unrecognized option when disabled.
>
> Second, when the same option is specified multiple times, the last value
> is not always honored. In particular, if any occurrence sets an option to=
 ON,
> the option remains enabled even when the final setting is OFF.
>
> I think these are bugs, and the attached patch fixes them. Thoughts?

I saw this just got committed. Is there a reason the option handling
for this, VACUUM, and EXPLAIN aren't done in one place?

Thom