MIME-Version: 1.0
References: <ad7ngXC125AvNqC2@momjian.us>
 <CAH2-Wzm1UAuv9ih6_ATbwbmrmusKPoJ2qSo3HBF-JaUEkVYUPg@mail.gmail.com>
 <agdXjNmH9h_aMskl@momjian.us>
 <CC2712F9-8457-4733-AA9D-7D7C9843B590@gmail.com>
 <ahW1hVEIdCzVdklh@momjian.us>
In-Reply-To: <ahW1hVEIdCzVdklh@momjian.us>
From: Thom Brown <thom@linux.com>
Date: Tue, 26 May 2026 16:46:12 +0100
Message-ID: 
 <CAA-aLv7w1wwucet76yAW0yq3-LrN5wL81uRrnpT3Tyxh7dmyTw@mail.gmail.com>
Subject: Re: First draft of PG 19 release notes
To: Bruce Momjian <bruce@momjian.us>
Cc: Chao Li <li.evan.chao@gmail.com>, Peter Geoghegan <pg@bowt.ie>,
	PostgreSQL-development <pgsql-hackers@lists.postgresql.org>,
 chong.peng@enmotech.com
Content-Type: multipart/mixed; boundary="000000000000aff54f0652ba6654"
Archived-At: 
 <https://www.postgresql.org/message-id/CAA-aLv7w1wwucet76yAW0yq3-LrN5wL81uRrnpT3Tyxh7dmyTw%40mail.gmail.com>
Precedence: bulk

--000000000000aff54f0652ba6654
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, 26 May 2026 at 16:00, Bruce Momjian <bruce@momjian.us> wrote:
>
> On Tue, May 26, 2026 at 01:25:15PM +0800, Chao Li wrote:
> > Chong Peng, whom I added to CC, reported this release note issue to me,=
 so I=E2=80=99m just forwarding the message:
> >
> > ```
> > <listitem>
> > <para>
> > Add slot synchronization skip information to pg_stat_replication_slots =
(Shlok Kyal)
> > <ulink url=3D"&commit_baseurl;76b78721c">&sect;</ulink>
> > <ulink url=3D"&commit_baseurl;e68b6adad">&sect;</ulink>
> > <ulink url=3D"&commit_baseurl;5db6a344a">&sect;</ulink>
> > </para>
> >
> > <para>
> > The new columns are slotsync_skip_count, slotsync_last_skip, and slotsy=
nc_skip_reason.
> > </para>
> > </listitem>
> > ```
> >
> > The feature description is inaccurate: slotsync_skip_count and slotsync=
_last_skip belong to pg_stat_replication_slots, while slotsync_skip_reason =
belongs to pg_replication_slots. Maybe it could be reworded as:
> > ```
> > Add slot synchronization skip information to pg_stat_replication_slots =
and pg_replication_slots (Shlok Kyal)
> > ```
>
> Yes, very good point.  I missed that detail when merging the commit
> items.  I fixed it as you suggested, patch attached.
>
> --
>   Bruce Momjian  <bruce@momjian.us>        https://momjian.us
>   EDB                                      https://enterprisedb.com
>
>   Do not let urgent matters crowd out time for investment in the future.

Did a review and found a few issues. Attached fixes.

Regards

Thom

--000000000000aff54f0652ba6654
Content-Type: text/x-patch; charset="US-ASCII"; name="release-19-fixes.patch"
Content-Disposition: attachment; filename="release-19-fixes.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mpmt27m70>
X-Attachment-Id: f_mpmt27m70

ZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9yZWxlYXNlLTE5LnNnbWwgYi9kb2Mvc3JjL3NnbWwv
cmVsZWFzZS0xOS5zZ21sCmluZGV4IGYwOTExYjg2MDA1Li45YWFlOTM0MjE1YSAxMDA2NDQKLS0t
IGEvZG9jL3NyYy9zZ21sL3JlbGVhc2UtMTkuc2dtbAorKysgYi9kb2Mvc3JjL3NnbWwvcmVsZWFz
ZS0xOS5zZ21sCkBAIC03Nyw3ICs3Nyw3IEBAIElzc3VlIGEgd2FybmluZyBhZnRlciBzdWNjZXNz
ZnVsIE1ENSBwYXNzd29yZCBhdXRoZW50aWNhdGlvbiAoTmF0aGFuIEJvc3NhcnQpCiA8L3BhcmE+
CiAKIDxwYXJhPgotVGhlIHdhcm5pbmcgY2FuIGJlIGRpc2FibGVkIHZpYSBzZXJ2ZXIgdmFyaWFi
bGUgbWQ1X3Bhc3N3b3JkX3dhcm5pbmdzLiAgTUQ1IHBhc3N3b3JkcyB3ZXJlIG1hcmtlZCBtYXJr
ZWQgYXMgZGVwcmVjYXRlZCBpbiBQb3N0Z3JlcyAxOC4KK1RoZSB3YXJuaW5nIGNhbiBiZSBkaXNh
YmxlZCB2aWEgc2VydmVyIHZhcmlhYmxlIG1kNV9wYXNzd29yZF93YXJuaW5ncy4gIE1ENSBwYXNz
d29yZHMgd2VyZSBtYXJrZWQgYXMgZGVwcmVjYXRlZCBpbiBQb3N0Z3JlcyAxOC4KIDwvcGFyYT4K
IDwvbGlzdGl0ZW0+CiAKQEAgLTE0NCw3ICsxNDQsNyBAQCBDaGFuZ2UgdGhlIGRlZmF1bHQgaW5k
ZXggb3BjbGFzc2VzIGZvciBpbmV0IGFuZCBjaWRyIGRhdGEgdHlwZXMgZnJvbSBidHJlZV9naXN0
CiA8L3BhcmE+CiAKIDxwYXJhPgotVGhlIGJ0cmVlX2dpc3QgaW5ldC9jaWRyIG9wY2xhc3NlcyBh
cmUgYnJva2VuIGJlY2F1c2UgdGhleSBjYW4gZXhjbHVkZSByb3dzIHRoYXQgc2hvdWxkIGJlIHJl
dHVybmVkLiAgUGdfdXBncmFkZSB3aWxsIGZhaWwgdG8gdXBncmFkZSBpZiBidHJlZV9naXN0IGlu
ZXQvY2lkciBpbmRleGVzIGV4aXN0IGluIHRoZSBvbGQKK1RoZSBidHJlZV9naXN0IGluZXQvY2lk
ciBvcGNsYXNzZXMgYXJlIGJyb2tlbiBiZWNhdXNlIHRoZXkgY2FuIGV4Y2x1ZGUgcm93cyB0aGF0
IHNob3VsZCBiZSByZXR1cm5lZC4gIHBnX3VwZ3JhZGUgd2lsbCBmYWlsIHRvIHVwZ3JhZGUgaWYg
YnRyZWVfZ2lzdCBpbmV0L2NpZHIgaW5kZXhlcyBleGlzdCBpbiB0aGUgb2xkCiBzZXJ2ZXIuCiA8
L3BhcmE+CiA8L2xpc3RpdGVtPgpAQCAtMzI4LDcgKzMyOCw3IEBAIEF1dGhvcjogUmljaGFyZCBH
dW8gPHJndW9AcG9zdGdyZXNxbC5vcmc+CiAKIDxsaXN0aXRlbT4KIDxwYXJhPgotQWxsb3cgTk9U
IElOcyB0byBiZSBjb252ZXJ0ZWQgdG8gbW9yZSBlZmZpY2llbnQgQU5USSBKT0lOcyB3aGVuIE5V
TExzIGFyZSBub3QgcHJlc2VudCAoUmljaGFyZCBHdW8pCitBbGxvdyBOT1QgSU4gY2xhdXNlcyB0
byBiZSBjb252ZXJ0ZWQgdG8gbW9yZSBlZmZpY2llbnQgYW50aS1qb2lucyB3aGVuIE5VTExzIGFy
ZSBub3QgcHJlc2VudCAoUmljaGFyZCBHdW8pCiA8dWxpbmsgdXJsPSImY29tbWl0X2Jhc2V1cmw7
MzgzZWIyMWViIj4mc2VjdDs8L3VsaW5rPgogPC9wYXJhPgogPC9saXN0aXRlbT4KQEAgLTcwMCw3
ICs3MDAsNyBAQCBBdXRob3I6IE5hdGhhbiBCb3NzYXJ0IDxuYXRoYW5AcG9zdGdyZXNxbC5vcmc+
CiAKIDxsaXN0aXRlbT4KIDxwYXJhPgotSW1wcm92ZSBDT1BZIEZST00gcGVyZm9ybWFuY2UgZm9y
IHRleHQgYW5kIENTViBvdXRwdXQgdXNpbmcgU0lNRCBDUFUgaW5zdHJ1Y3Rpb25zIChOYXppciBC
aWxhbCBZYXZ1eiwgU2hpbnlhIEthdG8pCitJbXByb3ZlIENPUFkgRlJPTSBwZXJmb3JtYW5jZSBm
b3IgdGV4dCBhbmQgQ1NWIGlucHV0IHVzaW5nIFNJTUQgQ1BVIGluc3RydWN0aW9ucyAoTmF6aXIg
QmlsYWwgWWF2dXosIFNoaW55YSBLYXRvKQogPHVsaW5rIHVybD0iJmNvbW1pdF9iYXNldXJsO2Uw
YTNhM2ZkNSI+JnNlY3Q7PC91bGluaz4KIDwvcGFyYT4KIDwvbGlzdGl0ZW0+CkBAIC0xMjEwLDcg
KzEyMTAsNyBAQCBBdXRob3I6IE5hdGhhbiBCb3NzYXJ0IDxuYXRoYW5AcG9zdGdyZXNxbC5vcmc+
CiAKIDxsaXN0aXRlbT4KIDxwYXJhPgotSXNzdWUgd2FybmluZ3Mgd2hlbiB0aGUgd3JhcGFyb3Vu
ZCBvZiB4aWQgYW5kIG11bHRpLXhpZHMgaXMgbGVzcyB0aGVuIDEwMCBtaWxsaW9uIChOYXRoYW4g
Qm9zc2FydCkKK0lzc3VlIHdhcm5pbmdzIHdoZW4gdGhlIHdyYXBhcm91bmQgb2YgeGlkIGFuZCBt
dWx0aS14aWRzIGlzIGxlc3MgdGhhbiAxMDAgbWlsbGlvbiAoTmF0aGFuIEJvc3NhcnQpCiA8dWxp
bmsgdXJsPSImY29tbWl0X2Jhc2V1cmw7NDhmMTFiZmEwIj4mc2VjdDs8L3VsaW5rPgogPC9wYXJh
PgogCkBAIC0xNTg4LDcgKzE1ODgsNyBAQCBBZGQgc3Vic2NyaXB0aW9uIG9wdGlvbiBtYXhfcmV0
ZW50aW9uX2R1cmF0aW9uIHRvIGxpbWl0IHJldGFpbl9kZWFkX3R1cGxlcyByZXRlbgogPC9wYXJh
PgogCiA8cGFyYT4KLVdoZW4gdGhlIGxpbWl0IGlzIHJlYWNoZWQsIGRlYWQgdHVwbGUgcmV0ZW50
aW9uIHVudGlsIG1hbnVhbGx5IHJlLWVuYWJsZWQgb3IgYSBuZXcgc3Vic2NyaXB0aW9uIGlzIGNy
ZWF0ZWQuCitXaGVuIHRoZSBsaW1pdCBpcyByZWFjaGVkLCBkZWFkIHR1cGxlIHJldGVudGlvbiBp
cyBkaXNhYmxlZCB1bnRpbCBtYW51YWxseSByZS1lbmFibGVkIG9yIGEgbmV3IHN1YnNjcmlwdGlv
biBpcyBjcmVhdGVkLgogPC9wYXJhPgogPC9saXN0aXRlbT4KIAo=
--000000000000aff54f0652ba6654--