Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1uylW4-00COi2-E9
	for pgsql-hackers@arkaria.postgresql.org; Wed, 17 Sep 2025 06:19:44 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1uylW1-0059Bf-8E
	for pgsql-hackers@arkaria.postgresql.org; Wed, 17 Sep 2025 06:19:42 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <amit.kapila16@gmail.com>)
	id 1uylW0-0059BV-Uk
	for pgsql-hackers@lists.postgresql.org; Wed, 17 Sep 2025 06:19:41 +0000
Received: from mail-lj1-x233.google.com ([2a00:1450:4864:20::233])
	by magus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
	(Exim 4.96)
	(envelope-from <amit.kapila16@gmail.com>)
	id 1uylVs-001GJv-2a
	for pgsql-hackers@lists.postgresql.org;
	Wed, 17 Sep 2025 06:19:36 +0000
Received: by mail-lj1-x233.google.com with SMTP id
 38308e7fff4ca-352323388b6so43192541fa.3
        for <pgsql-hackers@lists.postgresql.org>;
 Tue, 16 Sep 2025 23:19:33 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20230601; t=1758089973; x=1758694773;
 darn=lists.postgresql.org;
        h=content-transfer-encoding:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:from:to:cc:subject:date
         :message-id:reply-to;
        bh=xMgcA2ntZ1ftI3Hhpgphc50eRDzDKxS4CSX5JF2lomk=;
        b=Fa57PJ2gHB7G8sM6nDkHyCkxW/e8QtjG5NhIFb8FLkqYHIrXxclJcHlOVF8QuedqCD
         i4EaVyubj3/jf2HZ5laJ80osrTM97hdZGpQ0vZL4vTJBT+d9UdspW8nk6Zwx5zgZGqH8
         RJ88+Q0sA8pWBtbbhReWRebbOboWYRCec+UURm9l0EYFwoiBk+mZVuwGA1ZROdKtLuD9
         OwAZ+qL4ozdFWkedpF8GT/cDmVyUbcJDi0zqtl/JqAfMwDScrm+GUaMd8tuFgf/M8WQL
         OiCAVcQw9eyLlCDFlCLFk1Y5BZndIzYsa2Dh1NFuFISBot20SWm6dgwqn+zoSnX662uF
         GStw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1758089973; x=1758694773;
        h=content-transfer-encoding:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc
         :subject:date:message-id:reply-to;
        bh=xMgcA2ntZ1ftI3Hhpgphc50eRDzDKxS4CSX5JF2lomk=;
        b=XWTIP0tLTahvNwDpe/f/nsMLJHrYaOq6h+NCHhocLSMkTiPA0PMOECvdQFajwYXLMi
         StQGaKccrhn2OGgTSzOZl4t3STGKDqTrDq5I+9xhgYARMbuKbKYEHfc32/IRmlj4KBmI
         eS1+3oAZTtnlgQI0R7TMcCbWm4u039PDP0c4PqPofc9Lo4MLskveqwvN6aci0/VbrH6Q
         elEEkp0sW1E1wfgAaHJl0qTPN2pSNZx420PICrk5mQC04lCDKj/sUfd7gDfMSeTTYU+L
         +SflxoFKPGz5h+D0n0ra+AiWXnZWgU7ReFrAl41vE2Xg018+b+pUnircOkUzwuBvmgke
         rtIQ==
X-Forwarded-Encrypted: i=1;
 AJvYcCUw1loBbARU3+0xFGzSErdg9/qfJReFbFVzzxQoDTYShb3TKinJvUON5nj545WAYvPSqvPbVKCZEuX1Gj+B@lists.postgresql.org
X-Gm-Message-State: AOJu0YzPtdsHQ4EdNVcse/ZHPNSDZrdmt5Czpbzik4f6dFnYUnP0zVEL
	wEA6C0Uow6W/G0GVzXonLgpsM8uf3Ps3e/bx2mLqAEco1QxznZK92XVuo+El6YMiBVqfBM1UGTV
	557n4fbbIIgY9lPoukUAcPuzVeoirPgs=
X-Gm-Gg: ASbGnctA20/aYsJEZDwbUzFtqZyxKkCitX5Xz2WF5MnZwjHbz3hP18NLaEEmQO9lkcx
	z5T4LbHHqmeljqfvxhvvNSYyahwRYF0wMDyVN/NVAIZgsvDjVuw8k8GhVQCBwfn5+undq1BnSNJ
	eva6ydDp6hr5lwOcj8qAuOl/kh+lasUk67LDr1C5COox/aVnzJpCTGhbTvZDtF04fNEs3ymKk0+
	u8A9Y2YStDfi6MODteS
X-Google-Smtp-Source: 
 AGHT+IHJgWZWfhponhyVm0BHIl5IJpmMxFxFJy69c7gf2HTXK4EJhDsbhqLrMIx907plavMDKQya2Vwwy+kD9UOvwUE=
X-Received: by 2002:a2e:b88c:0:b0:353:a8f5:3ebc with SMTP id
 38308e7fff4ca-35f65c8250amr2594381fa.42.1758089972700; Tue, 16 Sep 2025
 23:19:32 -0700 (PDT)
MIME-Version: 1.0
References: 
 <CAMPB6wfe4zLjJL8jiZV5kjjpwBM2=rTRme0UCL7Ra4L8MTVdOg@mail.gmail.com>
 <b9666b93-093b-4c9f-a385-772d6ab5688c@app.fastmail.com>
 <CAMPB6we7+97L72Ru0=WxMDi24xMbZgr2B8Nwoo5i=r=UNuG_gQ@mail.gmail.com>
 <a4ee2198-5309-4b6f-90ef-c08b45a2f572@app.fastmail.com>
 <CAA4eK1JfPPFTmz7mUk26zPH8+qH9UBpkquxw75x7Ngx_D_6XXQ@mail.gmail.com>
 <CAMPB6wfgvWjSvKNPoJkRqaL46geRDoL++Pt_3Czc2QNAdpVQHw@mail.gmail.com>
 <CAA4eK1JC6yB6q52qEZ5dLNWRUEZoO-aa_XKBZ3_mcb=V2z7zug@mail.gmail.com>
 <CAMPB6weUqU6P2w5VUGVSLKWcvU1AQHmW+7O9qc9yD4CB5kEYVA@mail.gmail.com>
 <CAA4eK1Lm_W5j3DPj6PDSTyodGu87QgxpNwwsi-wVR0+B1FSOoA@mail.gmail.com>
 <CAMPB6wckvkKrXVPH5j8Ske2cVedkb-TRLdnOb5e74zYM1CynGw@mail.gmail.com>
 <CAA4eK1+NDjprcKvr0p2GDMTCs9yxFCY41bOd+6avqAm2n+TXdQ@mail.gmail.com>
 <CAMPB6wdc10tc7gpVXG75r51M41zVSabip9Lz7hssWEtyhecWww@mail.gmail.com>
 <OSCPR01MB14966201F1DCB853145912FF1F53DA@OSCPR01MB14966.jpnprd01.prod.outlook.com>
 <CAMPB6wcOWBURHB1igRgCjD3geAemdoATfkKByMwrMM1TgMN64w@mail.gmail.com>
 <OSCPR01MB14966BF4CA9B767C259DBD9CDF53EA@OSCPR01MB14966.jpnprd01.prod.outlook.com>
 <CAMPB6wdtKZLEeZ7UW=DYmXWv8Y=uVGrDqXTMhT19Z4VTzo3cfg@mail.gmail.com>
 <CAA4eK1LHVd8wQzauWgeEV436L7btrCfujPH1sR196sY_Mp8zYA@mail.gmail.com>
 <CAMPB6wdPtjbR93oB1XJtYkRtTR64BJG4o5a+0DSSez=puuyuGA@mail.gmail.com>
 <OSCPR01MB14966FC456D053AB00A2EB278F514A@OSCPR01MB14966.jpnprd01.prod.outlook.com>
In-Reply-To: 
 <OSCPR01MB14966FC456D053AB00A2EB278F514A@OSCPR01MB14966.jpnprd01.prod.outlook.com>
From: Amit Kapila <amit.kapila16@gmail.com>
Date: Wed, 17 Sep 2025 11:49:20 +0530
X-Gm-Features: AS18NWBkeGyxh0oS1Z3cKhbOvr72knQAarwBToEugFGMcvRTFrSLARAcxSwiYto
Message-ID: 
 <CAA4eK1++mHd-SsHyJd2ZB26F7kCz--LbtjQLuQ0h3z9mcYK-AQ@mail.gmail.com>
Subject: Re: [Patch] add new parameter to pg_replication_origin_session_setup
To: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
Cc: Doruk Yilmaz <doruk@mixrank.com>,
	"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/CAA4eK1%2B%2BmHd-SsHyJd2ZB26F7kCz--LbtjQLuQ0h3z9mcYK-AQ%40mail.gmail.com>
Precedence: bulk

On Tue, Sep 16, 2025 at 10:07=E2=80=AFAM Hayato Kuroda (Fujitsu)
<kuroda.hayato@fujitsu.com> wrote:
>
> Dear Doruk,
>
> Thanks for updating the patch and sorry for being late.
> The new patch looks good to me.
>

Can we think of writing a few tests for this newly exposed functionality?

--=20
With Regards,
Amit Kapila.