Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tIOJR-00E2t4-9L for pgsql-hackers@arkaria.postgresql.org; Tue, 03 Dec 2024 08:31:17 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tIOJO-008LIM-HN for pgsql-hackers@arkaria.postgresql.org; Tue, 03 Dec 2024 08:31:15 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tIOJO-008LID-34 for pgsql-hackers@lists.postgresql.org; Tue, 03 Dec 2024 08:31:15 +0000 Received: from mail-ot1-x32a.google.com ([2607:f8b0:4864:20::32a]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1tIOJM-000nOq-R4 for pgsql-hackers@lists.postgresql.org; Tue, 03 Dec 2024 08:31:14 +0000 Received: by mail-ot1-x32a.google.com with SMTP id 46e09a7af769-71d50b89132so1985619a34.2 for ; Tue, 03 Dec 2024 00:31:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733214672; x=1733819472; darn=lists.postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ewJ+iCVnIsP4bqt5WenpoTbxROKC1bb3jeIexYrmIhk=; b=NOSdR8nUIG1N+wlBxM4xGke9IvwxZhIRRwzJ9/Swd4n/up2/F2k+OeFoQB5Ceg0msy Eaf6BgKlL9GGO0E1+R/PlkKL/tnlKGaVSzcx2LPUBTAcOxSIwa4dcjohwhJjuQfuUwsN nypeGbwX8fX21hLGHgyCFe3GVUOiRyF/6C5epviMXQJ3XpJqLleiBljOF4XCHb80tECi PyX8T5U4+Y3dLnL7UVmqjjzq4gSnLayqTY5oOE3pMY4mYYrAxTmCTF/LFnt+fokmSruM 3dFE+3yYLWRZw9Uddsdwdfxpu9jcPNGT+rJLHcQhTBmqdDMg72zvIbgSSU/dAs42Y8HN O5lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733214672; x=1733819472; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ewJ+iCVnIsP4bqt5WenpoTbxROKC1bb3jeIexYrmIhk=; b=snZKGATABJY0wElYqz0xEzg/UN6FxXQWtUARXjCFNwH8PE6jy4hruIHz0po8jEJoo0 JfPqyKg9QZwdxZelQYzWqixX4KsXa/MA5EKt78CddjOLoHeuIL+kaaI7mLOKrxySAiIw tTHecucby/dqaM8vU72Ru6Y/ZaD91BRy+k1LhgX5fPOZmHSL1YGeFVcrhbEnr6kPw9ly W/AHJ8BngvVwCsFeSztx2wQDC8b3QZLf5LkjJ/IcGvFyiTBqfkVurdrz/X9lq9JA2TV9 wxFVTWPpqQPR7MGxBN9nYA+dQGHSe9ARK1p5RnbbaXZBlT3R2+2c9pmtNY6n/PMAzcCx KL5A== X-Forwarded-Encrypted: i=1; AJvYcCVrDnxKMAy/CuCsWv5rjZk8wd7CaAxFKy25wtxkYaAtdcnGaF4LM24SYIoeimu5yDAH5jfmEfeLxo8NPKRn@lists.postgresql.org X-Gm-Message-State: AOJu0Yz/HYVvuUPZNiyG7ulNwjVzSLI7TVKkB96Q3T3PAG5i4Xc/1t9K dg5yYVLHT7xY8DQJEcLTqFUwCwNz5SUr12RSMCeMVNGCRxIvOOQQ3VfpsokNJTap5ZnlylU773f yFOBJbIDZ5jtCZiM0+rRMIlptSDnfkT68 X-Gm-Gg: ASbGncsZ2A22UH+Ku/R9rvBucQ8XS9BC5hS6tF5mIblsHcM0Xdi9POb8wLEFTW1L/nq sLVdJSQsV3UKR8mDXr/lpUdhRAmNofSznsg== X-Google-Smtp-Source: AGHT+IG23tmhSpP2b9zcOZsWyCpApHgVYx3Rx4L29eL/waekyXaI7va0Xw7N9ZAP2MSm3XXIXQKUjOfkeJId5uWmA48= X-Received: by 2002:a05:6830:b93:b0:718:1987:24cb with SMTP id 46e09a7af769-71dad60791bmr1102879a34.10.1733214672131; Tue, 03 Dec 2024 00:31:12 -0800 (PST) MIME-Version: 1.0 References: <202411300828.hwe55pzx5a4x@alvherre.pgsql> In-Reply-To: From: Amit Kapila Date: Tue, 3 Dec 2024 14:01:00 +0530 Message-ID: Subject: Re: Memory leak in WAL sender with pgoutput (v10~) To: Michael Paquier Cc: Alvaro Herrera , Postgres hackers Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tue, Dec 3, 2024 at 12:17=E2=80=AFPM Michael Paquier wrote: > > So how about the attached that introduces a FreePublication() matching > with GetPublication(), used to do the cleanup? Feel free to comment. > As you would have noted I am fine with the fix on these lines but I suggest holding it till we conclude the memory context point raised by me today. It is possible that we are still leaking some memory in other related scenarios. --=20 With Regards, Amit Kapila.