Re: pgsql: Reduce log level of some logical decoding messages from LOG to D

public inbox for [email protected]  
help / color / mirror / Atom feed

From: Amit Kapila <[email protected]>
To: Fujii Masao <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: pgsql: Reduce log level of some logical decoding messages from LOG to D
Date: Tue, 7 Apr 2026 09:02:54 +0530
Message-ID: <CAA4eK1+4wS-XY6qbhEyiF97Wc_o_t==5uzkZmZ3nKVDhpQpdOg@mail.gmail.com> (raw)
In-Reply-To: <CAA4eK1+VwGQb5T7xH5AXS0XknGGCAVZQLbBcjq9DZikJhViX2g@mail.gmail.com>
References: <[email protected]>
	<CA+TgmoYsu2+YAo9eLGkDp5VP-pfQ-jOoX382vS4THKHeRTNgew@mail.gmail.com>
	<CAHGQGwEhtaT6qe5fN--t6HhTwBvBoZUukx-NVPpEMG9uFWHHvw@mail.gmail.com>
	<CA+TgmoYwebE37qZwcNE9MKT4rt3ymP2s1M6KyRK_MGkxCYZMeg@mail.gmail.com>
	<CAHGQGwFARNb_2J1Skvw5RQSsyhqUqWQgQJNDhP+v-7fzinLfOw@mail.gmail.com>
	<CA+TgmoZ2+HQess2QSuZp1si17CDHw165PQROaFq0skcKJS20-g@mail.gmail.com>
	<CAHGQGwFf+cpgw3T=NsGF8cxm4zx74AMCdajDda2Z7OXq9YM1mQ@mail.gmail.com>
	<CAA4eK1+VwGQb5T7xH5AXS0XknGGCAVZQLbBcjq9DZikJhViX2g@mail.gmail.com>

On Tue, Apr 7, 2026 at 8:48 AM Amit Kapila <[email protected]> wrote:
>
> On Tue, Apr 7, 2026 at 8:34 AM Fujii Masao <[email protected]> wrote:
> >
> > On Tue, Apr 7, 2026 at 1:16 AM Robert Haas <[email protected]> wrote:
> > > > But probably are you suggesting making this behavior the default? If yes,
> > > > one straightforward approach to implement that would be to log these messages
> > > > at LOG when AmWalSenderProcess() or AmLogicalSlotSyncWorkerProcess() is true,
> > > > and at DEBUG1 otherwise.
> > >
> > > Yeah.
> >
> > OK, I've prepared a patch to implement this. Patch attached.
> > It introduces a LogicalDecodingLogLevel() macro to choose the log level
> > based on context, but the name may not be ideal, so suggestions are welcome.
> >
>
> How about adding repack_worker to that check as well? See 28d534e2ae.
>

The other possibility is to use AmRegularBackendProcess() to decide
the log_level in this case.

-- 
With Regards,
Amit Kapila.

view thread (15+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: pgsql: Reduce log level of some logical decoding messages from LOG to D
  In-Reply-To: <CAA4eK1+4wS-XY6qbhEyiF97Wc_o_t==5uzkZmZ3nKVDhpQpdOg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox