Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1sohTi-00D8wE-Tx
	for pgsql-hackers@arkaria.postgresql.org; Thu, 12 Sep 2024 10:55:11 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1sohTi-004heL-EH
	for pgsql-hackers@arkaria.postgresql.org; Thu, 12 Sep 2024 10:55:10 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <amit.kapila16@gmail.com>)
	id 1sohTi-004hck-3k
	for pgsql-hackers@lists.postgresql.org; Thu, 12 Sep 2024 10:55:10 +0000
Received: from mail-oi1-x236.google.com ([2607:f8b0:4864:20::236])
	by magus.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
	(Exim 4.94.2)
	(envelope-from <amit.kapila16@gmail.com>)
	id 1sohTe-000o0L-Iz
	for pgsql-hackers@lists.postgresql.org; Thu, 12 Sep 2024 10:55:09 +0000
Received: by mail-oi1-x236.google.com with SMTP id 5614622812f47-3e045525719so472476b6e.2
        for <pgsql-hackers@lists.postgresql.org>; Thu, 12 Sep 2024 03:55:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20230601; t=1726138506; x=1726743306; darn=lists.postgresql.org;
        h=content-transfer-encoding:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:from:to:cc:subject:date
         :message-id:reply-to;
        bh=zKSVa9bLI9tLgbw9ZxN8IdMVfO9BX0ScJ4/0dCijhgQ=;
        b=IF1LnsyLSACMzKiVyFirEn+/q00L3htd4NhILPVPh5cqEfCjbDdFEq9XdUoDjCe0H6
         okwLz+hkR532CRnodX9S6+AUsRO9D+viClno1eZVfPyROg6jo4y9EQ6By/OVtCb8B8uV
         j4lAWLpLfmBNHdfPI+CUOpE2ZwyRr2ijH3p/+NrqFdYhG6D027J3bavrj0nU0/L/8fyp
         305WcEuOFcAhTBMqseCqmPNR5t5cUdqGm0XtQfDbPiX5MVuWMuucA806jPmA4RqwK/ti
         34GWTc6cBxU+3LsuIuuCCrCxOMm2HUSexVCKgvLtvZfebUB5Pukj1tYpI5wLuzHupHwm
         iAwg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1726138506; x=1726743306;
        h=content-transfer-encoding:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc
         :subject:date:message-id:reply-to;
        bh=zKSVa9bLI9tLgbw9ZxN8IdMVfO9BX0ScJ4/0dCijhgQ=;
        b=TAYRaX2o4M2GPnH5ASFJkqqvms5HAtTEDRn79UxQiwI1m4+PuvRWit7P/1BEmiANI8
         v1824TdRr4FCeNXnY3eoQ3MbuiG8Ydvf8yEt+2MkbDS+GjWUnuxlxrD4toJYjt+CJp9j
         qVZXXP/kmIEWUDbm6kNQMrq+NZ6B2FHUwrhRj5JPsvaVPYa47pK+FtB/IOBMbF4o9Tyl
         rMGkZSBdFx0mVCKM+goxFU0/qqjAvC27ZmZer4lqwW4XOg/5ki3enujqijTf2T7VHTzH
         ODQmvgp2ghLykgGnBjJBLUVLKWTGVw80e7q0jJLTzpBnXNTwvZfgMbU4Z5BeWJnySJwF
         XceA==
X-Forwarded-Encrypted: i=1; AJvYcCV1tNzd6rCo6Q9lLf19dUesercTAsjmDNeclXmf7XfbJVLLV2efFsDjjRbOyPKgfE85Xx0h/CXqvfYgUAlb@lists.postgresql.org
X-Gm-Message-State: AOJu0YxuIiglIbEwxPQgRp4EAC39PO351TicLtoKvygNmQqEZcRxa3BQ
	YLgL1n4G4qSIu+BmpeUCyt73/nij+AfgkJ3oSPnsEc58/W5pn6QHAsincPfrml9lD3zmYeCcyfp
	cD4/r/9AYkzbUQBWXpXP8mbKrllY=
X-Google-Smtp-Source: AGHT+IG+VQFzkRQAjOHBh9QsD5SOGSTQNBq+Iw5Zu8NxQVF61j5m0HydYE6H6/kX0Kv6pYsjk8yTx1MlgAK/4srfViI=
X-Received: by 2002:a05:6808:1524:b0:3e0:39f6:48ba with SMTP id
 5614622812f47-3e071ae6331mr1676215b6e.33.1726138505587; Thu, 12 Sep 2024
 03:55:05 -0700 (PDT)
MIME-Version: 1.0
References: <CALj2ACW4fSOMiKjQ3=2NVBMTZRTG8Ujg6jsK9z3EvOtvA4vzKQ@mail.gmail.com>
 <CAHut+PtvnyH2-U4=XmqDOQSkw5arB=A5B9xbYBPvM5uPU2BG_g@mail.gmail.com>
 <CALj2ACVh8otuX5HS1bB5=ikVk4UNHCkOaw2CbqTv1-E4J82p=g@mail.gmail.com> <CAJpy0uBQTn1ZWZQp=UJmxDvoLWnQcDNQPkSkw7HtS_4tC3WvTw@mail.gmail.com>
In-Reply-To: <CAJpy0uBQTn1ZWZQp=UJmxDvoLWnQcDNQPkSkw7HtS_4tC3WvTw@mail.gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
Date: Thu, 12 Sep 2024 16:24:53 +0530
Message-ID: <CAA4eK1+6sefpRsnDyDbhKUcDmWXw3+XCRmCh0X+mgy1KW+XVNg@mail.gmail.com>
Subject: Re: Disallow altering invalidated replication slots
To: shveta malik <shveta.malik@gmail.com>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, 
	Peter Smith <smithpb2250@gmail.com>, 
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/CAA4eK1%2B6sefpRsnDyDbhKUcDmWXw3%2BXCRmCh0X%2Bmgy1KW%2BXVNg%40mail.gmail.com>
Precedence: bulk

On Wed, Sep 11, 2024 at 8:41=E2=80=AFAM shveta malik <shveta.malik@gmail.co=
m> wrote:
>
> On Tue, Sep 10, 2024 at 11:24=E2=80=AFPM Bharath Rupireddy
> <bharath.rupireddyforpostgres@gmail.com> wrote:
> >
> >
> > Please find the attached v2 patch also having Shveta's review comments
> > addressed.
>
> The v2 patch looks good to me.
>

LGTM as well. I'll push this tomorrow morning unless there are more
comments or suggestions.

--=20
With Regards,
Amit Kapila.