MIME-Version: 1.0
References: <3222278.1716139817@sss.pgh.pa.us> <61182a55-87e6-4019-9274-5f2cc5c38f31@app.fastmail.com>
 <CAA4eK1J22UEfrqx222h5j9DQ7nxGrTbAa_BC+=mQXdXs-RCsew@mail.gmail.com> <CA+TgmoYZ4gRD4uf7Uy3uoyaqZMYwdDX-N0g810QYpD83Lkt7OA@mail.gmail.com>
In-Reply-To: <CA+TgmoYZ4gRD4uf7Uy3uoyaqZMYwdDX-N0g810QYpD83Lkt7OA@mail.gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
Date: Thu, 23 May 2024 14:10:35 +0530
Message-ID: <CAA4eK1+6zgma_Y0wpyvw=D3baht+U+rPSdWeV9ahpg1sSc16Dw@mail.gmail.com>
Subject: Re: State of pg_createsubscriber
To: Robert Haas <robertmhaas@gmail.com>
Cc: Euler Taveira <euler@eulerto.com>, Tom Lane <tgl@sss.pgh.pa.us>, 
	pgsql-hackers@lists.postgresql.org, 
	Euler Taveira <euler.taveira@enterprisedb.com>, Peter Eisentraut <peter@eisentraut.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CAA4eK1%2B6zgma_Y0wpyvw%3DD3baht%2BU%2BrPSdWeV9ahpg1sSc16Dw%40mail.gmail.com>
Precedence: bulk

On Wed, May 22, 2024 at 8:02=E2=80=AFPM Robert Haas <robertmhaas@gmail.com>=
 wrote:
>
> On Mon, May 20, 2024 at 2:42=E2=80=AFAM Amit Kapila <amit.kapila16@gmail.=
com> wrote:
> > Just to summarize, apart from BF failures for which we had some
> > discussion, I could recall the following open points:
> >
> > 1. After promotion, the pre-existing replication objects should be
> > removed (either optionally or always), otherwise, it can lead to a new
> > subscriber not being able to restart or getting some unwarranted data.
> > [1][2].
> >
> > 2. Retaining synced slots on new subscribers can lead to unnecessary
> > WAL retention and dead rows [3].
> >
> > 3. We need to consider whether some of the messages displayed in
> > --dry-run mode are useful or not [4].
>
> Amit, thanks for summarzing your understanding of the situation. Tom,
> is this list complete, to your knowledge? The original thread is quite
> complex and it's hard to pick out what the open items actually are.
> :-(
>
> I would like to see this open item broken up into multiple open items,
> one per issue.
>
> Link [4] goes to a message that doesn't seem to relate to --dry-run.
>

Sorry, for the wrong link. See [1] for the correct link for --dry-run
related suggestion:

[1] https://www.postgresql.org/message-id/CAA4eK1J2fAvsJ2HihbWJ_GxETd6sdqSM=
rZdCVJEutRZRpm1MEQ%40mail.gmail.com

--=20
With Regards,
Amit Kapila.