Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pJnL1-0007SO-Ej for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Jan 2023 03:17:39 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pJnKz-0006fn-Po for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Jan 2023 03:17:37 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pJnKz-0006fe-EQ for pgsql-hackers@lists.postgresql.org; Mon, 23 Jan 2023 03:17:37 +0000 Received: from mail-oa1-x2f.google.com ([2001:4860:4864:20::2f]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pJnKu-0003n9-5N for pgsql-hackers@lists.postgresql.org; Mon, 23 Jan 2023 03:17:36 +0000 Received: by mail-oa1-x2f.google.com with SMTP id 586e51a60fabf-15f64f2791dso12635288fac.7 for ; Sun, 22 Jan 2023 19:17:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=BHhSqiwzcFmr7aOS6geh+cfa8UAupMNgVyisDlgKydA=; b=HZV+FtUBEImiC9WkHkKYQiUPSyDsZvICt6C1JTllUQ2ONwNPHzjJLLHnhnItk8NrGS 3PFyXfs6UiMPOvDoK37suhsiV2FLP2HAJ6Ktxip9Y9b7/oeUqogFvryRnO3Gl+ftYCn1 yaIv3UWx+ukL5j6tPb5BvBZyPUESKT0lNmBvc3qELWCTdNCCk5gOSI2pcG4uR1tfq6Ul 5HW5/fmCOUbYJ1Sjc/iKDRpt66PlIxRa0+GKmdG+fEXd9ZH/IoYgVXrV4dJxW65YqZer 7Y58GmraBf01QKhPVtEauPQT5xLBOBqVWpFJV+xxk4+zHiaDeMyUsOk6LAZ4p6/yw4lt JGQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BHhSqiwzcFmr7aOS6geh+cfa8UAupMNgVyisDlgKydA=; b=OTD36I1vW5xuRUWa5UsBln+Se5o+KlAa+AtkM+GRupOU3/Ol9RLCCav1ASk1emLF1k UZQmGzKw5orstGKUbtNkOqjLoS4xxnTl69KRcvyaGYFKDpwONiAONhiW4FASykHF6830 HSHtnOz29cnzg/86uHd/Srq7OlTLREbeeV8Hl5gSfxK2Iw/xL/5c71JCfBxCBkbNkbaw 9pIPVXVWSu9c4+dCy1prC2jRZdwa7OkG93g964qiKAntrGOBVpLB2OtwNSo3qEtDyGd0 kCKWE4Iy0C2va8AWhj63V9hr/m2y8YwG3TvE0s+MojJQ6dTlGXEEfgFDeLgVz0F81TSg uCcQ== X-Gm-Message-State: AFqh2kqSoJnhIrvw+pbWJC10dxRhBjUI+9MSddRKgBW31yz1hP6sLJcL 9WOayWE3A5oxYQLpN1XSX6u7aBu5NqpTYk4kW/k= X-Google-Smtp-Source: AMrXdXsr0ptp7Y7lm2N2hKyH0HxWtoHtyUqMwJNB4x7+/3luAoGyYy+Nej7hDuwu5qURVhMew3KpZy52sSjIdEQksBg= X-Received: by 2002:a05:6870:2c95:b0:144:c77a:1467 with SMTP id oh21-20020a0568702c9500b00144c77a1467mr1782515oab.272.1674443850119; Sun, 22 Jan 2023 19:17:30 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Amit Kapila Date: Mon, 23 Jan 2023 08:47:18 +0530 Message-ID: Subject: Re: Perform streaming logical transactions by background workers and parallel apply To: Masahiko Sawada Cc: Peter Smith , "houzj.fnst@fujitsu.com" , shveta malik , "wangw.fnst@fujitsu.com" , "shiy.fnst@fujitsu.com" , PostgreSQL Hackers , Dilip Kumar Content-Type: text/plain; charset="UTF-8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Fri, Jan 20, 2023 at 11:48 AM Masahiko Sawada wrote: > > > > > Yet another way is to use the existing parameter logical_decode_mode > > [1]. If the value of logical_decoding_mode is 'immediate', then we can > > immediately switch to partial serialize mode. This will eliminate the > > dependency on timing. The one argument against using this is that it > > won't be as clear as a separate parameter like > > 'stream_serialize_threshold' proposed by the patch but OTOH we already > > have a few parameters that serve a different purpose when used on the > > subscriber. For example, 'max_replication_slots' is used to define the > > maximum number of replication slots on the publisher and the maximum > > number of origins on subscribers. Similarly, > > wal_retrieve_retry_interval' is used for different purposes on > > subscriber and standby nodes. > > Using the existing parameter makes sense to me. But if we use > logical_decoding_mode also on the subscriber, as Shveta Malik also > suggested, probably it's better to rename it so as not to confuse. For > example, logical_replication_mode or something. > +1. Among the options discussed, this sounds better. -- With Regards, Amit Kapila.