Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pELCY-0002yN-Qo for pgsql-hackers@arkaria.postgresql.org; Sun, 08 Jan 2023 02:14:22 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pELCW-0005G8-Ao for pgsql-hackers@arkaria.postgresql.org; Sun, 08 Jan 2023 02:14:20 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pELCW-0005Fs-0N for pgsql-hackers@lists.postgresql.org; Sun, 08 Jan 2023 02:14:20 +0000 Received: from mail-oi1-x230.google.com ([2607:f8b0:4864:20::230]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pELCS-0007pw-Lc for pgsql-hackers@lists.postgresql.org; Sun, 08 Jan 2023 02:14:19 +0000 Received: by mail-oi1-x230.google.com with SMTP id o66so4385834oia.6 for ; Sat, 07 Jan 2023 18:14:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=EyaJi0smDFRANyN4tc95B4UKNdry62/+TBkd8xR1M1M=; b=dkBbdk+60hSwCWWxbVULrD2MT1vMQY2nNuagylmYuFq+CJSUAkRfUrxvFyVPLQk/i4 pSKO8VVJb4WUz6YGNXiWFhQ4VtZNrvRxXBY+mscizWuawvXB4Vmmz+AsS+yJblYFHEj/ HA9LwWhK27+8cP6ficfQozip0I5xJWnJIKJ4rGHYaDClUql0A8LQSqwx5+2dXV3eB3Ed SBlaivSS0jT030almPc23/aNEnnW2n1Gz8uwosdKi9XZLruJAc59sE9to4Z6qSwUoOdf w4ptTLn8PuVS22h2kuOGRCUm60uUn4cMnGtmYMGS+OFHIQQ8jqlE7FNm8NizCETiJQBz NzKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EyaJi0smDFRANyN4tc95B4UKNdry62/+TBkd8xR1M1M=; b=GPseBd0l5KoILnj4feAKFKwgZlH668J9bZ4pAE0sIf45b/+D4TgIt9heaT02A6shjY hNoYce1AK6aWdteoSKNykoU+V/YrtZpxGnFPxY/ZNqq2c2oIdilDub2EGzwQriBnTpGE ht0Esy/iYB9d/jEeuagS7A9EZYZ9dqizOc4NUc+RsneRNzwxTofKIdn+G8eI6BYVob08 CFqWzyOSbIOsixE3w+6BtiW5q8XbsIXLlCwFXaz8XXFy+RZ10O4ZOVv5kxejAO5wPB9x pPA4U6GfIaw0/dgdK5O3XbnR7KwX/Bv1pbjv6eO2YL15Bj63xrtaVgZVCUNM94iKcqUt SyBA== X-Gm-Message-State: AFqh2kqhbpL9+VZuxXguPfzaCO7vYQcVYxa8marEvWR9HQIw9OhPDWKb yAdHr367w0ue44xYkEVECL/hW1NBee/cpfqkDEWEWy1XZAY= X-Google-Smtp-Source: AMrXdXuXiNXQUmM3tQZ5PGTTsP2TDrV1dM5CFUDJU7t7Fvq9o/RfqQzVVEHO+9uSKY77T0dP3vw9t6WImLw2IRZEkto= X-Received: by 2002:a54:4404:0:b0:35a:8ab0:70f0 with SMTP id k4-20020a544404000000b0035a8ab070f0mr3634733oiw.272.1673144054616; Sat, 07 Jan 2023 18:14:14 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Amit Kapila Date: Sun, 8 Jan 2023 07:44:03 +0530 Message-ID: Subject: Re: Perform streaming logical transactions by background workers and parallel apply To: Dilip Kumar Cc: "houzj.fnst@fujitsu.com" , Masahiko Sawada , "wangw.fnst@fujitsu.com" , Peter Smith , "shiy.fnst@fujitsu.com" , PostgreSQL Hackers Content-Type: text/plain; charset="UTF-8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Sat, Jan 7, 2023 at 2:25 PM Dilip Kumar wrote: > Today, I was analyzing this patch w.r.t recent commit c6e1f62e2c and found that pa_set_xact_state() should set the latch (wake up) for the leader worker as the leader could be waiting in pa_wait_for_xact_state(). What do you think? But otherwise, it should be okay w.r.t DDLs because this patch allows the leader worker to restart logical replication for subscription parameter change which will in turn stop/restart parallel workers if required. -- With Regards, Amit Kapila.