MIME-Version: 1.0
References: <E1nWTkh-000ncF-2O@gemulon.postgresql.org>
 <20220904081821.bck6q2j6gfp3p2im@alvherre.pgsql>
 <CAA4eK1+=bifvdFw+36pV5Q1LGfdV5seUvVkd+JwaQ+U3G+dBqg@mail.gmail.com>
 <CAD21AoDKLPA6tWqYCpBz3quKARmaMfQ_bM_oH6Erdsbou_O0aw@mail.gmail.com>
In-Reply-To: 
 <CAD21AoDKLPA6tWqYCpBz3quKARmaMfQ_bM_oH6Erdsbou_O0aw@mail.gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
Date: Wed, 7 Sep 2022 09:16:54 +0530
Message-ID: 
 <CAA4eK1+S7h2Tp6hWuEXyVNNrBNeO91pxJNSp3NmNL34FxHZbbQ@mail.gmail.com>
Subject: Re: pgsql: Add ALTER SUBSCRIPTION ... SKIP.
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
 Amit Kapila <akapila@postgresql.org>,
	pgsql-hackers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CAA4eK1%2BS7h2Tp6hWuEXyVNNrBNeO91pxJNSp3NmNL34FxHZbbQ%40mail.gmail.com>
Precedence: bulk

On Tue, Sep 6, 2022 at 7:40 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>
> > > I think they should say something like
> > >
> > > "logical replication starts skipping transaction with LSN %X/%X"
> > > "logical replication completed skipping transaction with LSN %X/%X"
> > >
> >
> > This looks better to me.
>
> +1
>
> > If you find the above argument to
> > differentiate between the start and end LSN convincing then we can
> > think of replacing "with" in the above messages with "finished at". I
> > see your point related to using "finished at" for PREPARE may not be a
> > good idea but I don't have better ideas for the same.
>
> Given that the user normally doesn't need to be aware of the
> difference between start LSN and end LSN in the context of using this
> feature, I think we can use "with LSN %X/%X".
>

Fair enough.

Alvaro, would you like to push your proposed change? Otherwise, I am
happy to take care of this.

-- 
With Regards,
Amit Kapila.