public inbox for [email protected]  

help / color / mirror / Atom feed

From: Amit Kapila <[email protected]>
To: Kyotaro Horiguchi <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Subject: Re: Force streaming every change in logical decoding
Date: Thu, 22 Dec 2022 14:46:04 +0530
Message-ID: <CAA4eK1+bGY5kYSDYzCFjLXYSGBRJJVg7aqdYoobZaLMW_Hk7dg@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAA4eK1KFRdPSGnkHSoR1T+Z08XsaL12fX8xMj_ZpAR6LR+RJYQ@mail.gmail.com>
	<TYAPR01MB58662090E3858FBD84226F6CF5E89@TYAPR01MB5866.jpnprd01.prod.outlook.com>
	<CAD21AoDXHkCo2SLMgm1TxhBKJJ5srMPc=sjzc0webAG9ONk4cA@mail.gmail.com>
	<[email protected]>

On Thu, Dec 22, 2022 at 1:55 PM Kyotaro Horiguchi
<[email protected]> wrote:
>
> At Thu, 22 Dec 2022 16:59:30 +0900, Masahiko Sawada <[email protected]> wrote in
> > On Thu, Dec 22, 2022 at 4:18 PM Hayato Kuroda (Fujitsu)
> > <[email protected]> wrote:
> > >
> > > Dear Amit,
> > >
> > > Thank you for updating the patch. I have also checked the patch
> > > and basically it has worked well. Almost all things I found were modified
> > > by v4.
> > >
> > > One comment: while setting logical_decoding_mode to wrong value,
> > > I got unfriendly ERROR message.
> > >
> > > ```
> > > postgres=# SET logical_decoding_mode = 1;
> > > ERROR:  invalid value for parameter "logical_decoding_mode": "1"
> > > HINT:  Available values: , immediate
> > > ```
> > >
> > > Here all acceptable enum should be output as HINT, but we could not see the empty string.
> > > Should we modify config_enum_get_options() for treating empty string, maybe
> > > like (empty)?
> >
> > Good point. I think the hint message can say "The only allowed value
> > is \"immediate\" as recovery_target does. Or considering the name of
> > logical_decoding_mode, we might want to have a non-empty string, say
> > 'normal' as Kuroda-san proposed, as the default value.
>
> Oh. I missed this, and agree to have the explicit default option.
> I slightly prefer "buffered" but "normal" also works fine for me.
>

+1 for "buffered" as that seems to convey the meaning better.

-- 
With Regards,
Amit Kapila.

view thread (61+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Force streaming every change in logical decoding
  In-Reply-To: <CAA4eK1+bGY5kYSDYzCFjLXYSGBRJJVg7aqdYoobZaLMW_Hk7dg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox