MIME-Version: 1.0
References: 
 <CAHGQGwFzNYroAxSoyJhqTU-pH=t4Ej6RyvhVmBZ91Exj_TPMMQ@mail.gmail.com>
 <CAA4eK1+CrQNqiPDKv1wYfdkbX0FARJoi1=0ioaAqkLzbq2vG1w@mail.gmail.com>
 <CAHGQGwHABvuCoyM24HUiFZ5oJq_CoFomjt_cqD-0cJLMjFXJjQ@mail.gmail.com>
 <CAA4eK1LzZGfRANPAnv6NpKCH2ENuZO6HswgY14A=xsOXmucPhw@mail.gmail.com>
 <CABdArM6nepct0uxizCnZqy-kAjjTOndvu7bWtaNcmknuxx82Hg@mail.gmail.com>
 <CAJpy0uBhJB4HqouLXegD=miSkZfZp86tTC2K0K6nf=bHCcsPLQ@mail.gmail.com>
 <CABdArM6Mfhk2+9TVR_D3cgfPWPfHDuZEg7MOc5KqULwt0OcQUg@mail.gmail.com>
In-Reply-To: 
 <CABdArM6Mfhk2+9TVR_D3cgfPWPfHDuZEg7MOc5KqULwt0OcQUg@mail.gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
Date: Fri, 27 Mar 2026 13:19:58 +0530
Message-ID: 
 <CAA4eK1+d2vN80-Yvy_Hr=ATF3XL5db+_W-sXF=2Vxm+OFBO82w@mail.gmail.com>
Subject: Re: Use SIGTERM instead of SIGUSR1 for slotsync worker to exit during
 promotion?
To: Nisha Moond <nisha.moond412@gmail.com>
Cc: shveta malik <shveta.malik@gmail.com>,
 Fujii Masao <masao.fujii@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAA4eK1%2Bd2vN80-Yvy_Hr%3DATF3XL5db%2B_W-sXF%3D2Vxm%2BOFBO82w%40mail.gmail.com>
Precedence: bulk

On Fri, Mar 27, 2026 at 10:27=E2=80=AFAM Nisha Moond <nisha.moond412@gmail.=
com> wrote:
>
> On Fri, Mar 27, 2026 at 9:28=E2=80=AFAM shveta malik <shveta.malik@gmail.=
com> wrote:
> >
> > In ProcessSlotSyncInterrupts(), now we don't need the below logic right=
?
> >
> > if (SlotSyncCtx->stopSignaled)
> >     {
> >         if (AmLogicalSlotSyncWorkerProcess())
> >         {
> >             ...
> >             proc_exit(0);
> >         }
> >         else
> >         {
> >             /*
> >              * For the backend executing SQL function
> >              * pg_sync_replication_slots().
> >              */
> >             ereport(ERROR,
> >                     errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE),
> >                     errmsg("replication slot synchronization will stop
> > because promotion is triggered"));
> >         }
> >     }
> >
>
> Right. Attached patch with the suggested changes.
>

After this change, why do we need to invoke
ProcessSlotSyncInterrupts() twice in SyncReplicationSlots?

--=20
With Regards,
Amit Kapila.