public inbox for [email protected]help / color / mirror / Atom feed
DOC: pg_publication_rel.prrelid says sequences are possible 4+ messages / 3 participants [nested] [flat]
* DOC: pg_publication_rel.prrelid says sequences are possible @ 2026-04-01 04:59 Peter Smith <[email protected]> 2026-04-01 07:05 ` Re: DOC: pg_publication_rel.prrelid says sequences are possible shveta malik <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Peter Smith @ 2026-04-01 04:59 UTC (permalink / raw) To: PostgreSQL Hackers <[email protected]> Hi. It is my understanding that only tables can exist in the 'pg_publication_rel' catalog. e.g. only for these scenarios: * included tables - when pg_publication.puballtables is false, these are the specified FOR TABLE ... tables * excluded tables - when pg_publication.puballtables is true, these are the specified FOR ALL TABLES EXCEPT (TABLE ...) tables In particular, AFAIK there is no way for sequences to be in the 'pg_publication_rel' catalog. e.g. PG19 only supports "CREATE PUBLICATION ... FOR ALL SEQUENCES", which is indicated by pg_publication.puballsequences. PG19 has no support for "CREATE PUBLICATION ... FOR SEQUENCE seq1,seq2". ~~ Meanwhile, the DOCS page for 'pg_publication_rel' catalog [1] since commit 55cefad says that sequences are also possible [2]: ------ prrelid oid (references pg_class.oid) Reference to table or sequence ------ How are sequences possible? PSA a patch to correct it. Or, am I mistaken here? ====== [1] https://www.postgresql.org/docs/devel/catalog-pg-publication-rel.html [2] https://github.com/postgres/postgres/commit/55cefadde874e52b57f7b3c2232744e331f9d6bb#diff-686ae87477... Kind Regards, Peter Smith. Fujitsu Australia Attachments: [application/octet-stream] v1-0001-DOCS-pg_publication_rel.prrelid.patch (843B, 2-v1-0001-DOCS-pg_publication_rel.prrelid.patch) download | inline diff: From 95ddfbdde67e34a27ac2e150b020c208a7dfc784 Mon Sep 17 00:00:00 2001 From: Peter Smith <[email protected]> Date: Wed, 1 Apr 2026 15:25:52 +1100 Subject: [PATCH v1] DOCS - pg_publication_rel.prrelid --- doc/src/sgml/catalogs.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/catalogs.sgml b/doc/src/sgml/catalogs.sgml index 92d179b5ee0..0b3e6308d56 100644 --- a/doc/src/sgml/catalogs.sgml +++ b/doc/src/sgml/catalogs.sgml @@ -7086,7 +7086,7 @@ SCRAM-SHA-256$<replaceable><iteration count></replaceable>:<replaceable>&l (references <link linkend="catalog-pg-class"><structname>pg_class</structname></link>.<structfield>oid</structfield>) </para> <para> - Reference to table or sequence + Reference to table </para></entry> </row> -- 2.47.3 ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: DOC: pg_publication_rel.prrelid says sequences are possible 2026-04-01 04:59 DOC: pg_publication_rel.prrelid says sequences are possible Peter Smith <[email protected]> @ 2026-04-01 07:05 ` shveta malik <[email protected]> 2026-04-02 08:33 ` Re: DOC: pg_publication_rel.prrelid says sequences are possible Amit Kapila <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: shveta malik @ 2026-04-01 07:05 UTC (permalink / raw) To: Peter Smith <[email protected]>; +Cc: PostgreSQL Hackers <[email protected]> On Wed, Apr 1, 2026 at 10:30 AM Peter Smith <[email protected]> wrote: > > Hi. > > It is my understanding that only tables can exist in the > 'pg_publication_rel' catalog. > > e.g. only for these scenarios: > * included tables - when pg_publication.puballtables is false, these > are the specified FOR TABLE ... tables > * excluded tables - when pg_publication.puballtables is true, these > are the specified FOR ALL TABLES EXCEPT (TABLE ...) tables > > In particular, AFAIK there is no way for sequences to be in the > 'pg_publication_rel' catalog. e.g. > PG19 only supports "CREATE PUBLICATION ... FOR ALL SEQUENCES", which > is indicated by pg_publication.puballsequences. > PG19 has no support for "CREATE PUBLICATION ... FOR SEQUENCE seq1,seq2". > > ~~ > > Meanwhile, the DOCS page for 'pg_publication_rel' catalog [1] since > commit 55cefad says that sequences are also possible [2]: > ------ > prrelid oid (references pg_class.oid) > Reference to table or sequence > ------ > > How are sequences possible? PSA a patch to correct it. > > Or, am I mistaken here? > You are right, pg_publication_rel can never have a seq entry while pg_subscription_rel can have. The patch LGTM. thanks Shveta ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: DOC: pg_publication_rel.prrelid says sequences are possible 2026-04-01 04:59 DOC: pg_publication_rel.prrelid says sequences are possible Peter Smith <[email protected]> 2026-04-01 07:05 ` Re: DOC: pg_publication_rel.prrelid says sequences are possible shveta malik <[email protected]> @ 2026-04-02 08:33 ` Amit Kapila <[email protected]> 2026-04-07 00:25 ` Re: DOC: pg_publication_rel.prrelid says sequences are possible Peter Smith <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Amit Kapila @ 2026-04-02 08:33 UTC (permalink / raw) To: shveta malik <[email protected]>; +Cc: Peter Smith <[email protected]>; PostgreSQL Hackers <[email protected]> On Wed, Apr 1, 2026 at 12:35 PM shveta malik <[email protected]> wrote: > > On Wed, Apr 1, 2026 at 10:30 AM Peter Smith <[email protected]> wrote: > > > > Hi. > > > > It is my understanding that only tables can exist in the > > 'pg_publication_rel' catalog. > > > > e.g. only for these scenarios: > > * included tables - when pg_publication.puballtables is false, these > > are the specified FOR TABLE ... tables > > * excluded tables - when pg_publication.puballtables is true, these > > are the specified FOR ALL TABLES EXCEPT (TABLE ...) tables > > > > In particular, AFAIK there is no way for sequences to be in the > > 'pg_publication_rel' catalog. e.g. > > PG19 only supports "CREATE PUBLICATION ... FOR ALL SEQUENCES", which > > is indicated by pg_publication.puballsequences. > > PG19 has no support for "CREATE PUBLICATION ... FOR SEQUENCE seq1,seq2". > > > > ~~ > > > > Meanwhile, the DOCS page for 'pg_publication_rel' catalog [1] since > > commit 55cefad says that sequences are also possible [2]: > > ------ > > prrelid oid (references pg_class.oid) > > Reference to table or sequence > > ------ > > > > How are sequences possible? PSA a patch to correct it. > > > > Or, am I mistaken here? > > > > You are right, pg_publication_rel can never have a seq entry while > pg_subscription_rel can have. The patch LGTM. > Pushed. -- With Regards, Amit Kapila. ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: DOC: pg_publication_rel.prrelid says sequences are possible 2026-04-01 04:59 DOC: pg_publication_rel.prrelid says sequences are possible Peter Smith <[email protected]> 2026-04-01 07:05 ` Re: DOC: pg_publication_rel.prrelid says sequences are possible shveta malik <[email protected]> 2026-04-02 08:33 ` Re: DOC: pg_publication_rel.prrelid says sequences are possible Amit Kapila <[email protected]> @ 2026-04-07 00:25 ` Peter Smith <[email protected]> 0 siblings, 0 replies; 4+ messages in thread From: Peter Smith @ 2026-04-07 00:25 UTC (permalink / raw) To: Amit Kapila <[email protected]>; +Cc: shveta malik <[email protected]>; PostgreSQL Hackers <[email protected]> On Thu, Apr 2, 2026 at 7:33 PM Amit Kapila <[email protected]> wrote: > > On Wed, Apr 1, 2026 at 12:35 PM shveta malik <[email protected]> wrote: > > ... > > You are right, pg_publication_rel can never have a seq entry while > > pg_subscription_rel can have. The patch LGTM. > > > > Pushed. Thanks for pushing. ====== Kind Regards, Peter Smith. Fujitsu Australia ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2026-04-07 00:25 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-04-01 04:59 DOC: pg_publication_rel.prrelid says sequences are possible Peter Smith <[email protected]> 2026-04-01 07:05 ` shveta malik <[email protected]> 2026-04-02 08:33 ` Amit Kapila <[email protected]> 2026-04-07 00:25 ` Peter Smith <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox