MIME-Version: 1.0
References: 
 <OSOPR01MB1215385EAC6A76650444E40B0F54FA@OSOPR01MB12153.jpnprd01.prod.outlook.com>
 <TYRPR01MB12156F431E4B83ECFF14034BDF54CA@TYRPR01MB12156.jpnprd01.prod.outlook.com>
 <CAEqnbaXb-TKUm7P-=_zrgQ=shRXkkZscPOHEL9OS6Cb2V8YT8Q@mail.gmail.com>
 <CAA4eK1JiAzaY7UYnya7uDhX-kAL1PrsOAxBtys7c35t4q4H3_A@mail.gmail.com>
 <CAEqnbaVF0yXQk=VVzr-8V23E=iUpUqyah6hxx2fy0ZVJh+CaGA@mail.gmail.com>
 <CAJpy0uAwPNG3GN5+jTajnccLe+F1mW6dZh-9112u3QQQYugA=Q@mail.gmail.com>
 <CAA4eK1JyYHPgaPTow5co8wBh8Ga+fx=vqHLhk2zHeqdOGYN4Vg@mail.gmail.com>
 <OS9PR01MB12149FECFFF25973C167F9CFAF54BA@OS9PR01MB12149.jpnprd01.prod.outlook.com>
 <CAEqnbaULSSQcir8Z8KDXduV4o4NZvJLeBMZN0VW3wh5QZjpEnw@mail.gmail.com>
 <OS9PR01MB1214926DB01BF19C09368188EF548A@OS9PR01MB12149.jpnprd01.prod.outlook.com>
 <CAHut+PsmdpYZnXKLYJ8n07-ftaPAbvxH9xuNrvm2c6zxS09z7Q@mail.gmail.com>
 <CAEqnbaWsrDhsrBJucqiL7Bx9MKgB3F6imFAE7tF63MZ6okRmAg@mail.gmail.com>
 <CAA4eK1JSg3HKm-cFDv0D5adSk8Kbsd6OG=B=HaOU-tLQt2NZ6Q@mail.gmail.com>
 <4c2eb422-696c-4e34-84e7-6c6cd95781ab@eisentraut.org>
In-Reply-To: <4c2eb422-696c-4e34-84e7-6c6cd95781ab@eisentraut.org>
From: Amit Kapila <amit.kapila16@gmail.com>
Date: Wed, 1 Apr 2026 10:26:53 +0530
Message-ID: 
 <CAA4eK1+f3d=mkbCKrJPP8dH_Rs5COvKZZg5DaSh-1XS_Nzwv3Q@mail.gmail.com>
Subject: Re: [Proposal] Adding Log File Capability to pg_createsubscriber
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Gyan Sreejith <gyan.sreejith@gmail.com>,
 Peter Smith <smithpb2250@gmail.com>,
	"Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>,
 shveta malik <shveta.malik@gmail.com>,
	Shlok Kyal <shlok.kyal.oss@gmail.com>, vignesh C <vignesh21@gmail.com>,
	Euler Taveira <euler@eulerto.com>,
	"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAA4eK1%2Bf3d%3DmkbCKrJPP8dH_Rs5COvKZZg5DaSh-1XS_Nzwv3Q%40mail.gmail.com>
Precedence: bulk

On Tue, Mar 31, 2026 at 5:36=E2=80=AFPM Peter Eisentraut <peter@eisentraut.=
org> wrote:
>
> On 25.03.26 09:25, Amit Kapila wrote:
> > On Wed, Mar 25, 2026 at 5:43=E2=80=AFAM Gyan Sreejith <gyan.sreejith@gm=
ail.com> wrote:
> >>
> >> Thank you, Kuroda-san and Chao for the suggestions and the patch. I ha=
ve merged it with v18-0001, and I have fixed everything that Peter suggeste=
d.
> >>
> >
> > Pushed after minor changes.
>
> Instead of creating a new logging API in pg_createsubscriber locally,
> why not extend logging.c to support a log file.
>

Few things we may want to consider if we want to use extended
logging.c: (a) what if we want information to be written in multiple
files (say pub/sub specific info into separate files), something like
what pg_upgrade does, (b) what if we want to write some info to only
one of terminal or log_file, we can probably extend generic API for
this.

>  This is much simpler,
> doesn't require caller changes, and could be reused elsewhere.  See
> attached patches.  (The 0003 and 0004 are just some additional code
> simplifications.)
>

In 0004,
-static char logdir[MAXPGPATH]; /* Subdirectory of the user specified logdi=
r
+static char *logdir =3D NULL; /* Subdirectory of the user specified logdir

At other places like pg_upgrade, we use MAXPGPATH for a similar case
probably to have standard length on all platforms, see
make_outputdirs() in pg_upgrade.c.

--=20
With Regards,
Amit Kapila.