MIME-Version: 1.0
References: 
 <CA+3i_M98-XjE-_fw0p+8xOnw64y2_YLtJfcwvCfsVMn-z2ZjGg@mail.gmail.com>
 <CABdArM4nF-QTeOsGt40NAngeeH7yJ4RVtMU4hWjVM4=fNYPrdw@mail.gmail.com>
In-Reply-To: 
 <CABdArM4nF-QTeOsGt40NAngeeH7yJ4RVtMU4hWjVM4=fNYPrdw@mail.gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
Date: Tue, 28 Apr 2026 16:27:45 +0530
Message-ID: 
 <CAA4eK1+m1j6Rahj+cB7acxL5hgHVAYTX2kCfPk_YZbywaPNgDg@mail.gmail.com>
Subject: Re: [PATCH] Fix Int32GetDatum used for bool column in CREATE
 SUBSCRIPTION
To: Nisha Moond <nisha.moond412@gmail.com>
Cc: Lakshmi N <lakshmin.jhs@gmail.com>,
	"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAA4eK1%2Bm1j6Rahj%2BcB7acxL5hgHVAYTX2kCfPk_YZbywaPNgDg%40mail.gmail.com>
Precedence: bulk

On Mon, Apr 27, 2026 at 1:59=E2=80=AFPM Nisha Moond <nisha.moond412@gmail.c=
om> wrote:
>
> On Mon, Apr 27, 2026 at 11:03=E2=80=AFAM Lakshmi N <lakshmin.jhs@gmail.co=
m> wrote:
> >
> > Hi hackers,
> >
> > In CreateSubscription(), the subretentionactive catalog column (declare=
d as
> > bool in pg_subscription.h) is populated using Int32GetDatum() instead o=
f
> > BoolGetDatum():
> >
> > This writes 4 bytes into a 1-byte bool Datum. It is inconsistent with t=
he
> > ALTER SUBSCRIPTION path which correctly uses BoolGetDatum().
> >
> > The attached patch fixes this to use BoolGetDatum(), matching both the
> > catalog definition and the ALTER path.
> >
>
> +1
> This looks like an oversight in commit a850be2.
>

Pushed.

--=20
With Regards,
Amit Kapila.