public inbox for [email protected]
help / color / mirror / Atom feedFrom: Amit Kapila <[email protected]>
To: vignesh C <[email protected]>
Cc: Peter Smith <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Add macros for ReorderBufferTXN toptxn
Date: Tue, 14 Mar 2023 17:16:50 +0530
Message-ID: <CAA4eK1+oqfUSC3vpu6bJzgfnSmu_yaeoLS=Rb3416GuS5iRP1Q@mail.gmail.com> (raw)
In-Reply-To: <CALDaNm0_i1Bh5qfnCAsuz-XXEqWe71q0g2rfv0Lh1DkYv6mqPA@mail.gmail.com>
References: <CAHut+PuCznOyTqBQwjRUu-ibG-=KHyCv-0FTcWQtZUdR88umfg@mail.gmail.com>
<CALDaNm1J-V06vNM1JBwP1OJgAQKWntJvfG8gf=3Kfnpm=bE-Yw@mail.gmail.com>
<CAHut+PuRgxhk4GBK8Fm8hgDH=KLGvCjjOvcNXMapHgyN1bQfDA@mail.gmail.com>
<CALDaNm0_i1Bh5qfnCAsuz-XXEqWe71q0g2rfv0Lh1DkYv6mqPA@mail.gmail.com>
On Tue, Mar 14, 2023 at 5:03 PM vignesh C <[email protected]> wrote:
>
> On Tue, 14 Mar 2023 at 12:37, Peter Smith <[email protected]> wrote:
> >
>
> The same issue exists here too:
> 1)
> - if (toptxn != NULL && !rbtxn_has_catalog_changes(toptxn))
> + if (rbtxn_is_subtxn(txn))
> {
> - toptxn->txn_flags |= RBTXN_HAS_CATALOG_CHANGES;
> - dclist_push_tail(&rb->catchange_txns, &toptxn->catchange_node);
> + ReorderBufferTXN *toptxn = rbtxn_get_toptxn(txn);
>
> 2)
> - if (change->txn->toptxn)
> - topxid = change->txn->toptxn->xid;
> + if (rbtxn_is_subtxn(change->txn))
> + topxid = rbtxn_get_toptxn(change->txn)->xid;
>
> If you plan to fix, bothe the above also should be handled.
>
I don't know if it would be any better to change the above two as
compared to what the proposed patch has.
--
With Regards,
Amit Kapila.
view thread (5+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: Add macros for ReorderBufferTXN toptxn
In-Reply-To: <CAA4eK1+oqfUSC3vpu6bJzgfnSmu_yaeoLS=Rb3416GuS5iRP1Q@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox